From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38543CA5E for ; Wed, 6 Aug 2025 12:36:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754483819; cv=none; b=HgHa+rTfM/6GzWHu/8bFw1A/C5OK3+lyh2AdgZFMY99qNUM9wDSjoree+t1C0/4F8x/LKe00ROmXniqCQRh9neyUmfnyeHF6JMFBVTqFuIYT3sG7437KH7oALHHNByNCyqNsTbR7M5imC8+ZCCsglepJa0qNaFwWy5dnbSjhhDg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754483819; c=relaxed/simple; bh=G7x+6kpBp6fozmsPcIUKkcImthyMdvlLovT8zv9K7RE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fSqAFc66SRQnwzxf19asTbRlWWSIAFsEOKfKbzF9N6NBNOX8uXuwqXdG4LQMm0Htj3pnUZDk8jKMVS1E8zI6FQLeeK31ulugA71gISRXMSkqEgGpiI7wnIhi0rP0v7zjfYOJqg7UjYRxJMIv2hpmA1OM6RvdCkG2UqrXzDvVL+k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=djXOkyBC; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="djXOkyBC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754483816; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6Pkv5vGb4vPizTClmmeLaanBjDjkluYiNpS+o2ItZmg=; b=djXOkyBC69IGPh9iC5m5yMRCuTIZpeLl830jfbtCuJn4fAmjJVPuHmO8HLfbIfYJQad02D leKtqLqTktsWDaN+iKU+9eFJpO2LHtUVTRgeoaRDHapV5OWoXYt1FKpCIW94z7gyM4EJIQ lZ9Ajs5JB4pHpHnLfXixYQ+8XEsBkjQ= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-688-w4H-MQfJNNKu0mwcuhcE8Q-1; Wed, 06 Aug 2025 08:36:55 -0400 X-MC-Unique: w4H-MQfJNNKu0mwcuhcE8Q-1 X-Mimecast-MFC-AGG-ID: w4H-MQfJNNKu0mwcuhcE8Q_1754483814 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3b780da0ab6so2927393f8f.0 for ; Wed, 06 Aug 2025 05:36:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754483814; x=1755088614; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=6Pkv5vGb4vPizTClmmeLaanBjDjkluYiNpS+o2ItZmg=; b=IkuuVOHIUlf1pGVBN9HQTUKydUhszS9BmekHNBTdDdtECHbqpevW2dpizSvFZMN1U3 pnSn1WHMYHC8e4xIlVh4efbeo0ghIfLWDtMDiKXwbws1lhnMULmmmt2LgkHjvveESiy8 tofKexDjLaNM8PSMqJI35O0bOCyZCgL2hQSHNS1BH/ttAHw5u6PKP6t8rCqMnT5rzRr9 O9yNaJcuWor2SBa96QwZdb1jxNtBJ7lOpM3ShjbaeLkM2xeATN9Md0JQ+ypsuKFPLzRW eszIqBmQTWig71Nujd8oweC4JjhlnlAMNDWcbH9Q6Jhf2n9QWWl9AWtz8SQWOT4v29aX abhw== X-Forwarded-Encrypted: i=1; AJvYcCXAiGs50IuJxpQZUtCEIj8QnbzdH4XALkKexyA/UnCREo2nR2cqTKhZoVCcvi2YY6lm1HLt8KGQNy3VSrY=@vger.kernel.org X-Gm-Message-State: AOJu0YyqXVE5yeCdo1jEgPifVpNvNoQ8qqH4kd3fH9ArvgLI165OP9wf n9sg8qVGkeP231k11JCDLefofTpkcB3/Sm4OW6wvBcpyXdM4OgT9Pzcqm3K6+/qAEnwco/8GJmn m3Q/TU6WxZESZF5lacFxwQefKFdU3nlbZXMNfkHMDSGfLG+xUD5kn+3Jp1PosaYZtHg== X-Gm-Gg: ASbGnctUDEbw2weOyTSmg8okEP8zAeyPWmDoeh0rMyqPDrSXHMvkchOiHw367qYh+z3 v3/KX1wHpl/Sapwaj1ythsuJdn1QdKE0s+1dPBn7uZe1/XdLq6OUzX41UVedbtSiTcaKXFL/spu qQYAJtxzViktvOySt9sIXdvrRyZ8eJ1OlHSZdMWmxUSBJ2Zi7w1ysiHnEyun6dW69ZTj3TWhZFj LPj3qTXuWhy7AjW7KKwg6gUFm/CfBjlDR0xEOu09UjQdD7Uc2GPnVqSXkzLC4J8ip2iDpEtup+c H8m8tTWqBqtszCyKECrCwDHEJsctTaiPnpPSqpt1jfZroLsfNoObk2Mg1XSVdjKqRZ0DcApZQS/ dX3b+OPLGXTv/WXZN7/7Fa0hAgT6ev7k+YadNFOM/zNLcbunuAxz6jSFohkGcAeH7S7M= X-Received: by 2002:a05:6000:178a:b0:3b6:1630:9204 with SMTP id ffacd0b85a97d-3b8f41660acmr2148739f8f.19.1754483813805; Wed, 06 Aug 2025 05:36:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH/C9vY/dvP1mbV+qxCth5dE78JyvweRZ57dT9MYy/JANGVHP+NO3YKBQ/xfyqGVCamQ0UkKA== X-Received: by 2002:a05:6000:178a:b0:3b6:1630:9204 with SMTP id ffacd0b85a97d-3b8f41660acmr2148692f8f.19.1754483813326; Wed, 06 Aug 2025 05:36:53 -0700 (PDT) Received: from ?IPV6:2003:d8:2f35:8a00:42f7:2657:34cc:a51f? (p200300d82f358a0042f7265734cca51f.dip0.t-ipconnect.de. [2003:d8:2f35:8a00:42f7:2657:34cc:a51f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b79c489e81sm23114781f8f.68.2025.08.06.05.36.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Aug 2025 05:36:52 -0700 (PDT) Message-ID: <9a657c84-99fe-41ba-88ca-097acab4b96b@redhat.com> Date: Wed, 6 Aug 2025 14:36:51 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] mm: add static huge zero folio To: "Pankaj Raghav (Samsung)" Cc: Lorenzo Stoakes , Suren Baghdasaryan , Ryan Roberts , Baolin Wang , Borislav Petkov , Ingo Molnar , "H . Peter Anvin" , Vlastimil Babka , Zi Yan , Mike Rapoport , Dave Hansen , Michal Hocko , Andrew Morton , Thomas Gleixner , Nico Pache , Dev Jain , "Liam R . Howlett" , Jens Axboe , linux-kernel@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, x86@kernel.org, linux-block@vger.kernel.org, Ritesh Harjani , linux-fsdevel@vger.kernel.org, "Darrick J . Wong" , mcgrof@kernel.org, gost.dev@samsung.com, hch@lst.de, Pankaj Raghav References: <20250804121356.572917-1-kernel@pankajraghav.com> <20250804121356.572917-4-kernel@pankajraghav.com> <4463bc75-486d-4034-a19e-d531bec667e8@lucifer.local> <70049abc-bf79-4d04-a0a8-dd3787195986@redhat.com> <6ff6fc46-49f1-49b0-b7e4-4cb37ec10a57@lucifer.local> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06.08.25 14:28, Pankaj Raghav (Samsung) wrote: > On Wed, Aug 06, 2025 at 02:24:28PM +0200, David Hildenbrand wrote: >> On 06.08.25 14:18, Pankaj Raghav (Samsung) wrote: >>>> We could go one step further and special case in mm_get_huge_zero_folio() + >>>> mm_put_huge_zero_folio() on CONFIG_STATIC_HUGE_ZERO_FOLIO. >>>> >>> >>> Hmm, but we could have also failed to allocate even though the option >>> was enabled. >> >> Then we return huge_zero_folio, which is NULL? >> >> Or what are you concerned about? > > But don't we want to keep the "dynamic" allocation part be present even > though we failed to allocate it statically in the shrinker_init? > > Mainly so that the existing users of mm_get_huge_zero_folio() are not affected by > these changes. I would just keep it simple and say that if we fail the early allocation (which will be extremely unlikely that early during boot!), just don't ever try to reallocate, even not when we could through mm_get_huge_zero_folio(). That sounds as simple as it gets. Again, failing to allocate that early and then succeeding to allocate later is a fairly unlikely scenario. -- Cheers, David / dhildenb