mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yicong Yang <yangyicong@huawei.com>
To: Krishna chaitanya chundru <quic_krichai@quicinc.com>
Cc: Shuai Xue <xueshuai@linux.alibaba.com>,
	Jing Zhang <renyu.zj@linux.alibaba.com>,
	Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Yicong Yang <yangyicong@hisilicon.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Jonathan Corbet <corbet@lwn.net>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-doc@vger.kernel.org>, <quic_vbadigan@quicinc.com>,
	<quic_nitegupt@quicinc.com>, <quic_skananth@quicinc.com>,
	<quic_ramkri@quicinc.com>, <quic_parass@quicinc.com>,
	<quic_mrana@quicinc.com>
Subject: Re: [PATCH 2/4] Documentation: dwc_pcie_pmu: Update bdf to sbdf
Date: Thu, 15 Aug 2024 21:44:32 +0800	[thread overview]
Message-ID: <9a6bf90e-ce7f-8a20-93a1-63a75f312392@huawei.com> (raw)
In-Reply-To: <20240731-dwc_pmu_fix-v1-2-ca47d153e5b2@quicinc.com>

On 2024/7/31 12:23, Krishna chaitanya chundru wrote:
> Update document to reflect the driver change to use sbdf instead
> of bdf alone.
> 
> Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>

Reviewed-by: Yicong Yang <yangyicong@hisilicon.com>

> ---
>  Documentation/admin-guide/perf/dwc_pcie_pmu.rst | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/admin-guide/perf/dwc_pcie_pmu.rst b/Documentation/admin-guide/perf/dwc_pcie_pmu.rst
> index d47cd229d710..39b8e1fdd0cd 100644
> --- a/Documentation/admin-guide/perf/dwc_pcie_pmu.rst
> +++ b/Documentation/admin-guide/perf/dwc_pcie_pmu.rst
> @@ -46,16 +46,16 @@ Some of the events only exist for specific configurations.
>  DesignWare Cores (DWC) PCIe PMU Driver
>  =======================================
>  
> -This driver adds PMU devices for each PCIe Root Port named based on the BDF of
> +This driver adds PMU devices for each PCIe Root Port named based on the SBDF of
>  the Root Port. For example,
>  
> -    30:03.0 PCI bridge: Device 1ded:8000 (rev 01)
> +    0001:30:03.0 PCI bridge: Device 1ded:8000 (rev 01)
>  
> -the PMU device name for this Root Port is dwc_rootport_3018.
> +the PMU device name for this Root Port is dwc_rootport_13018.
>  
>  The DWC PCIe PMU driver registers a perf PMU driver, which provides
>  description of available events and configuration options in sysfs, see
> -/sys/bus/event_source/devices/dwc_rootport_{bdf}.
> +/sys/bus/event_source/devices/dwc_rootport_{sbdf}.
>  
>  The "format" directory describes format of the config fields of the
>  perf_event_attr structure. The "events" directory provides configuration
> @@ -66,16 +66,16 @@ The "perf list" command shall list the available events from sysfs, e.g.::
>  
>      $# perf list | grep dwc_rootport
>      <...>
> -    dwc_rootport_3018/Rx_PCIe_TLP_Data_Payload/        [Kernel PMU event]
> +    dwc_rootport_13018/Rx_PCIe_TLP_Data_Payload/        [Kernel PMU event]
>      <...>
> -    dwc_rootport_3018/rx_memory_read,lane=?/               [Kernel PMU event]
> +    dwc_rootport_13018/rx_memory_read,lane=?/               [Kernel PMU event]
>  
>  Time Based Analysis Event Usage
>  -------------------------------
>  
>  Example usage of counting PCIe RX TLP data payload (Units of bytes)::
>  
> -    $# perf stat -a -e dwc_rootport_3018/Rx_PCIe_TLP_Data_Payload/
> +    $# perf stat -a -e dwc_rootport_13018/Rx_PCIe_TLP_Data_Payload/
>  
>  The average RX/TX bandwidth can be calculated using the following formula:
>  
> @@ -88,7 +88,7 @@ Lane Event Usage
>  Each lane has the same event set and to avoid generating a list of hundreds
>  of events, the user need to specify the lane ID explicitly, e.g.::
>  
> -    $# perf stat -a -e dwc_rootport_3018/rx_memory_read,lane=4/
> +    $# perf stat -a -e dwc_rootport_13018/rx_memory_read,lane=4/
>  
>  The driver does not support sampling, therefore "perf record" will not
>  work. Per-task (without "-a") perf sessions are not supported.
> 

  reply	other threads:[~2024-08-15 13:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-31  4:23 [PATCH 0/4] perf/dwc_pcie: Fix registration issue in multi PCIe controller instances Krishna chaitanya chundru
2024-07-31  4:23 ` [PATCH 1/4] " Krishna chaitanya chundru
2024-08-15 13:40   ` Yicong Yang
2024-08-16  3:41     ` Krishna Chaitanya Chundru
2024-07-31  4:23 ` [PATCH 2/4] Documentation: dwc_pcie_pmu: Update bdf to sbdf Krishna chaitanya chundru
2024-08-15 13:44   ` Yicong Yang [this message]
2024-07-31  4:23 ` [PATCH 3/4] perf/dwc_pcie: Always register for PCIe bus notifier Krishna chaitanya chundru
2024-08-15 13:49   ` Yicong Yang
2024-08-16  3:51     ` Krishna Chaitanya Chundru
2024-08-16  7:42       ` Yicong Yang
2024-07-31  4:23 ` [PATCH 4/4] perf/dwc_pcie: Add support for QCOM vendor devices Krishna chaitanya chundru
2024-08-15 13:51   ` Yicong Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a6bf90e-ce7f-8a20-93a1-63a75f312392@huawei.com \
    --to=yangyicong@huawei.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=corbet@lwn.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=quic_krichai@quicinc.com \
    --cc=quic_mrana@quicinc.com \
    --cc=quic_nitegupt@quicinc.com \
    --cc=quic_parass@quicinc.com \
    --cc=quic_ramkri@quicinc.com \
    --cc=quic_skananth@quicinc.com \
    --cc=quic_vbadigan@quicinc.com \
    --cc=renyu.zj@linux.alibaba.com \
    --cc=will@kernel.org \
    --cc=xueshuai@linux.alibaba.com \
    --cc=yangyicong@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®