From: Monish Chunara <monish.chunara@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Sarthak Garg <sarthak.garg@oss.qualcomm.com>,
Pradeep Pragallapati <pradeep.pragallapati@oss.qualcomm.com>,
Nitin Rawat <nitin.rawat@oss.qualcomm.com>,
Shiraz Hashim <shiraz.hashim@oss.qualcomm.com>
Subject: Re: [PATCH V5 2/3] arm64: dts: qcom: monaco-evk: Enable SDHCI for SD Card via overlay
Date: Thu, 5 Nov 2026 15:54:23 +0530 [thread overview]
Message-ID: <9a6c67a5-cf3e-4ddf-93ed-87f0d3dead70@oss.qualcomm.com> (raw)
In-Reply-To: <cbca4156-a461-4d01-9576-352f719016eb@oss.qualcomm.com>
On 02-09-2026 21:59, Konrad Dybcio wrote:
> On 8/26/26 1:24 PM, Monish Chunara wrote:
>> The monaco EVK board supports either eMMC or SD-card, but only one can
>> be active at a time.
>>
>> Make the base monaco-evk.dtsi storage-agnostic by removing eMMC-specific
>> configuration from it. This allows storage media selection to be handled
>> through device tree overlays.
>>
>> Introduce an SD card overlay that enables the SD Host Controller
>> Interface (SDHCI) for SD-based storage on the monaco EVK board.
>>
>> Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
>> ---
>
> [...]
>
>> +&sdhc1_opp_table {
>> + opp-100000000 {
>> + opp-hz = /bits/ 64 <100000000>;
>> + required-opps = <&rpmhpd_opp_low_svs>;
>> + };
>> +
>> + opp-202000000 {
>> + opp-hz = /bits/ 64 <202000000>;
>> + required-opps = <&rpmhpd_opp_svs_l1>;
>> + };
>> +};
>
> This only adds to the existing table, not removing the existing
> entries
>
> Based on the previous discussions at
>
> https://lore.kernel.org/linux-arm-msm/de10ed05-a0fc-4f84-83ea-8810270ff2d6@oss.qualcomm.com/
>
> I'm not sure this is intended
>
> Konrad
Yes, this is intentional. SD card only uses these 2 frequency options.
The remaining ones in the base files are for eMMC and woouldn't hinder
the SD card functionality.
Instead of maintaining two separate tables, the common one can be
utilized.
Regards,
Monish
next prev parent reply other threads:[~2026-11-05 10:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 11:24 [PATCH V5 0/3] arm64: dts: qcom: Monaco: Enable SDHCI storage support Monish Chunara
2026-08-26 11:24 ` [PATCH V5 1/3] arm64: dts: qcom: monaco: Move eMMC CQE support from SoC to board DT Monish Chunara
2026-09-02 16:26 ` Konrad Dybcio
2026-08-26 11:24 ` [PATCH V5 2/3] arm64: dts: qcom: monaco-evk: Enable SDHCI for SD Card via overlay Monish Chunara
2026-09-02 16:29 ` Konrad Dybcio
2026-11-05 10:24 ` Monish Chunara [this message]
2026-08-26 11:24 ` [PATCH V5 3/3] arm64: dts: qcom: monaco-evk: Add SDHCI support for eMMC " Monish Chunara
2026-09-02 16:26 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a6c67a5-cf3e-4ddf-93ed-87f0d3dead70@oss.qualcomm.com \
--to=monish.chunara@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=nitin.rawat@oss.qualcomm.com \
--cc=pradeep.pragallapati@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sarthak.garg@oss.qualcomm.com \
--cc=shiraz.hashim@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®