From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9AE13C9EE0 for ; Mon, 23 Mar 2026 18:12:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774289534; cv=none; b=NqShUoaOUDVSVK219LPJ/wqzjMumCV9Xb6Qyoqmp3I199K27SJrz3u513tAsmUmE9zobiGvs1N6X+qBuj4KVOUztjsvHBpwKT9gT6iWYbk88Z++N7B+t/oXm15P9oA21vgairmsWxEQ6d2vPUSH7KIzoHhNrHk+vbGHME7tcBbc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774289534; c=relaxed/simple; bh=xF2bAPNppAbfTBIBcDCV+LZAzGseQQW9IhFcftMAsW4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=A/6UaKUsYm/FX+nwihw1tFbA45krBdPY+lapLJV9ro1RMLPIbcc1s2mYShztGBklf5ZcFEZtNTuJqHI8CqFyQZxAzxWMFZP+UDdGeHRErifaYcbcYyBokAtR6KAK1KrOL92t2cOwVXMNlWrGwRIups1/ReV1Xdx5GOboo6n9Qj0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YdmLDwPR; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YdmLDwPR" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-48540d21f7dso36728995e9.0 for ; Mon, 23 Mar 2026 11:12:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774289531; x=1774894331; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CIyRKh/yzbhrSofJPevkwLbR5QRnYf8Ol5laJ4H1+4U=; b=YdmLDwPRAFDXjri6eNne1/45dZWmLd/XyM6dddFTLm5BGMW4TPmdzqaJwOxN9crkI1 Wlg7vZlv7r6AlucbmnxyJ2DhzpOUeFux6Q22QItATdBKLCZFIfWSrTv4ZuqeVn5guyS3 3HR+GRcEhgQkB5dtulXl8FLyZhd9GpnYOgUnRF9p0zxTSP3MGPn+RuNDoAqohCNUc1n8 xt2UIgZDqMlXR6WW5cn3JqT59fM5P6RYTM3MOP4TSmUEvy3crQn8ZROLNAGcubKp4kAW SesBncEzWVnj54lAXJtg6FJy4hYPjLFwEPDmIT7lwrRPn03dkYIHaZZTIL7C8uPrqMVt rP5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774289531; x=1774894331; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CIyRKh/yzbhrSofJPevkwLbR5QRnYf8Ol5laJ4H1+4U=; b=iwPxd/VUPHgVyyt1lggNWxMHAtc0RQIpnDyPSqkFxkQ9zg0jmO2ByEs7xWf5kD57t+ dgaONUT0dswX2sw1yM9yaPbkTU/4HzTSSyEq0hE18l7sC+gpqHtQ4W9UeahZrEaSC5UD KjQzRM3c1MsI/3BUNlSwGvbWhF94KW/YUEagUcBr1qGh6ymwQZzmY9x4674HBYaRH6YC Ib8bExuZnxYgT1c0bYhrTm/Qj4j2RMNOYhW0DiNJiyU9QOJ5LuMx9K5FqfcD95E5aKLu pPRIiGsrl5hbjG1D9Z6/b6UhT7jEWaQiQGTYD9FMOOJs7Zz8onUz1A8brExA2H22QwSp JTqA== X-Forwarded-Encrypted: i=1; AJvYcCVPMRTxC5on8ikZb7DxMxpG0e3kYNxwtUIMb5afXxeoIPvl02V38IKUdwLa575c8k5oESnYt0bqheBGnNU=@vger.kernel.org X-Gm-Message-State: AOJu0YzYHbzziT7DgC4/G+SedA3igV9B32VJqz14f3dSiqdWVPIoo14E sIfnxk/MFe85fsWp/Bi44E8ZpqjcuQb50dlRfuZn/12nej2g3cCtXR13 X-Gm-Gg: ATEYQzz7Q7YmKDA98S27V93C1l/DFCIE0MKw//JgX+PFIOlk8prHxG2KUNPF1L79/N1 yzav5AbXcAxNGDHUTiDjq4S2zAltvXrhjMYz83jyRbLL37gSn2SiKRvluyFmmaTohrAud7Ox2RD K/l+QAEtTDixcUDtDMouZqaaK1zmqOpN6gOTdag7vNHUbQP1TBuUdV0NqUF3XBlO9+AyQNBZE0k FslRhGNbeHtxXQy14wEcJQoCNfCZLzLgrmIofQ9M7upXNJ8uD/TYpQKc1YcUxmohVMNlnC6i9gM MN6qIfEAsMgH3+3haNNSDpY4kNVrYxBv5b5MEOLCf6KbXGuxc/CokEdJKpbVlY7WwyvY1qtXiQa 0Davs5zfmve1BA4d5c2HaEh9OilkRtUoMMGLbA3AvV2/vuCZA3iqv3q5rXoBMKbHocTmmYSvbkv FGtMCERKRuyEWVgnHALD3dTKl4Kb3ed991cUs= X-Received: by 2002:a05:600c:a418:b0:485:3423:727d with SMTP id 5b1f17b1804b1-486ff03f502mr147150825e9.26.1774289530991; Mon, 23 Mar 2026 11:12:10 -0700 (PDT) Received: from [192.168.0.193] ([194.183.54.57]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4870f6e9646sm386325e9.19.2026.03.23.11.12.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Mar 2026 11:12:10 -0700 (PDT) Message-ID: <9a6cc642-aa66-4358-9ad7-9e4cc381a07a@gmail.com> Date: Mon, 23 Mar 2026 19:12:09 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 1/1] leds: Introduce the multi_max_intensity sysfs attribute To: Armin Wolf , lee@kernel.org, pavel@kernel.org Cc: corbet@lwn.net, skhan@linuxfoundation.org, linux-leds@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, wse@tuxedocomputers.com, pobrn@protonmail.com References: <20260314230107.65444-1-W_Armin@gmx.de> <20260314230107.65444-2-W_Armin@gmx.de> Content-Language: en-US From: Jacek Anaszewski In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 3/23/26 11:22 AM, Armin Wolf wrote: [...] >>> led-class-multicolor.h >>> index db9f34c6736e..67ac0ac0fd54 100644 >>> --- a/include/linux/led-class-multicolor.h >>> +++ b/include/linux/led-class-multicolor.h >>> @@ -9,10 +9,33 @@ >>>   #include >>>   #include >>>   +#define LED_USE_MAX_BRIGHTNESS 0 >>> + >>> +/** >>> + * struct mc_subled - Color component description. >>> + * @color_index: Color ID. >>> + * @brightness: Scaled intensity. >>> + * @intensity: Current intensity. >>> + * @max_intensity: Maximum supported intensity value. >>> + * @channel: Channel index. >>> + * >>> + * Describes a color component of a multicolor LED. Many multicolor >>> LEDs >>> + * do no support gobal brightness control in hardware, so they use >>> + * the brightness field in connection with >>> led_mc_calc_color_components() >>> + * to perform the intensity scaling in software. >>> + * Such drivers should set max_intensity to LED_USE_MAX_BRIGHTNESS >> >> I'd just mention here that the field needs to be left initialized to 0, >> to let the LED subsystem to adjust it to max_brightness. Note that in >> case of max_brightness we allow for the same - if it is 0, then >> led-class.c adjusts it to legacy LED_FULL (255). >> > OK, do you think that having LED_USE_MAX_BRIGHTNESS makes sense? Not really, let's drop it. -- Best regards, Jacek Anaszewski