mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Tiwei Bie <tiwei.btw@antgroup.com>,
	linux-erofs@lists.ozlabs.org, xiang@kernel.org
Cc: Jonathan Corbet <corbet@lwn.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	ayushranjan@google.com, Yue Hu <huyue2@coolpad.com>
Subject: Re: [PATCH] erofs: fix inode metadata space layout description in documentation
Date: Tue, 10 Oct 2023 21:06:07 +0800	[thread overview]
Message-ID: <9a6ccef5-3a35-ae0d-2a9c-1703c5038c81@linux.alibaba.com> (raw)
In-Reply-To: <20231010113915.436591-1-tiwei.btw@antgroup.com>

Hi Tiwei,

On 2023/10/10 19:39, Tiwei Bie via Linux-erofs wrote:
> Xattrs, extents, data inline are _placed after_, not _followed by_ the
> corresponding inode. This patch fixes it

Thanks for the patch and sorry about my terrible English...

> 
> Fixes: fdb0536469cb ("staging: erofs: add document")

I'm not sure if it's necessary to tag document fixes anyway
since docs.kernel.org already uses the latest version and
`.rst` format is adapted much later..

I will drop this tag for the next merge window if not urgent.

> Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com>

Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>

Thanks,
Gao Xiang

> ---
>   Documentation/filesystems/erofs.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/filesystems/erofs.rst b/Documentation/filesystems/erofs.rst
> index f200d7874495..57c6ae23b3fc 100644
> --- a/Documentation/filesystems/erofs.rst
> +++ b/Documentation/filesystems/erofs.rst
> @@ -199,7 +199,7 @@ may not. All metadatas can be now observed in two different spaces (views):
>                                           |                  |
>                                           |__________________| 64 bytes
>   
> -    Xattrs, extents, data inline are followed by the corresponding inode with
> +    Xattrs, extents, data inline are placed after the corresponding inode with
>       proper alignment, and they could be optional for different data mappings.
>       _currently_ total 5 data layouts are supported:
>   

  parent reply	other threads:[~2023-10-10 13:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-10 11:39 Tiwei Bie
2023-10-10 12:44 ` Jingbo Xu
2023-10-10 13:06 ` Gao Xiang [this message]
2023-10-10 13:39   ` Tiwei Bie
2023-10-12  1:10   ` Chao Yu
2023-10-12  2:01     ` Gao Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a6ccef5-3a35-ae0d-2a9c-1703c5038c81@linux.alibaba.com \
    --to=hsiangkao@linux.alibaba.com \
    --cc=ayushranjan@google.com \
    --cc=corbet@lwn.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=huyue2@coolpad.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwei.btw@antgroup.com \
    --cc=xiang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®