From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753386AbdCPO4P (ORCPT <rfc822;w@1wt.eu>);
        Thu, 16 Mar 2017 10:56:15 -0400
Received: from foss.arm.com ([217.140.101.70]:35078 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753101AbdCPO4L (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 16 Mar 2017 10:56:11 -0400
Subject: Re: [PATCH] serial: 8250: 8250_core: Fix irq name for 8250 serial irq
References: <20170316122653.19930-1-vigneshr@ti.com>
 <20170316133632.GV21222@n2100.armlinux.org.uk>
To: Russell King - ARM Linux <linux@armlinux.org.uk>,
        Vignesh R <vigneshr@ti.com>
Cc: Jisheng Zhang <jszhang@marvell.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        linux-serial@vger.kernel.org, Jiri Slaby <jslaby@suse.com>,
        linux-arm-kernel@lists.infradead.org
From: Robin Murphy <robin.murphy@arm.com>
Message-ID: <9a6dcf55-0ace-e617-73bc-0472a939b36c@arm.com>
Date: Thu, 16 Mar 2017 14:55:18 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <20170316133632.GV21222@n2100.armlinux.org.uk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 16/03/17 13:36, Russell King - ARM Linux wrote:
> On Thu, Mar 16, 2017 at 05:56:53PM +0530, Vignesh R wrote:
>> Using dev_name() as irq name during request_irq() might be misleading in
>> case of serial over PCI. Therefore use a better alternative name for
>> identifying serial port irqs as "serial" appended with serial_index of
>> the port. This ensures that "serial" string is always present in irq
>> name while port index will help in distinguishing b/w different ports.
> 
> Wouldn't it be better to use the device name (iow, ttySx) rather than
> "serialx" ?
> 
> Maybe a helper function in serial_core.c to format the device name into
> a supplied string, which can be re-used elsewhere, eg, uart_report_port()
> and uart_suspend_port().  IOW:
> 
> const char *uart_port_name(char *buf, size_t n, struct uart_driver *drv,
> 			   struct uart_port *port)
> {
> 	snprintf(buf, n, "%s%d", drv->dev_name,
> 		 drv->tty_driver->name_base + port->line);
> 
> 	return buf;
> }
> 
> which means you can do this:
> 
> 	char name[16];
> 
> 	request_irq(..., uart_port_name(name, sizeof(name), driver, port), ...)
> 
> which also avoids the allocation.

...and makes 'cat /proc/interrupts' particularly fun later:

  8:          0          GICv2  72 Level     ��h	����V!

Unless a suitably long-lived string already exists somewhere else in the
serial core, the allocation is unavoidable, although kasprintf() (or its
devm_ variant) might make matters a little simpler.

Robin.

>  8250 device names are always "ttyS"
> plus a number, so 16 characters (including NULL terminator) should be
> more than sufficient, and that's most likely true of all serial drivers.
> (The longest device name I'm aware of is ttyAMA plus a small integer
> for PL011 ports.)
>