From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B898838BDBA for ; Thu, 22 Jan 2026 07:43:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769067812; cv=none; b=GTko/Ivogg8HEGbDBDLH3hoalr2QtCk5wMkw9Km8QTmf+2mztvP6+ih2WBi1KdZJqhEi5UVKsoKMbBlPEgs/ZlOLbxZii2uIc242Uu49FK4yYhSYqQ9OLxB1CPURXFEbMnqkXVprBle/dX+//xokqZtwUXGER52aN+8O10+7od4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769067812; c=relaxed/simple; bh=JY/en9uM/6LgY/PG4CAVxhbyiXF9Ij9Z/WRcbtiHBms=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jHCqH3d03VICOMaxRzzIlGDCgBJ6yxIfmb2J9OS1MN6eTzLUdbx5KGM2tdj5S6J0ONVvvk6ZFsd6eh6H1Vvo19HKw5M6/n/mHW1zKREuZcObN2L72PnVxn4DpsKRL015wPFy5yToufIff6jWOvp9YHl0yAoXO59HyTH4qUh9i7k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=nwVKO4Yb; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=MFJAkEut; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=ph/Z3pE5; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=zQKl2IqS; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="nwVKO4Yb"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="MFJAkEut"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="ph/Z3pE5"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="zQKl2IqS" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C64215BCC3; Thu, 22 Jan 2026 07:43:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1769067806; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SA14Nw/OY5MOciYSiWN8BJpdP9sMLJwUxS+vtfoM38U=; b=nwVKO4Yb7MS27xXaSzhW4IG13LMfBx+ZNp19IHs4umaV956tdYmABsmrU+xosfp8OsIfrI x1AchfkBubDHFAuuNiXcvmkwH0EhJgxN01ksT6p5edNnlx68h2nUZ611+m11VKaSWcCYGy Lq4HtQev8LVL0kLM4r/Jzt8hzNiD7t0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1769067806; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SA14Nw/OY5MOciYSiWN8BJpdP9sMLJwUxS+vtfoM38U=; b=MFJAkEuto1Kf9bu5xLgLP4FOrY3lkVQtr/JsnGCUA4Qqg2/iQ3QTzddcch+/1mFFXE6snM +TBXFvxJfDrY7vCQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="ph/Z3pE5"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=zQKl2IqS DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1769067805; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SA14Nw/OY5MOciYSiWN8BJpdP9sMLJwUxS+vtfoM38U=; b=ph/Z3pE5M0m/16iCfWHPtNDXBHKT06ObgNDrMpE3YCs7+H5xbSxwR5gzpeg1cLFBMbexSp ewjA++0vsbKT8FGjqUSFLSAdL8gzbhxp0EsekfsqAcUqN5vJo5XZ686qhwT/9YCFnw2dXX dm1UKtLeWhGPtsNHdRtPRAY+xGjyJl0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1769067805; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SA14Nw/OY5MOciYSiWN8BJpdP9sMLJwUxS+vtfoM38U=; b=zQKl2IqSehXMLV0iFReu4yNWIP4XMGiI4RF6n2CprdyfLIhHLqNu/a4DhltCGriFNv1o+4 8ueE09V4eYji88AQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 18A273EA63; Thu, 22 Jan 2026 07:43:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id s9GmBB3VcWn9OgAAD6G6ig (envelope-from ); Thu, 22 Jan 2026 07:43:25 +0000 Message-ID: <9a7533ae-c1a2-4871-923d-500c8b0a3bc7@suse.de> Date: Thu, 22 Jan 2026 08:43:24 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/9] drm: verisilicon: add a driver for Verisilicon display controllers To: Icenowy Zheng , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Drew Fustini , Guo Ren , Fu Wei Cc: Philipp Zabel , Dmitry Baryshkov , Michal Wilczynski , Luca Ceresoli , Han Gao , Yao Zi , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, Han Gao References: <20260116043746.336328-1-zhengxingda@iscas.ac.cn> <20260116043746.336328-4-zhengxingda@iscas.ac.cn> <56e1974c-0fe6-4bdb-918d-fcf6a8b866c1@suse.de> <4afa6f3110790c701c5e24901e9e66560cf21ad0.camel@icenowy.me> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_TO(0.00)[icenowy.me,intel.com,linaro.org,kernel.org,ideasonboard.com,kwiboo.se,gmail.com,linux.intel.com,ffwll.ch,redhat.com]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCPT_COUNT_TWELVE(0.00)[28]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[pengutronix.de,kernel.org,samsung.com,bootlin.com,gmail.com,disroot.org,vger.kernel.org,lists.freedesktop.org,lists.infradead.org,iscas.ac.cn]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TAGGED_RCPT(0.00)[dt]; DKIM_TRACE(0.00)[suse.de:+]; R_RATELIMIT(0.00)[to_ip_from(RLhco1tq9et14njsu3qecxcejq)]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.com:url] X-Spam-Flag: NO X-Spam-Score: -3.01 X-Rspamd-Queue-Id: C64215BCC3 X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spam-Level: Am 22.01.26 um 08:37 schrieb Icenowy Zheng: > 在 2026-01-22星期四的 08:31 +0100，Thomas Zimmermann写道： >> Hi >> >> Am 22.01.26 um 08:06 schrieb Icenowy Zheng: >>> 在 2026-01-21星期三的 13:56 +0100，Thomas Zimmermann写道： >>> >>> =============== 8< ================= >>>>> + >>>>> +       if (irqs) >>>>> +               pr_warn("Unknown Verisilicon DC interrupt 0x%x >>>>> fired!\n", irqs); >>>> I'd avoid pr_warn() here. This can fill your logs quickly. >>> Then is pr_warn_once() okay? >> Yeah, warn_once should be fine. >> >>>>> + >>>>> +       return IRQ_HANDLED; >>>>> +} >>> =============== 8< ================= >> Maybe consider returning IRQ_NONE if the (irq) tests succeeds. > Well, the IRQs are read from the device's register, and the read > operation automatically ACKs the IRQ, so it sounds more appropriate to > always return IRQ_HANDLED. That makes sense. > > (Well maybe this function should be made return void, and returning > IRQ_HANDLED should be done in the caller of this function, > vs_dc_irq_handler() ) > > Thanks, > Icenowy -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)