From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>,
Dzmitry Sankouski <dsankouski@gmail.com>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sagit: add initial device tree for sagit
Date: Sun, 19 Jun 2022 13:07:05 +0200 [thread overview]
Message-ID: <9a79e689-4290-fd49-6e18-22b306d36bff@linaro.org> (raw)
In-Reply-To: <18956e06-8f9d-fcf0-0e2b-41702ea9b95b@somainline.org>
On 19/06/2022 01:49, Konrad Dybcio wrote:
>> +&ufshc {
>> + status = "okay";
>> +
>> + vcc-supply = <&vreg_l20a_2p95>;
>> + vccq-supply = <&vreg_l26a_1p2>;
>> + vccq2-supply = <&vreg_s4a_1p8>;
>> + vcc-max-microamp = <750000>;
>> + vccq-max-microamp = <560000>;
>> + vccq2-max-microamp = <750000>;
>> +};
>> +
>> +&ufsphy {
>> + status = "okay";
>> +
>> + vdda-phy-supply = <&vreg_l1a_0p875>;
>> + vdda-pll-supply = <&vreg_l2a_1p2>;
>> + vddp-ref-clk-supply = <&vreg_l26a_1p2>;
>> + vdda-phy-max-microamp = <51400>;
>> + vdda-pll-max-microamp = <14600>;
>> + vddp-ref-clk-max-microamp = <100>;
>> + vddp-ref-clk-always-on;
> Please drop properties that are not supported on mainline.
Which brings the other point - please run `make dtbs_check` (you might
get a lot of output) and be sure there are no errors from your boards
comparing to other similar DTS.
The easiest is to:
1. make dtbs_check, go for coffee
2. touch your boards (from both of your commits) and few others
3. run again make dtbs_check and compare
Best regards,
Krzysztof
prev parent reply other threads:[~2022-06-19 11:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 12:20 Dzmitry Sankouski
2022-06-18 1:54 ` Krzysztof Kozlowski
[not found] ` <CABTCjFBb1A9+FT6dcid7Fh-+68eh4u2CMUp+-YiQCGUJRCAgnA@mail.gmail.com>
2022-08-08 6:10 ` Krzysztof Kozlowski
2022-06-18 23:49 ` Konrad Dybcio
2022-06-19 11:07 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a79e689-4290-fd49-6e18-22b306d36bff@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dsankouski@gmail.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®