From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F5E4FA372C for ; Fri, 8 Nov 2019 08:01:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6C3F420869 for ; Fri, 8 Nov 2019 08:01:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729970AbfKHIBn (ORCPT ); Fri, 8 Nov 2019 03:01:43 -0500 Received: from hostingweb31-40.netsons.net ([89.40.174.40]:60009 "EHLO hostingweb31-40.netsons.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725975AbfKHIBn (ORCPT ); Fri, 8 Nov 2019 03:01:43 -0500 Received: from [109.168.11.45] (port=39820 helo=[192.168.101.73]) by hostingweb31.netsons.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1iSzDA-0015oN-C7; Fri, 08 Nov 2019 09:01:40 +0100 Subject: Re: [RFC PATCH 01/12] i2c: replace i2c_new_probed_device with an ERR_PTR variant To: Wolfram Sang Cc: Wolfram Sang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org References: <20191106095033.25182-1-wsa+renesas@sang-engineering.com> <20191106095033.25182-2-wsa+renesas@sang-engineering.com> <20191107192236.GA961@kunai> From: Luca Ceresoli Message-ID: <9a7efd33-8a7e-1e2e-11f8-64c2ab900a4c@lucaceresoli.net> Date: Fri, 8 Nov 2019 09:01:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191107192236.GA961@kunai> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hostingweb31.netsons.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lucaceresoli.net X-Get-Message-Sender-Via: hostingweb31.netsons.net: authenticated_id: luca+lucaceresoli.net/only user confirmed/virtual account not confirmed X-Authenticated-Sender: hostingweb31.netsons.net: luca@lucaceresoli.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wolfram, On 07/11/19 20:22, Wolfram Sang wrote: > Hi Luca, > >> I beg your pardon for the newbie question, perhaps a stupid one, kind of >> nitpicking, and not even strictly related to this patch, but what's the >> reason for these functions being declared extern? > > I did this for consistency reasons. I agree that the 'extern' keyword > could need some second thought, yet I think that should be a seperate > patchset. And that does not have priority for me, so if someone is > interested... :) Ok, got it! And then: Reviewed-by: Luca Ceresoli Bye, -- Luca