From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AD47C433EF for ; Thu, 14 Jul 2022 05:37:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234693AbiGNFhu (ORCPT ); Thu, 14 Jul 2022 01:37:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233559AbiGNFhs (ORCPT ); Thu, 14 Jul 2022 01:37:48 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCFA222B08; Wed, 13 Jul 2022 22:37:39 -0700 (PDT) X-UUID: a829b66066ab4fe5a0dfb8632003a6d2-20220714 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.8,REQID:35acadad-c735-4ee9-9101-ce7f9dbbaa1c,OB:0,LO B:10,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:51,FILE:0,RULE:Release_Ham,AC TION:release,TS:51 X-CID-INFO: VERSION:1.1.8,REQID:35acadad-c735-4ee9-9101-ce7f9dbbaa1c,OB:0,LOB: 10,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:51,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:51 X-CID-META: VersionHash:0f94e32,CLOUDID:604575d7-5d6d-4eaf-a635-828a3ee48b7c,C OID:7f55e8085048,Recheck:0,SF:28|17|19|48,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,QS:nil,BEC:nil,COL:0 X-UUID: a829b66066ab4fe5a0dfb8632003a6d2-20220714 Received: from mtkcas11.mediatek.inc [(172.21.101.40)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 2048630554; Thu, 14 Jul 2022 13:37:34 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Thu, 14 Jul 2022 13:37:32 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Thu, 14 Jul 2022 13:37:31 +0800 Message-ID: <9a7fd7770b013c95983e700d2f1e132fbf5429a6.camel@mediatek.com> Subject: Re: [PATCH net v4 3/3] net: stmmac: fix unbalanced ptp clock issue in suspend/resume flow From: Biao Huang To: Jakub Kicinski CC: David Miller , Matthias Brugger , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Eric Dumazet , Paolo Abeni , Maxime Coquelin , AngeloGioacchino Del Regno , , , , , , , "Jisheng Zhang" , Mohammad Athari Bin Ismail Date: Thu, 14 Jul 2022 13:37:31 +0800 In-Reply-To: <20220713203910.74d36732@kernel.org> References: <20220713101002.10970-1-biao.huang@mediatek.com> <20220713101002.10970-4-biao.huang@mediatek.com> <20220713203910.74d36732@kernel.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Jakub, Thanks for your comments~ On Wed, 2022-07-13 at 20:39 -0700, Jakub Kicinski wrote: > On Wed, 13 Jul 2022 18:10:02 +0800 Biao Huang wrote: > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > index 197fac587ad5..c230b8b9aab1 100644 > > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > @@ -839,14 +839,6 @@ int stmmac_init_tstamp_counter(struct > > stmmac_priv *priv, u32 systime_flags) > > if (!(priv->dma_cap.time_stamp || priv->dma_cap.atime_stamp)) > > return -EOPNOTSUPP; > > > > - ret = clk_prepare_enable(priv->plat->clk_ptp_ref); > > - if (ret < 0) { > > - netdev_warn(priv->dev, > > - "failed to enable PTP reference clock: > > %pe\n", > > - ERR_PTR(ret)); > > - return ret; > > - } > > - > > stmmac_config_hw_tstamping(priv, priv->ptpaddr, systime_flags); > > priv->systime_flags = systime_flags; > > > > > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:837:6: warning: > unused variable 'ret' [-Wunused-variable] > int ret; > ^ OK, I'll fix it in next send. Best Regards! Biao