From: Jesper Juhl <jesper.juhl@gmail.com>
To: Denis Vlasenko <vda@ilport.com.ua>
Cc: linux-kernel@vger.kernel.org,
Arjan van de Ven <arjan@infradead.org>,
Andrew Morton <akpm@osdl.org>,
Russell King <rmk+lkml@arm.linux.org.uk>,
Vojtech Pavlik <vojtech@suse.cz>
Subject: Re: [PATCH] all-arch delay functions take 2
Date: Sun, 3 Jul 2005 16:14:07 +0200 [thread overview]
Message-ID: <9a8748490507030714d2a1b45@mail.gmail.com> (raw)
In-Reply-To: <200507031650.13770.vda@ilport.com.ua>
On 7/3/05, Denis Vlasenko <vda@ilport.com.ua> wrote:
> Hi folks,
>
> This patch makes mdelay/udelay/ndelay calls as small
> as possible (just a function call), uses macros which
> do compile-time checks on delay duration if parameter
> is a constant, otherwise check is done at run time
> to prevent udelay(-1) disasters.
>
[snip]
>
> -#define ndelay(n) udelay((n) * 5)
> +//BOGUS! #define ndelay(n) udelay((n) * 5)
>
If it's bogus, why not just remove it instead of leaving it in as a
comment (and a C++ style comment at that) ?
[snip]
> +//extern struct timer_opts* timer;
Why add this at all if you are just going to comment it out anyway?
--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
next prev parent reply other threads:[~2005-07-03 14:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-03 13:50 Denis Vlasenko
2005-07-03 14:14 ` Jesper Juhl [this message]
2005-07-03 14:27 ` Denis Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a8748490507030714d2a1b45@mail.gmail.com \
--to=jesper.juhl@gmail.com \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=vda@ilport.com.ua \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®