From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751204AbVJDJ2w (ORCPT ); Tue, 4 Oct 2005 05:28:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751205AbVJDJ2w (ORCPT ); Tue, 4 Oct 2005 05:28:52 -0400 Received: from qproxy.gmail.com ([72.14.204.205]:52626 "EHLO qproxy.gmail.com") by vger.kernel.org with ESMTP id S1751204AbVJDJ2u convert rfc822-to-8bit (ORCPT ); Tue, 4 Oct 2005 05:28:50 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=uT0Uapd4kdXq/euGlX48/Y+B9nXsPMzOGHl4e+/7ZOYUkGqbtuy/bmiS5bNVNrozxsJNRnbuwqYTIm9Sg0Va7FkZldtpxRgvS990FSACQpTMJMDpO1MCLJJgLpO1vk7ZXEAvmlrslZ79hYrY/B8knPYhKvJZlyfURVIMVBdWpds= Message-ID: <9a8748490510040228l13ecce46le8c2a5bec0530fcd@mail.gmail.com> Date: Tue, 4 Oct 2005 11:28:49 +0200 From: Jesper Juhl Reply-To: Jesper Juhl To: Jens Axboe Subject: Re: [PATCH] ide-cd cleanup (casts, whitespace and codingstyle) Cc: Alexey Dobriyan , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, andersen@codepoet.org In-Reply-To: <20051004062146.GD3511@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Content-Disposition: inline References: <200510040017.57168.jesper.juhl@gmail.com> <20051003230421.GE7554@mipter.zuzino.mipt.ru> <9a8748490510031557q26f41f78s84ad936d9e78756c@mail.gmail.com> <20051004062146.GD3511@suse.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On 10/4/05, Jens Axboe wrote: > On Tue, Oct 04 2005, Jesper Juhl wrote: > > On 10/4/05, Alexey Dobriyan wrote: > > > On Tue, Oct 04, 2005 at 12:17:56AM +0200, Jesper Juhl wrote: > > > > --- linux-2.6.14-rc3-git3-orig/drivers/ide/ide-cd.c > > > > +++ linux-2.6.14-rc3-git3/drivers/ide/ide-cd.c > > > > > > What was wrong with these ones? [snipping the rest] > > > > > > > Nothing much, simply that as far as I know, the common coding style is > > that function declarations/definitions should be on one line and if > > that line can't fit in 80 chars then arguments are moved to the next > > line and indented by two tabs. That's the style I believe is the most > > official one (if such a thing exists), so that's the style I changed > > everything throughout the file to obey. > > That is by no means the common style. What I usually do is indent the > arguments so the match up with the first line. > > > > > static int cdrom_log_sense(ide_drive_t *drive, struct request *rq, > > > > - struct request_sense *sense) > > > > + struct request_sense *sense) > > This is a mess. So NACK on this patch. And why are you changing the > driver version for non-functional changes? > > And I prefer a space after a cast. And regardless of what others may > think, I do indent cases in a switch unless it's tight for space. > Ok, fair enough. Thank you for the feedback. -- Jesper Juhl Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html