From: Jesper Juhl <jesper.juhl@gmail.com>
To: "Alexander V. Inyukhin" <shurick@sectorb.msk.ru>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [BUG] 2.6.15-rc1, soft lockup detected while probing IDE devices on AMD7441
Date: Wed, 30 Nov 2005 13:00:03 +0100 [thread overview]
Message-ID: <9a8748490511300400q4cf2d6bes511b3b6bf4671d63@mail.gmail.com> (raw)
In-Reply-To: <20051130105952.GA14641@shurick.s2s.msu.ru>
On 11/30/05, Alexander V. Inyukhin <shurick@sectorb.msk.ru> wrote:
> On Wed, Nov 23, 2005 at 08:17:51PM +0100, Jesper Juhl wrote:
> > On Monday 21 November 2005 21:38, Alan Cox wrote:
> > > On Sul, 2005-11-20 at 17:29 -0800, Andrew Morton wrote:
> > > > Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> > > > > Quite normal. The old IDE probe code takes a long time and it makes the
> > > > > soft lockup code believe a lockup occurred - rememeber its a debugging
> > > > > tool not a 100% reliable detector of failures.
> > > >
> > > > We could put a touch_softlockup_watchdog() in there.
> > >
> > > Would make sense. Spin up and probe can take over 30 seconds worst case
> > > and is polled in the IDE world. The loop will eventually exit and a true
> > > lockup caused by a stuck IORDY line will hang forever in an inb/outb so
> > > neither softlockup or even nmi lockup would save you.
> >
> > How about something like the patch below?
> >
> > The if (!(timeout % 128)) bit is a guess that since
> > touch_softlockup_watchdog() is a per_cpu thing it will be cheaper to do the
> > modulo calculation than calling the function every time through the loop,
> > especially as the nr of CPU's go up. But it's purely a guess, so I may very
> > well be wrong - also, 128 is an arbitrarily chosen value, it's just a nice
> > number that'll give us <10 function calls pr second.
>
> It seems to work.
> I have no BUG messages during boot with this patch.
>
Great.
Thank you for testing.
--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
prev parent reply other threads:[~2005-11-30 12:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-20 20:46 Alexander V. Inyukhin
2005-11-20 23:07 ` Alan Cox
2005-11-21 1:29 ` Andrew Morton
2005-11-21 20:38 ` Alan Cox
2005-11-23 19:17 ` Jesper Juhl
2005-11-30 10:59 ` Alexander V. Inyukhin
2005-11-30 12:00 ` Jesper Juhl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a8748490511300400q4cf2d6bes511b3b6bf4671d63@mail.gmail.com \
--to=jesper.juhl@gmail.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=shurick@sectorb.msk.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®