From: Jesper Juhl <jesper.juhl@gmail.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: al@alarsen.net, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] fs/qnx4/bitmap.c: #if 0 qnx4_new_block()
Date: Sat, 3 Dec 2005 13:28:31 +0100 [thread overview]
Message-ID: <9a8748490512030428o55d9c8cfl112fadf8e8b7e02c@mail.gmail.com> (raw)
In-Reply-To: <20051203121944.GC31395@stusta.de>
On 12/3/05, Adrian Bunk <bunk@stusta.de> wrote:
> qnx4_new_block() is neither implemented nor used.
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.15-rc3-mm1/fs/qnx4/bitmap.c.old 2005-12-03 11:32:46.000000000 +0100
> +++ linux-2.6.15-rc3-mm1/fs/qnx4/bitmap.c 2005-12-03 11:33:07.000000000 +0100
> @@ -23,10 +23,12 @@
> #include <linux/buffer_head.h>
> #include <linux/bitops.h>
>
> +#if 0
> int qnx4_new_block(struct super_block *sb)
> {
> return 0;
> }
> +#endif /* 0 */
>
> static void count_bits(register const char *bmPart, register int size,
> int *const tf)
>
Adrian,
You submit a lot of nice patches, but your "#if 0" patches have always
puzzled me. Why is it that you prefer to use #if 0 to remove code
rather than simply delete it?
--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
next prev parent reply other threads:[~2005-12-03 12:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-03 12:19 Adrian Bunk
2005-12-03 12:28 ` Jesper Juhl [this message]
2005-12-03 12:46 ` Adrian Bunk
2005-12-03 19:49 Anders Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a8748490512030428o55d9c8cfl112fadf8e8b7e02c@mail.gmail.com \
--to=jesper.juhl@gmail.com \
--cc=al@alarsen.net \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®