From: Jesper Juhl <jesper.juhl@gmail.com>
To: Lee Revell <rlrevell@joe-job.com>
Cc: Andrew Morton <akpm@osdl.org>, Al Viro <viro@ftp.linux.org.uk>,
linux-kernel@vger.kernel.org,
Hirokazu Takata <takata@linux-m32r.org>
Subject: Re: [WTF?] sys_tas() on m32r
Date: Tue, 27 Dec 2005 10:34:17 +0100 [thread overview]
Message-ID: <9a8748490512270134i5e8efc59s795aff748e6a1f1a@mail.gmail.com> (raw)
In-Reply-To: <1135365035.22177.17.camel@mindpipe>
On 12/23/05, Lee Revell <rlrevell@joe-job.com> wrote:
> On Fri, 2005-12-23 at 05:55 -0800, Andrew Morton wrote:
> > Al Viro <viro@ftp.linux.org.uk> wrote:
> > >
> > > asmlinkage int sys_tas(int *addr)
> > > {
> > > int oldval;
> > > unsigned long flags;
> > >
> > > if (!access_ok(VERIFY_WRITE, addr, sizeof (int)))
> > > return -EFAULT;
> > > local_irq_save(flags);
> > > oldval = *addr;
> > > if (!oldval)
> > > *addr = 1;
> > > local_irq_restore(flags);
> > > return oldval;
> > > }
> > > in arch/m32r/kernel/sys_m32r.c. Trivial oops *AND* ability to trigger
> > > IO with interrupts disabled.
> >
> > Yeah. I pointed this out to Takata in October last year and then promptly
> > forgot about it. It's rather amazing that this code (which appears to be in
> > live use in linuxthreads) hasn't generated oopses.
>
> No one uses LinuxThreads anymore?
>
Slackware still uses LinuxThreads.
Latest release and -current include both NPTL & LinuxThreads, and use
NPTL if the running kernel is >2.6.4 or LinuxThreads if <=2.6.4 or
when running a 2.4 kernel (2.4 is still the default kernel in
Slackware although 2.6.x is also fully supported).
--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
next prev parent reply other threads:[~2005-12-27 9:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-23 6:15 Al Viro
2005-12-23 7:50 ` liyu
2005-12-23 7:54 ` Al Viro
2005-12-23 13:55 ` Andrew Morton
2005-12-23 19:10 ` Lee Revell
2005-12-27 6:36 ` Hirokazu Takata
2005-12-27 9:34 ` Jesper Juhl [this message]
2005-12-27 5:27 ` Hirokazu Takata
2005-12-27 13:22 ` Andrew Morton
2005-12-28 0:36 ` Hirokazu Takata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a8748490512270134i5e8efc59s795aff748e6a1f1a@mail.gmail.com \
--to=jesper.juhl@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rlrevell@joe-job.com \
--cc=takata@linux-m32r.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®