From: Jesper Juhl <jesper.juhl@gmail.com>
To: Luiz Fernando Capitulino <lcapitulino@mandriva.com.br>
Cc: Jens Axboe <axboe@suse.de>,
khushil.dep@help.basilica.co.uk, viro@ftp.linux.org.uk,
akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bio: gcc warning fix.
Date: Fri, 6 Jan 2006 20:05:00 +0100 [thread overview]
Message-ID: <9a8748490601061105s865d659ycfab118c21eb371c@mail.gmail.com> (raw)
In-Reply-To: <20060106165844.399a1d07.lcapitulino@mandriva.com.br>
On 1/6/06, Luiz Fernando Capitulino <lcapitulino@mandriva.com.br> wrote:
>
> On Fri, 6 Jan 2006 19:48:11 +0100
> Jens Axboe <axboe@suse.de> wrote:
>
> | > having assigned a value we know that gcc's warning is wrong, idx can
> | > never *actually* be used uninitialized.
> |
> | Indeed, that's the whole point. For the original submitter, you are not
> | the first to submit this. See archives for basically the same thread as
> | this one...
>
> Al Viro got it: I just wanted to make gcc not complain. But
> 'obfuscate correct code' for it is wrong.
>
> The code is right, the patch is bad. That's it.
>
Yeah, but thanks for trying.
You may have been wrong in this case (and learned to verify your
patches more thoroughly), but the effort to try and review and help
improve the kernel is apreciated.
--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
next prev parent reply other threads:[~2006-01-06 19:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-06 15:48 Khushil Dep
2006-01-06 18:41 ` Jesper Juhl
2006-01-06 18:48 ` Jens Axboe
2006-01-06 18:53 ` Jesper Juhl
2006-01-06 18:58 ` Luiz Fernando Capitulino
2006-01-06 19:04 ` Jens Axboe
2006-01-06 19:05 ` Jesper Juhl [this message]
2006-01-06 19:33 ` Zan Lynx
2006-01-06 19:56 ` Al Viro
2006-01-07 12:22 ` Peter Osterlund
-- strict thread matches above, loose matches on Subject: below --
2006-01-06 15:07 Luiz Fernando Capitulino
2006-01-06 15:28 ` Jens Axboe
2006-01-06 15:39 ` Al Viro
2006-01-06 22:43 ` Daniel Barkalow
2006-01-06 22:52 ` Jesper Juhl
2006-01-06 23:13 ` Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a8748490601061105s865d659ycfab118c21eb371c@mail.gmail.com \
--to=jesper.juhl@gmail.com \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=khushil.dep@help.basilica.co.uk \
--cc=lcapitulino@mandriva.com.br \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®