Re: [PATCH -mm] updated idetape gcc 4.1 warning fix

["Jesper Juhl" <jesper.juhl@gmail.com>]

On 5/10/06, Daniel Walker <dwalker@mvista.com> wrote:
> I added returns for failures .. I would hope that this doesn't break anything in
> userspace , but I'll confess that I have no way to determin that for certain .
>
> Hows that Alan?
>
> Fixes the following warning,
>
> drivers/ide/ide-tape.c: In function 'idetape_copy_stage_from_user':
> drivers/ide/ide-tape.c:2662: warning: ignoring return value of 'copy_from_user', declared with attribute warn_unused_result
> drivers/ide/ide-tape.c: In function 'idetape_copy_stage_to_user':
> drivers/ide/ide-tape.c:2689: warning: ignoring return value of 'copy_to_user', declared with attribute warn_unused_result
>

I've been down the road of trying to fix that code as well a while back.
Although my patches had flaws and didn't go in, perhaps your current
attempt could bennefit by looking at what I tried to do back then and
the feedback I recieved, so I thought I'd point them out to you.

Take a look at the two threads named "[PATCH] ide-tape: attempt to
handle copy_*_user() failures" and "[PATCH] ide-tape: attempt to
handle copy_*_user() failures [take two]"

Here's a link to them in the archives :
http://marc.theaimsgroup.com/?t=113796611500003&r=1&w=2


-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html