From: "Jesper Juhl" <jesper.juhl@gmail.com>
To: "Alan Cox" <alan@redhat.com>
Cc: linux-kernel@vger.kernel.org,
"Moxa Technologies" <support@moxa.com.tw>,
"Martin Mares" <mj@ucw.cz>
Subject: Re: [PATCH] fix dangerous pointer derefs and remove pointless casts in MOXA driver
Date: Mon, 15 May 2006 11:53:55 +0200 [thread overview]
Message-ID: <9a8748490605150253w4448ea8q1a4f587ef66ea680@mail.gmail.com> (raw)
In-Reply-To: <20060515093457.GA9780@devserv.devel.redhat.com>
On 15/05/06, Alan Cox <alan@redhat.com> wrote:
> On Sun, May 14, 2006 at 03:49:35AM +0200, Jesper Juhl wrote:
> > If mxser_write() gets called with a NULL 'tty' pointer, then the initial
> > assignment of tty->driver_data to info will explode.
>
> If mxser_write gets called with a NULL pointer then you've already got such
> serious problems it isn't worth checking
>
> > Please consider for inclusion.
>
> Just delete the checks. Also the little cast cleanup looks good so submit
> that as a separate patch too.
>
Thank you for the feedback.
I'll do that in two sepperate patches later this evening.
--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
prev parent reply other threads:[~2006-05-15 9:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-14 1:49 Jesper Juhl
2006-05-14 14:18 ` Alexey Dobriyan
2006-05-15 9:53 ` Jesper Juhl
2006-05-15 12:35 ` Jörn Engel
2006-05-15 13:04 ` Jesper Juhl
2006-05-15 9:34 ` Alan Cox
2006-05-15 9:53 ` Jesper Juhl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a8748490605150253w4448ea8q1a4f587ef66ea680@mail.gmail.com \
--to=jesper.juhl@gmail.com \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mj@ucw.cz \
--cc=support@moxa.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®