Re: [RFC][PATCH 0/9] -Wshadow: Making the kernel build clean with -Wshadow

["Jesper Juhl" <jesper.juhl@gmail.com>]

On 10/07/06, Arjan van de Ven <arjan@infradead.org> wrote:
> On Mon, 2006-07-10 at 09:03 -0400, Dmitry Torokhov wrote:
> >
> > While we may not have any issues with the present code it can help
> > avoiding problems in new code if we have -Wshadow by default.
>
> I agree with that; however that still depends on the ratio of real bugs
> vs "noise". While it's hard to estimate for future code, the existing
> code base can be an indication...
>
One little twist here is that if I end up going through all the
current warnings to clean them up then once I know that ratio I'll
have already done all the cleanup work, so whatever the bugs/noise
ratio turns out to be, all the work will already be done and then
(from my point of view) we might as well do it ;-)

More seriously; I'll try and sift through the pile I have at the
moment and pick out those that look like real bugs, then we can look
at that and see if it's worth-while...
In any case, even if there are only very few real bugs (or even none)
I'm still full willing to do the work to help us protect against
future bugs.


-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html