mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jesper Juhl" <jesper.juhl@gmail.com>
To: "Jesper Juhl" <jesper.juhl@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 2/9] -Wshadow: Fix warnings in mconf
Date: Tue, 11 Jul 2006 00:16:40 +0200	[thread overview]
Message-ID: <9a8748490607101516x3c13a712h714a1a8bc4d1eeb7@mail.gmail.com> (raw)
In-Reply-To: <20060710155337.GB9617@admingilde.org>

On 10/07/06, Martin Waitz <tali@admingilde.org> wrote:
> hoi :)
>
> On Mon, Jul 10, 2006 at 01:12:37PM +0200, Jesper Juhl wrote:
> > --- linux-2.6.18-rc1-orig/scripts/kconfig/mconf.c     2006-06-18 03:49:35.000000000 +0200
> > +++ linux-2.6.18-rc1/scripts/kconfig/mconf.c  2006-07-09 19:48:05.000000000 +0200
> > @@ -276,7 +276,7 @@ static void conf_save(void);
> >  static void show_textbox(const char *title, const char *text, int r, int c);
> >  static void show_helptext(const char *title, const char *text);
> >  static void show_help(struct menu *menu);
> > -static void show_file(const char *filename, const char *title, int r, int c);
> > +static void show_file(const char *fname, const char *title, int r, int c);
> >
> >  static void cprint_init(void);
> >  static int cprint1(const char *fmt, ...);
>
> perhaps its more clear if you change the global variable instead?
> perhaps to config_filename?
>

Not a bad suggestion. Thanks.

-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html

      parent reply	other threads:[~2006-07-10 22:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-10 11:12 Jesper Juhl
2006-07-10 15:53 ` Martin Waitz
2006-07-10 16:18   ` Jan-Benedict Glaw
2006-07-10 22:16   ` Jesper Juhl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a8748490607101516x3c13a712h714a1a8bc4d1eeb7@mail.gmail.com \
    --to=jesper.juhl@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®