From: "Jesper Juhl" <jesper.juhl@gmail.com>
To: "Neil Brown" <neilb@suse.de>
Cc: linux-kernel@vger.kernel.org,
"Trond Myklebust" <trond.myklebust@fys.uio.no>,
nfs@lists.sourceforge.net
Subject: Re: Let's get rid of those annoying "VFS is out of sync with lock manager" messages (includes proposed patch)
Date: Fri, 8 Dec 2006 15:48:24 +0100 [thread overview]
Message-ID: <9a8748490612080648l427000a7ue613d8b124cc628e@mail.gmail.com> (raw)
In-Reply-To: <9a8748490612080635o3432d410gbb147c977de21499@mail.gmail.com>
On 08/12/06, Jesper Juhl <jesper.juhl@gmail.com> wrote:
> On 08/12/06, Neil Brown <neilb@suse.de> wrote:
> > On Thursday December 7, jesper.juhl@gmail.com wrote:
> > >
> > > So I took Neils patch, made the change Trond suggested and the result is
> > > below.
> > >
> > > Comments? Ok to merge?
> >
> > Yes, except that you need a changelog comment at the top. Possibly
> > based very heavily on the text I wrote, but written to justify the
> > patch rather than to explain the bug.
> >
> > NeilBrown
> >
>
> How about this for a changelog entry? :
>
> Convert "VFS is out of sync with lock manager!" printk in
> do_vfs_lock() to dprintk() since the message is useless in normal use
> but could possibly be useful as a debugging aid.
> Also turn off FL_SLEEP when calling do_vfs_lock() just in case after
> getting -EINTR or -ERESTARTSYS.
>
>
Ohh and btw, I forgot to mention that the patch has been tested and
resolves my original issue.
--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
prev parent reply other threads:[~2006-12-08 14:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-07 21:08 Jesper Juhl
2006-12-08 3:36 ` Neil Brown
2006-12-08 14:35 ` Jesper Juhl
2006-12-08 14:48 ` Jesper Juhl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a8748490612080648l427000a7ue613d8b124cc628e@mail.gmail.com \
--to=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=nfs@lists.sourceforge.net \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®