From: "Jesper Juhl" <jesper.juhl@gmail.com>
To: "Alan Cox" <alan@lxorguk.ukuu.org.uk>
Cc: "Andi Drebes" <lists-receive@programmierforen.de>,
postfail@hushmail.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: Ideas on column length in kernel "problem"?
Date: Fri, 24 Aug 2007 13:07:54 +0200 [thread overview]
Message-ID: <9a8748490708240407pf1fa935j2dae3b0c108b3231@mail.gmail.com> (raw)
In-Reply-To: <20070824114611.7b17cafd@the-village.bc.nu>
[-- Attachment #1: Type: text/plain, Size: 1528 bytes --]
On 24/08/07, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> > I think this is also a matter of conding style. Documentation/CodingStyle
> > says:
> >
> > "The limit on the length of lines is 80 columns and this is a hard limit."
>
> As has repeatedly been stated this is a bug in Documentation/CodingStyle
> and bears no resemblence to reality.
>
So let's update CodingStyle once and for all so that doesn't pop up
again. See attached patch (inline version is whitespace damaged -
can't help it from my current location).
As continuously gets pointed out, the 80 col line length defined in CodingStyle
is not a hard limit in real life. Let the document reflect reality.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
--- Documentation/CodingStyle~ 2007-08-24 13:04:20.000000000 +0200
+++ Documentation/CodingStyle 2007-08-24 13:04:20.000000000 +0200
@@ -77,7 +77,8 @@
Coding style is all about readability and maintainability using commonly
available tools.
-The limit on the length of lines is 80 columns and this is a hard limit.
+The limit on the length of lines is 80 columns. This is a soft limit, it can
+be broken in some cases, but you should respect it whenever possible.
Statements longer than 80 columns will be broken into sensible chunks.
Descendants are always substantially shorter than the parent and are placed
--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
[-- Attachment #2: line-length.patch --]
[-- Type: application/octet-stream, Size: 825 bytes --]
As continuously gets pointed out, the 80 col line length defined in CodingStyle
is not a hard limit in real life. Let the document reflect reality.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
--- Documentation/CodingStyle~ 2007-08-24 13:04:20.000000000 +0200
+++ Documentation/CodingStyle 2007-08-24 13:04:20.000000000 +0200
@@ -77,7 +77,8 @@
Coding style is all about readability and maintainability using commonly
available tools.
-The limit on the length of lines is 80 columns and this is a hard limit.
+The limit on the length of lines is 80 columns. This is a soft limit, it can
+be broken in some cases, but you should respect it whenever possible.
Statements longer than 80 columns will be broken into sensible chunks.
Descendants are always substantially shorter than the parent and are placed
next prev parent reply other threads:[~2007-08-24 11:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-23 3:54 Scott Thompson
2007-08-23 4:05 ` Adrian Bunk
2007-08-24 8:17 ` Suresh Jayaraman
2007-08-23 7:36 ` Paolo Ornati
2007-08-23 11:56 ` walter harms
2007-08-23 12:00 ` Paolo Ornati
2007-08-23 12:27 ` Jesper Juhl
2007-08-24 1:43 ` Bron Gondwana
2007-08-24 10:31 ` Andi Drebes
2007-08-24 10:46 ` Alan Cox
2007-08-24 11:07 ` Jesper Juhl [this message]
2007-08-24 16:31 Scott Thompson
2007-08-24 16:51 ` Randy Dunlap
2007-08-24 19:09 Scott Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a8748490708240407pf1fa935j2dae3b0c108b3231@mail.gmail.com \
--to=jesper.juhl@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lists-receive@programmierforen.de \
--cc=postfail@hushmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®