Re: [PATCH] Fix errors detected by checkpatch.pl on nmi_int.c

["Jesper Juhl" <jesper.juhl@gmail.com>]

On 02/01/2008, Carlos R. Mafra <crmafra@gmail.com> wrote:
> This patch fixes most errors detected by checkpatch.pl.
>
>                                      errors   lines of code   errors/KLOC
> arch/x86/oprofile/nmi_int.c (after)       1             461           2.1
> arch/x86/oprofile/nmi_int.c (before)     60             477         125.7
>
> No code changed.
>
> size:
>    text    data     bss     dec     hex filename
>    2675     264     472    3411     d53 nmi_int.o.after
>    2675     264     472    3411     d53 nmi_int.o.before
>
> md5sum:
>   847aea0cc68fe1a2b5e7019439f3b4dd  nmi_int.o.after
>   847aea0cc68fe1a2b5e7019439f3b4dd  nmi_int.o.before
>
> Signed-off-by: Carlos R. Mafra <crmafra@gmail.com>
>

Looks good to me (except that an inline patch instead of an attached
one would have been nice ;-)

Kills some trailing whitespace, does some CodingStyle cleanups, is
nicely confined to one file, doesn't (as far as I can tell) change the
way the code works, makes checkpatch less noisy. All good.

Feel free to add
  Reviewed-by: Jesper Juhl <jesper.juhl@gmail.com>
if you like.


-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html