From: "Jesper Juhl" <jesper.juhl@gmail.com>
To: "Andi Kleen" <andi@firstfloor.org>
Cc: "Shaohua Li" <shaohua.li@intel.com>,
"Jesse Barnes" <jbarnes@virtuousgeek.org>,
linux-kernel@vger.kernel.org, "Ingo Molnar" <mingo@redhat.com>
Subject: Re: [PATCH] PCI Express ASPM support should default to 'No'
Date: Sun, 27 Apr 2008 22:01:45 +0200 [thread overview]
Message-ID: <9a8748490804271301j5d7c0147x995c5353f9926598@mail.gmail.com> (raw)
In-Reply-To: <87abjjzo84.fsf@basil.nowhere.org>
2008/4/24 Andi Kleen <andi@firstfloor.org>:
>
> Shaohua Li <shaohua.li@intel.com> writes:
>
> > On Tue, 2008-04-22 at 17:12 -0700, Jesse Barnes wrote:
> >> On Tuesday, April 22, 2008 3:28 pm Jesper Juhl wrote:
> >> > Running 'make oldconfig' I just noticed that PCIEASPM defaults to
> >> > 'y' in Kconfig even though the feature is both experimental and the
> >> > help text recommends that if you are unsure you say 'n'.
> >> > It seems to me that this really should default to 'n', not 'y' at the
> >> > moment.
> >> > The following patch makes that change. Please consider applying.
> >>
> >> Seem reasonable, Shaohua? Please cc linux-pci on PCI patches
> >> though...
> > Ok, I'm fine with the patch. Though by default, the policy is to use
> > BIOS setting, that is if BIOS disables ASPM, we don't enable it too.
>
> Once the feature is considered stable it would be nice to make it default y
> again. I think any power saving should be on by default (unless serious
> issues are known), not off.
>
I agree, but as long as it's marked EXPERIMENTAL and there's even a
warning in the help text telling users to select 'n' if they are
unsure I think it makes sense to make 'n' the default.
Once it's been tested some more, is no longer experimental, then we
can change it back to 'y' easily.
--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
prev parent reply other threads:[~2008-04-27 20:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-22 22:28 Jesper Juhl
2008-04-23 0:12 ` Jesse Barnes
2008-04-23 1:05 ` Shaohua Li
2008-04-23 22:46 ` Jesse Barnes
2008-04-24 7:49 ` Andi Kleen
2008-04-24 8:02 ` Shaohua Li
2008-04-24 15:33 ` Jesse Barnes
2008-04-25 1:16 ` Shaohua Li
2008-04-27 20:01 ` Jesper Juhl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a8748490804271301j5d7c0147x995c5353f9926598@mail.gmail.com \
--to=jesper.juhl@gmail.com \
--cc=andi@firstfloor.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®