mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jesper Juhl" <jesper.juhl@gmail.com>
To: "James Bottomley" <James.Bottomley@hansenpartnership.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Eric Youngdale" <eric@andante.org>,
	"David Miller" <davem@davemloft.net>,
	"Mike Anderson" <andmike@us.ibm.com>,
	"Russell King" <rmk@arm.linux.org.uk>,
	"Jesper Juhl" <jesper.juhl@gmail.com>,
	"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH][Resend] fewer pointer derefs in scsi_error
Date: Mon, 12 May 2008 22:32:39 +0200	[thread overview]
Message-ID: <9a8748490805121332j58090a75x470e97b07010dcee@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.1.00.0804272211080.2352@dragon.funnycrock.com>

2008/4/27 Jesper Juhl <jesper.juhl@gmail.com>:
> From: Jesper Juhl <jesper.juhl@gmail.com>
>
>  [This patch previously submitted on  24 April 2008 00:18]
>

Hmmm, no feedback at all on this one. Could someone please ACK or NACK it?
I've more stuff like this in the pipeline, but I'm holding it back
until I see if this one takes root or not ;)

/Jesper

>
>  This patch reduces the number of sequential pointer derefs in scsi_error
>  ( drivers/scsi/scsi_error.c ).
>
>  The bennefits are:
>         - makes the code easier to read. Lots of sequential derefs of the
>           same pointers are not easy on the eye.
>         - makes the size of the source file 55 bytes smaller.
>         - makes the size of the object file 48 bytes smaller.
>         - theoretically at least, just dereferencing the pointers once can
>           allow the compiler to generally slightly faster code, so in
>           theory this could also be a micro speed optimization.
>
>  Please consider applying.
>
>
>  Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
>  ---
>
>   scsi_error.c |   58 ++++++++++++++++++++++++++++++++--------------------------
>   1 file changed, 32 insertions(+), 26 deletions(-)
>
>  diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
>  index 221f31e..94395a7 100644
>  --- a/drivers/scsi/scsi_error.c
>  +++ b/drivers/scsi/scsi_error.c
>  @@ -185,13 +185,14 @@ int scsi_delete_timer(struct scsi_cmnd *scmd)
>   void scsi_times_out(struct scsi_cmnd *scmd)
>   {
>         enum scsi_eh_timer_return (* eh_timed_out)(struct scsi_cmnd *);
>  +       struct Scsi_Host *host = scmd->device->host;
>
>         scsi_log_completion(scmd, TIMEOUT_ERROR);
>
>  -       if (scmd->device->host->transportt->eh_timed_out)
>  -               eh_timed_out = scmd->device->host->transportt->eh_timed_out;
>  -       else if (scmd->device->host->hostt->eh_timed_out)
>  -               eh_timed_out = scmd->device->host->hostt->eh_timed_out;
>  +       if (host->transportt->eh_timed_out)
>  +               eh_timed_out = host->transportt->eh_timed_out;
>  +       else if (host->hostt->eh_timed_out)
>  +               eh_timed_out = host->hostt->eh_timed_out;
>         else
>                 eh_timed_out = NULL;
>
>  @@ -474,22 +475,22 @@ static int scsi_try_host_reset(struct scsi_cmnd *scmd)
>   {
>         unsigned long flags;
>         int rtn;
>  +       struct Scsi_Host *host = scmd->device->host;
>
>         SCSI_LOG_ERROR_RECOVERY(3, printk("%s: Snd Host RST\n",
>                                           __FUNCTION__));
>
>  -       if (!scmd->device->host->hostt->eh_host_reset_handler)
>  +       if (!host->hostt->eh_host_reset_handler)
>                 return FAILED;
>
>  -       rtn = scmd->device->host->hostt->eh_host_reset_handler(scmd);
>  +       rtn = host->hostt->eh_host_reset_handler(scmd);
>
>         if (rtn == SUCCESS) {
>  -               if (!scmd->device->host->hostt->skip_settle_delay)
>  +               if (!host->hostt->skip_settle_delay)
>                         ssleep(HOST_RESET_SETTLE_TIME);
>  -               spin_lock_irqsave(scmd->device->host->host_lock, flags);
>  -               scsi_report_bus_reset(scmd->device->host,
>  -                                     scmd_channel(scmd));
>  -               spin_unlock_irqrestore(scmd->device->host->host_lock, flags);
>  +               spin_lock_irqsave(host->host_lock, flags);
>  +               scsi_report_bus_reset(host, scmd_channel(scmd));
>  +               spin_unlock_irqrestore(host->host_lock, flags);
>         }
>
>         return rtn;
>  @@ -503,22 +504,22 @@ static int scsi_try_bus_reset(struct scsi_cmnd *scmd)
>   {
>         unsigned long flags;
>         int rtn;
>  +       struct Scsi_Host *host = scmd->device->host;
>
>         SCSI_LOG_ERROR_RECOVERY(3, printk("%s: Snd Bus RST\n",
>                                           __FUNCTION__));
>
>  -       if (!scmd->device->host->hostt->eh_bus_reset_handler)
>  +       if (!host->hostt->eh_bus_reset_handler)
>                 return FAILED;
>
>  -       rtn = scmd->device->host->hostt->eh_bus_reset_handler(scmd);
>  +       rtn = host->hostt->eh_bus_reset_handler(scmd);
>
>         if (rtn == SUCCESS) {
>  -               if (!scmd->device->host->hostt->skip_settle_delay)
>  +               if (!host->hostt->skip_settle_delay)
>                         ssleep(BUS_RESET_SETTLE_TIME);
>  -               spin_lock_irqsave(scmd->device->host->host_lock, flags);
>  -               scsi_report_bus_reset(scmd->device->host,
>  -                                     scmd_channel(scmd));
>  -               spin_unlock_irqrestore(scmd->device->host->host_lock, flags);
>  +               spin_lock_irqsave(host->host_lock, flags);
>  +               scsi_report_bus_reset(host, scmd_channel(scmd));
>  +               spin_unlock_irqrestore(host->host_lock, flags);
>         }
>
>         return rtn;
>  @@ -544,16 +545,17 @@ static int scsi_try_target_reset(struct scsi_cmnd *scmd)
>   {
>         unsigned long flags;
>         int rtn;
>  +       struct Scsi_Host *host = scmd->device->host;
>
>  -       if (!scmd->device->host->hostt->eh_target_reset_handler)
>  +       if (!host->hostt->eh_target_reset_handler)
>                 return FAILED;
>
>  -       rtn = scmd->device->host->hostt->eh_target_reset_handler(scmd);
>  +       rtn = host->hostt->eh_target_reset_handler(scmd);
>         if (rtn == SUCCESS) {
>  -               spin_lock_irqsave(scmd->device->host->host_lock, flags);
>  +               spin_lock_irqsave(host->host_lock, flags);
>                 __starget_for_each_device(scsi_target(scmd->device), NULL,
>                                           __scsi_report_device_reset);
>  -               spin_unlock_irqrestore(scmd->device->host->host_lock, flags);
>  +               spin_unlock_irqrestore(host->host_lock, flags);
>         }
>
>         return rtn;
>  @@ -572,11 +574,12 @@ static int scsi_try_target_reset(struct scsi_cmnd *scmd)
>   static int scsi_try_bus_device_reset(struct scsi_cmnd *scmd)
>   {
>         int rtn;
>  +       struct Scsi_Host *host = scmd->device->host;
>
>  -       if (!scmd->device->host->hostt->eh_device_reset_handler)
>  +       if (!host->hostt->eh_device_reset_handler)
>                 return FAILED;
>
>  -       rtn = scmd->device->host->hostt->eh_device_reset_handler(scmd);
>  +       rtn = host->hostt->eh_device_reset_handler(scmd);
>         if (rtn == SUCCESS)
>                 __scsi_report_device_reset(scmd->device, NULL);
>         return rtn;
>  @@ -584,10 +587,13 @@ static int scsi_try_bus_device_reset(struct scsi_cmnd *scmd)
>
>   static int __scsi_try_to_abort_cmd(struct scsi_cmnd *scmd)
>   {
>  -       if (!scmd->device->host->hostt->eh_abort_handler)
>  +       int (* eh_abort_handler)(struct scsi_cmnd *)
>  +               = scmd->device->host->hostt->eh_abort_handler;
>  +
>  +       if (!eh_abort_handler)
>                 return FAILED;
>
>  -       return scmd->device->host->hostt->eh_abort_handler(scmd);
>  +       return eh_abort_handler(scmd);
>   }
>
>   /**
>
>


-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html

      reply	other threads:[~2008-05-12 20:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-27 20:15 Jesper Juhl
2008-05-12 20:32 ` Jesper Juhl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a8748490805121332j58090a75x470e97b07010dcee@mail.gmail.com \
    --to=jesper.juhl@gmail.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=andmike@us.ibm.com \
    --cc=davem@davemloft.net \
    --cc=eric@andante.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®