From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751176AbcK0FDh (ORCPT ); Sun, 27 Nov 2016 00:03:37 -0500 Received: from server.coly.li ([162.144.45.48]:57620 "EHLO server.coly.li" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750750AbcK0FDg (ORCPT ); Sun, 27 Nov 2016 00:03:36 -0500 X-Greylist: delayed 3443 seconds by postgrey-1.27 at vger.kernel.org; Sun, 27 Nov 2016 00:03:36 EST Subject: Re: [PATCH] Avoid nested function definition To: Peter Foley , shli@kernel.org, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org References: <20161126222415.13404-1-pefoley2@pefoley.com> From: Coly Li Cc: linux-kernel@vger.kernel.org, kent.overstreet@gmail.com Message-ID: <9a8a84ed-ecf7-b1dd-59e8-1a36dbcef088@coly.li> Date: Sun, 27 Nov 2016 12:06:04 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <20161126222415.13404-1-pefoley2@pefoley.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.coly.li X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - coly.li X-Get-Message-Sender-Via: server.coly.li: authenticated_id: i@coly.li X-Authenticated-Sender: server.coly.li: i@coly.li X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/11/27 上午6:24, Peter Foley wrote: > Fixes below error with clang: > ../drivers/md/bcache/sysfs.c:759:3: error: function definition is not allowed here > { return *((uint16_t *) r) - *((uint16_t *) l); } > ^ > ../drivers/md/bcache/sysfs.c:789:32: error: use of undeclared identifier 'cmp' > sort(p, n, sizeof(uint16_t), cmp, NULL); > ^ > 2 errors generated. > > Signed-off-by: Peter Foley > --- > drivers/md/bcache/sysfs.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c > index b3ff57d61dde..22ac9e6676a0 100644 > --- a/drivers/md/bcache/sysfs.c > +++ b/drivers/md/bcache/sysfs.c > @@ -731,6 +731,11 @@ static struct attribute *bch_cache_set_internal_files[] = { > }; > KTYPE(bch_cache_set_internal); > > +static int cmp(const void *l, const void *r) > +{ > + return *((uint16_t *)r) - *((uint16_t *)l); > +} > + > SHOW(__bch_cache) > { > struct cache *ca = container_of(kobj, struct cache, kobj); > @@ -755,9 +760,6 @@ SHOW(__bch_cache) > CACHE_REPLACEMENT(&ca->sb)); > > if (attr == &sysfs_priority_stats) { > - int cmp(const void *l, const void *r) > - { return *((uint16_t *) r) - *((uint16_t *) l); } > - > struct bucket *b; > size_t n = ca->sb.nbuckets, i; > size_t unused = 0, available = 0, dirty = 0, meta = 0; > I agree with this fix. Anyway, Can we use a more unique name like __bch_cache_cmp() ? Thanks. -- Coly Li