From: Logan Gunthorpe <logang@deltatee.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Kurt Schwemmer <kurt.schwemmer@microsemi.com>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] switchtec: Fix potential Spectre v1
Date: Thu, 16 Aug 2018 15:44:04 -0600 [thread overview]
Message-ID: <9a8fe29a-741e-c7ca-a844-ac6a8104211e@deltatee.com> (raw)
In-Reply-To: <20180816190646.GA9610@embeddedor.com>
On 16/08/18 01:06 PM, Gustavo A. R. Silva wrote:
> p.port can is indirectly controlled by user-space, hence leading to
> a potential exploitation of the Spectre variant 1 vulnerability.
>
> This issue was detected with the help of Smatch:
>
> drivers/pci/switch/switchtec.c:912 ioctl_port_to_pff() warn: potential
> spectre issue 'pcfg->dsp_pff_inst_id' [r]
>
> Fix this by sanitizing p.port before using it to index
> pcfg->dsp_pff_inst_id
>
> Notice that given that speculation windows are large, the policy is
> to kill the speculation on the first load and not worry if it can be
> completed with a dependent load/store [1].
>
> [1] https://marc.info/?l=linux-kernel&m=152449131114778&w=2
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Logan Gunthorpe <logang@deltatee.com>
Looks good to me, thanks.
Logan
next prev parent reply other threads:[~2018-08-16 21:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 19:06 Gustavo A. R. Silva
2018-08-16 21:44 ` Logan Gunthorpe [this message]
2018-09-05 21:29 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a8fe29a-741e-c7ca-a844-ac6a8104211e@deltatee.com \
--to=logang@deltatee.com \
--cc=bhelgaas@google.com \
--cc=gustavo@embeddedor.com \
--cc=kurt.schwemmer@microsemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®