From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-177.mta1.migadu.com (out-177.mta1.migadu.com [95.215.58.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF62423E330 for ; Mon, 1 Dec 2025 06:48:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764571710; cv=none; b=Mq3RFJn8F8pm9xKKe/R0uEze4tgLe8aFBqPj+gZ1ZVGH8k3Oihg4Mp/mpC4KDhS+Km2xHuLql8mPaOu5PvrfEDqi4TZB1XXiSV2M6XSbtOPjDHKg6wZv38K3VIQxSaBaY9KRd7zA7Ex7sALHUhP9RososTAWSqV1MoQC1naYfQk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764571710; c=relaxed/simple; bh=1NRo23qvFcKwP4ZEynQppXAUxeIqmqyc5XRObziJiXg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mzPldbFql1kv9mkHHsbEafOCkjdhTfRhFCnqhAPEVKBmTLF0TA8zJefNVchWoxG0iF3LzEMGNNASDP0MGv9Fy19nTUWHZcyoZRwy6ERFavo0+6ToLCrXe4DRHRdTyJjGj0PD9qDoe2FJJFw1g2HASmxc7tPWM0MmUqNDoW50ea4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=packett.cool; spf=pass smtp.mailfrom=packett.cool; dkim=pass (2048-bit key) header.d=packett.cool header.i=@packett.cool header.b=vG/7rzgp; arc=none smtp.client-ip=95.215.58.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=packett.cool Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=packett.cool Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=packett.cool header.i=@packett.cool header.b="vG/7rzgp" Message-ID: <9a9280e7-d29a-475a-83fa-671acfab9d92@packett.cool> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=packett.cool; s=key1; t=1764571705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/CvsvPDo++88EIfQk1NEfDubJ5f3pS7dCz2G/tHuOlo=; b=vG/7rzgp++1UVzDvFlSiXFXxbhK45/p4F7ZFE/ppCGsEQ+Esxt2HtVMYpHX5qOGSKQjqcz lND3oOWBCZmrGS1zopweXxuye9ek6jNx/AW3yyjPyvxZe5NrFLk6RifnwwlkpAlYbPuAL5 Wiaf0ZsqgdXpAtoxwJmqLlDeV1QdKiFrGbFjrUBLNwhQHFhyICuY2M4/yrI3WQ9pBSFgeD jwOsWZZetVnlujuUmqn9QoIUpfnH8tqIUvCse4AVed+VqOjP7jdd7EwwIwhzyx69E2JTfp +0ORuqxTbNkLtnagpAP3Vzd0RB/pjgt7YIFk0Jy4lKKF5kJ8YdbziH1+8yZKSw== Date: Mon, 1 Dec 2025 03:48:13 -0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v2] PCI: Add quirk to disable ASPM L1 for Sandisk SN740 NVMe SSDs To: Manivannan Sadhasivam , Bjorn Helgaas Cc: Manivannan Sadhasivam , bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio , Alexey Bogoslavsky , Jeffrey Lien , Avinash M N References: <20251120161253.189580-1-mani@kernel.org> <20251124235307.GA2725632@bhelgaas> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Val Packett In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 11/25/25 2:21 AM, Manivannan Sadhasivam wrote: > [..] > There are a couple of points that made me convince myself: > > * Other X1E laptops are working fine with ASPM L1. > * This laptop has WCN785x WiFi/BT combo card connected to the other controller > instance and L1 is working fine for it. > * There is no known issue with ASPM L1 in X1E chipsets. > > Because of these, I was so certain that the NVMe is the fault here. There is *a* known issue with ASPM L1 on X1E, reported by maaaany users on #aarch64-laptops, that we discussed in another thread.. But it is a full system freeze, **not** a correctable AER message, and it definitely happens with a bunch of various SSDs on various laptops. I personally have had it happen both with the SN740 and an SK Hynix drive, on a Latitude 7455. It's an SSD-only issue (disabling ASPM just for the drive, but keeping it on for the WiFi, was enough to get to month-long uptime) but not specific to any SSD model. One bit of news I have about it is that I recently started using EL2 (slbounce), and I did see something that looked like that hang.. but unlike in EL1, right before the reboot the panic LED did start blinking. So if that was indeed from the same issue, I should now be able to catch it into pstore (if pstore works.. trying blk with sdhc instead of efi now 0.o) Maybe QHEE was eating the fault and itself crashing, since it "owns" the PCIe IOMMU when it's running.. (???) ~val