From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 748C3298255; Fri, 18 Jul 2025 09:19:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752830343; cv=none; b=iM76owqsIcBn2VbxsPmCPFGvS+anlUhHw7Njm9Qeogp0Ue705ycYs0cgzvbMV0uZAaX1bI5tZk03YNklqjcmr4csbov3hyM/tcLOmarO2652r62gxbBJ7Dp3ym1/quqha/GBElQqjHCkloi5MJN97SGHLlwmeyni83yjY1nTanw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752830343; c=relaxed/simple; bh=zc0SCSe5dmWIeZjMz3hpH98kv1/ooid1+C6hklMxXHY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=o6+ZudnVxtqjdif8VHOZo9tKO0kdtHOQqa6Y3k3ZAOCOvgIe2HIwj2VY0v5CajV6EgFC1tmolXqK+/RaEmPFewdfCvhH4q34SSrNIVoaNH+nAOV+q7CnffwXIWVI3yCKqkxuitepKdZisMl7eBzXsDemCrIJuhqWgk5DajIyhJA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=feAxFeI6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="feAxFeI6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45DA8C4CEED; Fri, 18 Jul 2025 09:18:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752830342; bh=zc0SCSe5dmWIeZjMz3hpH98kv1/ooid1+C6hklMxXHY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=feAxFeI6s7xbdfD7VqMf9akefxnzKYsmkZ/mH2hde8VOomBy2PEh1fmKvFA3t/TmB UCC6zLMXP2pm1eh6wvbNL4bQ3VksNVHTunfpA44KDJmjIN6urxINtCCiwRJxvCGs0O I1C2Tx6HMiN6vlCiLBMoBtgYvjRyXw5BRSb8uHKsNn5TdS9GBiiBeM6FaSe/rNu8Jd FD69hz3QXn9/9hx2QBHsEmFAEhTcVPbGRJBwvTOP67WZ63Udt2Ch4Mtdv3JMv8bPa0 sBuob2YfAJ7UR18UkiYL4uEa1nl9+en+8GKLYyMRdjbo+LGXsMSih4X9Hc3w4rbOTl hZCoBy6EEQMGA== Message-ID: <9a932904-4aec-4e2d-b00f-519a4ca92e17@kernel.org> Date: Fri, 18 Jul 2025 11:18:57 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/10] ASoC: mediatek: mt8189: add machine driver with nau8825 To: =?UTF-8?B?Q3lyaWwgQ2hhbyAo6ZKe5oKmKQ==?= , "broonie@kernel.org" , "conor+dt@kernel.org" , "tiwai@suse.com" , "robh@kernel.org" , "lgirdwood@gmail.com" , "matthias.bgg@gmail.com" , "krzk+dt@kernel.org" , "perex@perex.cz" , AngeloGioacchino Del Regno Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "linux-sound@vger.kernel.org" , "devicetree@vger.kernel.org" , Project_Global_Chrome_Upstream_Group References: <20250628071442.31155-1-Cyril.Chao@mediatek.com> <20250628071442.31155-10-Cyril.Chao@mediatek.com> <143fb1f0756caeb8287ab02be450ecdb3459c6d8.camel@mediatek.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <143fb1f0756caeb8287ab02be450ecdb3459c6d8.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 18/07/2025 10:44, Cyril Chao (钞悦) wrote: > On Sat, 2025-06-28 at 14:39 +0200, Krzysztof Kozlowski wrote: >>> + .of_match_table = mt8189_nau8825_dt_match, >>> +#endif >>> + .pm = &snd_soc_pm_ops, >>> + }, >>> + .probe = mtk_soundcard_common_probe, >>> +}; >>> + >>> +module_platform_driver(mt8189_nau8825_driver); >>> + >>> +/* Module information */ >>> +MODULE_DESCRIPTION("MT8189 NAU8825 ALSA SoC machine driver"); >>> +MODULE_AUTHOR("Darren Ye "); >>> +MODULE_LICENSE("GPL"); >>> +MODULE_ALIAS("mt8189 nau8825 soc card"); >> >> That's neither needed nor correct. Look how aliases are created >> first. > > I reffered to the previous platform(mt8188). Could you help to give an > example about MODULE_ALIAS or some doc for me to reffer? Much thanks ~~ If you ask for doc, then it feels like you do not know if you need it. I think you do not need it and the burden of proving why you need it is on you. Best regards, Krzysztof