From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795284970; b=MmNKLTqq7vTE94QXel7aCS4WxB9qUFYc3Sr06/XHPSgi3YV9Y1jPWygk55NVrR0q6or+ WvF3FbErTNSdbhEHCKdj/v83dSTuZt5i6aP4AKvkEfYoSx6T9AHuo8yZCgvMMb2Id1atC J5LSwQ8OYlaq9mhRGfvTqY/hqkDdG+T04bCY2r0oJimm3ZAZuh3YAhylc8YqiJ1Dl9FKk aSybCH9H9gTOoWHoh/jZXK7yUIwmeBhIaXiKR85uG4sgnman+v1Z7G/kAUQTtnwb95cfA zQKz4HiuU4lp5Add1ZD2wirMaSVbwm0ykfY24rNSZ/zyJtQcRUKbs2OCgw4HNVjY+rQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795284970; h=Received:DKIM-Signature:Received:Received:X-ME-Sender: X-ME-Proxy-Cause:X-ME-Proxy:Feedback-ID:Received:X-Mailer: MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type:Content-Transfer-Encoding; bh=1X5j7YQdcz6iEhlSddIVL1ix+zetO1vVrxlepqlUlLI=; b=xWJOal1ouV4PmUsyfKWDXN63UwJkBieRGk4W3yQzEgrWmFUKhXVd6Cz4kGb0ToSiMeYs McnujS9IFC2Qo2LmuWDfYvg45o2cuNDkePrCEzbnojQ0Mies0n6dknaf06vBnEfYtniF3 G9keemaVNBH8aFQsSrgJIs4t07b0aEA0tFDe12NTh7iwQ2Goa6EYmMwmwy/4wF0ZNecbE TS0z4SAgad8uSMI34/Z8fZXIu8qDLZpOh04QCCKZ9JTAeZ00sDQd151AJN4vf0lLyoYy2 Rn274hrYuj2D3m5m7M1GDMncltZ3jBoMw7TI2BIPeHjiB46DGB2v/MxGEjurIWOPwmw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b="OKi/CDxg"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49802606A32A for ; Sat, 21 Nov 2026 18:16:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=OKi/CDxg Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24CBD1F000C6; Sat, 21 Nov 2026 18:16:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795284969; bh=1X5j7YQdcz6iEhlSddIVL1ix+zetO1vVrxlepqlUlLI=; h=Date:From:To:Cc:In-Reply-To:References:Subject; b=OKi/CDxghY1dqryAz4GUSP2DyKhjM/BKsCRf8IGiH5+r7CjEwEAXZnZel6KrM9ys7 Juw3/sshAmYwBIyxRwd4pxzBr+FVOFEQFcaKZ7lUoNXV9Qr33hywKKY059ZZAOgEN9 YKMtcKXfd5iCzHSD3w6EmkLW1AfJZhwDvxBDs+OmeluWryu61WQmMCS/duOqgWSNhe pnfBS8rZlNy/6+dnLtb3wOliz2YyVTnyC0xvl4wYEj6jKKKE/153ogOkVv+KOV4Eit c8gIhHXZci4mOwJ1y1pS+nW2p+EKTPox1+pQQ1SDlMHKwJkrXYe/kDSjUkUe1HKCTw cF88jC797CQ5A== Received: from ams-compute-02.internal (ams-compute-02.internal [10.64.2.62]) by mailfauth.ams.internal (Postfix) with ESMTP id 3FACA198003A; Sat, 21 Nov 2026 13:16:07 -0500 (EST) Received: from ams-imap-11 ([10.64.2.31]) by ams-compute-02.internal (MEProxy); Sat, 21 Nov 2026 13:16:07 -0500 X-ME-Sender: X-ME-Proxy-Cause: dmFkZTEtnHGhzDjhdINsG+KI0AoS/50TK6i0wx1kQ//6c35E2ONVRFcccFQwcKMKtHY8mi bpKgiKFvgyr5dJzeZ3i9+Wpo9GY7dsrP0B5Q7pRmFO8jNvkYwxDvX72jCnQhaXF/lbhLU7 cuhmg/0yG+L1AOBY58lznHtSzbcbrz8Tt5TrAGIrXp8x7mTuSDCEy8ZLJ7pQHLmHkCxoN4 9DNUcTVGGis4QgolqvOmcUwB0NDvIAxwlHDkhKpfEBJuN4KIk2oefdaWg4cVlCAsVFojwu 6elGZvjbiLHilZ+ggJVlCnal4RSLjOe34UQkgEPyiOQ/osegaaaVWWoJYnVLI5A4H0PPTE tNyotbzbZ4WhPf9sGuZUNl3qfvmWh8Mht94TIVZWmom+eLXngnpGxMjmbNIGjC4JMC9Jwh HhtxIJ4PxPMGTye2eEOCAqZL7aUeUKPr1nMmlPpxHPnTDiwbXyqcHDI8W+TH5ekEOfBs8h tAjM52b23mFqW01Uj3K1WOIm525O/G1o5cbTxA9hwSPiU5Dv8MegKypFQUFCF/EUeyZ4xr nOLSiNWkgfTq+Q+atQEShXQdnWnPStC57ECGtQZkhGgtUHCB4uf7XaKcwm81cxHRHOMUUT VB5gf9jp2LMf99oh3KXve7qkvCCxRamQ6pvLQadt4w9adP7M/Cwf46VUXZQw X-ME-Proxy: Feedback-ID: ice86485a:Fastmail Received: by mailuser.ams.internal (Postfix, from userid 501) id 2505FF8008E; Sat, 21 Nov 2026 13:16:03 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Date: Sat, 21 Nov 2026 19:15:42 +0100 From: "Ard Biesheuvel" To: "Han Gao" Cc: gaohan@iscas.ac.cn, "Ilias Apalodimas" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , "Alexandre Ghiti" , "Atish Patra" , "Stephen Boyd" , "Brian Masney" , "Jerome Brunet" , "Chen Wang" , "Inochi Amaoto" , linux-efi@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, sophgo@lists.linux.dev Message-Id: <9a94e434-13b8-4a45-bf3a-78f99a2435d9@app.fastmail.com> In-Reply-To: <20261121144848.1277368-1-rabenda.cn@gmail.com> References: <20261121144848.1277368-1-rabenda.cn@gmail.com> Subject: Re: [PATCH 1/2] riscv: efi: Map runtime MMIO with device attributes Content-Type: text/plain Content-Transfer-Encoding: 7bit On Sat, 21 Nov 2026, at 15:48, Han Gao wrote: > On Sat, 21 Nov 2026 13:42:20 +0100 "Ard Biesheuvel" wrote: > >> >> >> On Sat, 21 Nov 2026, at 11:38, Han Gao via B4 Relay wrote: >> > From: Han Gao >> > >> > EFI_MEMORY_MAPPED_IO regions are mapped with PAGE_KERNEL, so device >> > registers end up mapped as normal memory. >> > >> > On Milk-V Pioneer, GetTime() reads the clock controller registers and >> > faults: >> > >> > Oops - load access fault [#1] >> > Workqueue: efi_runtime efi_call_rts >> > status: 0000000200000120 badaddr: 0000007030012000 cause: 0000000000000005 >> > >> > Use PAGE_KERNEL_IO for these regions. >> > >> > Fixes: b91540d52a08 ("RISC-V: Add EFI runtime services") >> > Signed-off-by: Han Gao >> > --- >> > arch/riscv/kernel/efi.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> >> Acked-by: Ard Biesheuvel >> >> I can take this as a fix via the EFI tree if you like. > > Yes, please take it through the EFI tree. Thanks! > OK, I've queued up patch #1