mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "André Almeida" <andrealmeid@igalia.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
	Borislav Petkov <bp@alien8.de>,
	linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	kernel-dev@igalia.com, Thomas Gleixner <tglx@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH RFC 1/4] syscalls: Create unified partial table for all archs
Date: Fri, 24 Jul 2026 17:18:48 -0300	[thread overview]
Message-ID: <9a9caecf-5d72-4c68-ad46-5779c3fb73f0@igalia.com> (raw)
In-Reply-To: <3a481359-72d0-4c58-8a63-b6d941a22482@app.fastmail.com>

Em 24/07/2026 17:09, Arnd Bergmann escreveu:
> On Fri, Jul 24, 2026, at 22:00, André Almeida wrote:
>> To take advantage of the subset of syscall numbers that are guaranteed to
>> be shared, create a new table and adapt generation scripts to use it. In
>> that way, every new syscall can be added to a single file.
>>
>> Signed-off-by: André Almeida <andrealmeid@igalia.com>
> 
> Thanks a lot for working on this, I had planned to do this myself
> for a while but had never quite gotten around to finish it.
> 
>> +#
>> +# syscall numbers shared by architectures
>> +
>> +442	common	mount_setattr			sys_mount_setattr
>> +443	common	quotactl_fd			sys_quotactl_fd
>> +444	common	landlock_create_ruleset		sys_landlock_create_ruleset
>> +445	common	landlock_add_rule		sys_landlock_add_rule
> 
> It should really be anything starting at 403, not just 442 and higher.
> 
> There are some trivial differences that have crept in over time,
> but we should be able to work around those.
> 

The thing that prevent me starting before 442 was how to deal with 
compat. If I add to the table

441	common	epoll_pwait2		sys_epoll_pwait2		compat_sys_epoll_pwait2

It will wrongly add

__SYSCALL_WITH_COMPAT(441, sys_epoll_pwait2, compat_sys_epoll_pwait2)

to arch/x86/include/generated/asm/syscalls_64.h.

Maybe I could add a --ignore-compat to scripts/syscalltbl.sh, and add 
this flag for 64 builds. What do you think?

>> index 22e34cd46b9b..77934a2d0f51 100755
>> --- a/scripts/syscallhdr.sh
>> +++ b/scripts/syscallhdr.sh
>> @@ -26,6 +26,7 @@ usage() {
>>   	echo >&2 "  --emit-nr          Emit the macro of the number of
>> syscalls (__NR_syscalls)"
>>   	echo >&2 "  --offset OFFSET    The offset of syscall numbers"
>>   	echo >&2 "  --prefix PREFIX    The prefix to the macro like
>> __NR_<PREFIX><NAME>"
>> +	echo >&2 "  --common-tbl       Use the common number table"
>>   	exit 1
> 
> Ideally we shouldn't even need this bit either, though it may
> help for the transition phase.
> 
>       Arnd


  reply	other threads:[~2026-07-24 20:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-24 20:00 [PATCH RFC 0/4] syscalls: Add a shared " André Almeida
2026-07-24 20:00 ` [PATCH RFC 1/4] syscalls: Create unified partial " André Almeida
2026-07-24 20:09   ` Arnd Bergmann
2026-07-24 20:18     ` André Almeida [this message]
2026-07-24 20:25       ` Arnd Bergmann
2026-07-24 21:22         ` H. Peter Anvin
2026-07-25  8:25           ` Arnd Bergmann
2026-07-24 20:00 ` [PATCH RFC 2/4] syscalls: Add support for x86_x32 for the common syscall table André Almeida
2026-07-24 20:16   ` Arnd Bergmann
2026-07-24 20:00 ` [PATCH RFC 3/4] x86: Use " André Almeida
2026-07-24 20:00 ` [PATCH RFC 4/4] scripts/syscall.tbl: Use the common table André Almeida

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a9caecf-5d72-4c68-ad46-5779c3fb73f0@igalia.com \
    --to=andrealmeid@igalia.com \
    --cc=arnd@arndb.de \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=kernel-dev@igalia.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=nathan@kernel.org \
    --cc=tglx@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®