From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 422D2423E9C for ; Sun, 11 Oct 2026 09:08:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791709701; cv=none; b=Rb4y7BgzhIzxn6JIChdftz8slWYVhpUI0mGQ+pDcNvOVsOQWqunPDLxZ0Rbq7ZkvQH5wkPehcc+d5cHSKm0it9VhDiqARdPJLFyfcMbi730fHTmr7LdtUhPm+BlW4lntB1eTcG6HLfUp5R6FOHY0NtOMPrsNof1sgt56ewqaDyc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791709701; c=relaxed/simple; bh=5oHe4n5rbLwyg7OqY/yYUv5kuFE9IDPOKywLKt7K5uM=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=q5v3TQg9oWR5zB2WPBqEtZ61pK6wF6OV1QWkzGB0NnVUp4uGtc3IwyUGJtjGkgb4K0kVoeLxtEmQuLADBpB5G+y7SHuPiDIgSamgLGe/58XQyp5U8bFzc/f8CIp1e5xWBTz4/AUxrbFPbzGVBsqnEft1moB8V+Q6ntnoTB2e/uA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IFz3nDqW; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cxpGi2o6; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IFz3nDqW"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cxpGi2o6" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69B85Tnv2972290 for ; Sun, 11 Oct 2026 09:08:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= C/iR2mjTCid+nrePpQGbvgdRC2IVUI2A0iMsqmLXvp8=; b=IFz3nDqWtEVZKMXr DjsxrI+VQ/SyD2PupNiCm5RropHru1KtK8wTldunls87r9tUfIzKoqR7XGjMP5R1 hsidtLi0LhQWcRwW4rYcR5vIG34FdRRbovpJX08lR/ibXqZA48QH23yq/bhKQ33d mzESyyGnSstar+PM+NUMoizC95TKHH/i0NSc7BiL866bse/quPNvbLdl3zUkypCk HiHA00UV0Jh7IBTJ/vfmocqo/hUb9lQRLA4HYnXoBbL/ZUKeJan/juJ8M42sxuYH yX+lVy4wyW9162Q1j56vozPGECQ1OGOp+LJ/a9ddh4KYKMvYHMbhBWKFTrfE9Ppo ecCLow== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4h7dk22q4r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 11 Oct 2026 09:08:18 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-93cc40759b2so253834085a.1 for ; Sun, 11 Oct 2026 02:08:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1791709697; x=1792314497; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to:content-type; bh=C/iR2mjTCid+nrePpQGbvgdRC2IVUI2A0iMsqmLXvp8=; b=cxpGi2o6itdaUoOcNyn2/qvqt6rX24yPpSYz4fMw+lTC2+VmHU9Hy69ht2g+6eSrIV D0Iuo2wvVJbqRN99mQqI23ZIHM6zTBZ1YoSUXvQDex56vfH04Kv6hZ3SDEB1yZ504MRU mV21gpiecOjMxzHcAHsVUY7+ME2or35Z7TRV+MBu0M2SLRFGJXxrkLOl1DkhjJMsRIu1 WNXxqDHzVAxXlEyFsjIGdV4E4OWUT7AsjnBdoQH/0eV5kepAjY19BRwUi/EkuxoCAJ05 f/HvFxdmUv712f2WM3S+jJTSnJ9A71FCnVCVRfs8S0ExakTuJ8EbH43AZ4rg9Wb6z9bW tG0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791709697; x=1792314497; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=C/iR2mjTCid+nrePpQGbvgdRC2IVUI2A0iMsqmLXvp8=; b=ttv9gY/WhajSTiXm40UcQG6N74JLJ1vJ0TiFm2v4ZnJjVWlL+dzxz8jQSuKN4/GR69 fZPRLKpJB2L/rNCpbiwsTVP8lPuPgbPVSRhv9OFVGJSK1w0YFR1LEEdFYMLCREfJ+gKZ lxM4vjpBsDHO/z9DCBAwyVY+iYbO/WUJoJTDZs10vWHiPPJ68jSnkol9jEzqo39S7w8f FfI8dYd4bkSBn1E8EcT3h/gi66pnnKhVxefoFjns+7B2juGwZ8kh/AXgjMNPVWBoSz2D s2zT9L/zbUeMpu5VqkKhz+fpSk/VPbKVB0WItr5+eDfMHvu0Av2oETPXHOLjKByj4Wjr ID/Q== X-Forwarded-Encrypted: i=1; AKwUvBx+mO5rBseNC0FMLOg5PisN5AhoBL++OdDoiOOAq9Egd0fyJ1e5EQ5ZESsFbs4lNEvUkSTL2M2jwJ2ivBE=@vger.kernel.org X-Gm-Message-State: AFq9FYKom7efGGgKhB7mCD0blHxxaJLhlc6ro6biIO/ntAjaqEJuOYLe Ovo6OYXeYscWx2TcndZezzyldBZC1kvhsW0ibm5rkMZkZaxQD11B9ERQfCC/kJFo6GCzTegCpms ZjIAGk9BuOuK+j1lmGSefx/uEua2i35Q2bm70bLn0YzDKhy9EfJ9pDTaJIkLNOD1B+HU= X-Gm-Gg: AYBFou1RiR8Qh05eREPH52LNnsjPYZzvxxHIbgG2hAKjI5kEDCFH2F0cM+eGKKHpjRc 2lonp3fdK/5CelIPuhPY/uu5IB9Q/GOwTgmxnNoHwCZtRcsP+mHSLXjM+Uhd2jiNYAl3lGfxiUJ 35aR2gYeAKEEe0Wmrfgwl/QlZVp8MCDHFHgdbzag9ceYw7BYL2T1TDv+PC31BWG9pJGENbrK3P0 aZ+51pox+Sxcnyo4ywa00qAd0UHPLSe/mDjttc5aUYX+PxZnO5RFXJBv0v3NllvgKIUAvx4tIHL qkSzkwxYxrdDl1/qQuNcDTSLOCZRKHJP3rLHdzXfiIy3zxKsrjjb891HUaYVY3OuIyEcXvyFFvV rEtePOgPnshAXoCkXJkUZ/Jx93efmvRLe9XHMo0+nsRt/0+DA/f30edF4a8fL X-Received: by 2002:a05:620a:a2cf:10b0:93e:c12c:f133 with SMTP id af79cd13be357-93ec12d074emr701304885a.78.1791709697088; Sun, 11 Oct 2026 02:08:17 -0700 (PDT) X-Received: by 2002:a05:620a:a2cf:10b0:93e:c12c:f133 with SMTP id af79cd13be357-93ec12d074emr701302585a.78.1791709696517; Sun, 11 Oct 2026 02:08:16 -0700 (PDT) Received: from ?IPv6:2a00:23c4:e5c9:901:c496:8838:86d0:bc8c? ([2a00:23c4:e5c9:901:c496:8838:86d0:bc8c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48db94e2f08sm13334523f8f.15.2026.10.11.02.08.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Oct 2026 02:08:15 -0700 (PDT) Message-ID: <9a9cc7d383b668bd2c96596a96ca30b73e9ccff3.camel@oss.qualcomm.com> Subject: Re: [PATCH] arm64: dts: qcom: x1: split PAS remoteproc iommus out of x1-el2 From: Christopher Obbard To: jens.glathe@oldschoolsolutions.biz, Bjorn Andersson , Konrad Dybcio , Abel Vesa , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Xin Liu Cc: Konrad Dybcio , Nikita Travkin , Birk Skyum , Stephan Gerhold , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sun, 11 Oct 2026 10:08:14 +0100 In-Reply-To: <20260914-x1-el2-unfuck-v1-1-00d8bc35a635@oldschoolsolutions.biz> References: <20260914-x1-el2-unfuck-v1-1-00d8bc35a635@oldschoolsolutions.biz> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-10 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: r3ZLzwAhmNk3VLY8Qo_WrzVe2OooFD0k X-Proofpoint-GUID: r3ZLzwAhmNk3VLY8Qo_WrzVe2OooFD0k X-Authority-Analysis: v=2.4 cv=E6hYNqdl c=1 sm=1 tr=0 ts=6acb5202 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=gxl3bz0cAAAA:8 a=InlpzHCLAAAA:8 a=ud_x2R5wYZwBytq8-mIA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=kiRiLd-pWN9FGgpmzFdl:22 a=j9sqBCYxEfXq8HZXc0HF:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDExMDAzNiBTYWx0ZWRfXx2RTcscZ3X9B 4wSqP3VtfppnZspzLxg6W8BlsIFfE14S4ktGEHuM9WBEnxR9D+jY88hgV6fN4oRRR7EUIwudhSI z/48NaVblVLmte6eZWPlZr5QY/LBLdhqbz00ChOXO9J4j1JROKye8rDFdvR20+q2lYGsWDAlFQb B11brAkAJ3D5L3rU6SHEcU4wFd9LEcAqZZhvKbc9zwWgrEd5MBalmW68IUS6RLlwOHr4BZWHFS1 5GbS+i1MAw9PLhaAdwSXLsSnfHd21b28KXb3R2fKfYlWcOdlnl1KF35m3iKNIbL5twW4fPBuE7R PvYo6+iiE2CHLA0ZPozZLBCU9XJTLB0TDldSNU3WKrpMFPF+65LHL8WUYuG3SWlgCncT3rgVG/L UZeZMGwLkHPvL4sCfp+EjQE4M3XEDyP3vRPa2IYVySgfenmA70tloMXlui5kBprGrM+kRyXEzxp cMjzsZZ9VGgBoGI8K3g== X-Proofpoint-Spam-Info: AW1haW4tMjYxMDExMDAzNiBTYWx0ZWRfX+DWtmvRCfnsB fkVBSPVaitfXxOsF2gAqGwbznq00C+FBn7fSsNYYdw3zSvy4FZgDxkB0rC3Urden6A+PHSCkW+h 3CpqAAZtR2Sz8JmJ70pbMHpIu8bm1ps= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-11_03,2026-10-09_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 impostorscore=0 phishscore=0 bulkscore=0 spamscore=0 adultscore=0 priorityscore=1501 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610110036 Hi Jens, On Mon, 2026-09-14 at 21:42 +0200, Jens Glathe via B4 Relay wrote: > From: Jens Glathe >=20 > The shared x1-el2 overlay currently attaches apps_smmu streams to > remoteproc_adsp/cdsp so Linux can program those SIDs when PAS is > used to authenticate and reset the DSPs. >=20 > That is wrong for the common WoA EL2 path (slbounce + shipping > UEFI). There the DSPs are already running from the bootloader and > the SMMU probe path leaves their SIDs in bypass. Describing iommus > on the remoteproc nodes replaces that bypass with a translated > context that is never set up, and boot dies in an SMMU fault storm > on SID 0x1000 before userspace. >=20 > Move the remoteproc iommus into a new x1-el2-pas overlay and apply > it only on hamoa-iot-evk, which is the platform that actually needs > PAS-managed remoteproc under EL2. Other x1e/x1p -el2 DTBs stay on > the generic overlay. >=20 > Tested on: > Lenovo Yoga Slim 7x (83ED, BIOS NHCN62WW) by Birk > Lenovo Thinkpad T14s G6 (21N1, Hamoa) > Lenovo IdeaCentre Mini 01q8x10 (91B6, Purwa) > Lenovo Ideapad 5 2in1 14Q8X9 (83GH, Purwa) >=20 > Fixes: 47c88db49f6c ("arm64: dts: qcom: hamoa: Add remoteproc IOMMUS in E= L2 device trees") > Link: https://lore.kernel.org/all/20260130073113.3091884-1-xin.liu@oss.qu= alcomm.com/ > Suggested-by: Nikita Travkin > Assisted-by: Grok(xAI):4.6 > Tested-by: Birk Skyum > Signed-off-by: Jens Glathe Tested-by: Christopher Obbard # Lenovo=20 T14s Hamoa Thanks! Chris > --- > arch/arm64/boot/dts/qcom/Makefile | 2 +- > arch/arm64/boot/dts/qcom/x1-el2-pas.dtso | 21 +++++++++++++++++++++ > arch/arm64/boot/dts/qcom/x1-el2.dtso | 8 -------- > 3 files changed, 22 insertions(+), 9 deletions(-) >=20 > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom= /Makefile > index d6547fb18edf0..1d1cdf057fd99 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -22,7 +22,7 @@ dtb-$(CONFIG_ARCH_QCOM) +=3D glymur-hp-elitebook-x-g2q.= dtb > dtb-$(CONFIG_ARCH_QCOM) +=3D glymur-lenovo-yoga-slim7x.dtb > dtb-$(CONFIG_ARCH_QCOM) +=3D hamoa-iot-evk.dtb > =20 > -hamoa-iot-evk-el2-dtbs :=3D hamoa-iot-evk.dtb x1-el2.dtbo > +hamoa-iot-evk-el2-dtbs :=3D hamoa-iot-evk.dtb x1-el2.dtbo x1-el2-pas.dtb= o > =20 > dtb-$(CONFIG_ARCH_QCOM) +=3D hamoa-iot-evk-el2.dtb > dtb-$(CONFIG_ARCH_QCOM) +=3D hamoa-lenovo-ideacentre-mini-01q8x10.dtb > diff --git a/arch/arm64/boot/dts/qcom/x1-el2-pas.dtso b/arch/arm64/boot/d= ts/qcom/x1-el2-pas.dtso > new file mode 100644 > index 0000000000000..05364b439182a > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/x1-el2-pas.dtso > @@ -0,0 +1,21 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Extra EL2 overlay for platforms where Linux programs remoteproc > + * IOMMU streams because PAS is available. > + * > + * Do not apply this on current WoA firmware. Those DSPs are started > + * by the bootloader and rely on the SMMU SID bypass set up in > + * qcom_smmu_cfg_probe(). Attaching iommus here replaces that bypass > + * with an empty translated context and faults SID 0x1000. > + */ > + > +/dts-v1/; > +/plugin/; > + > +&remoteproc_adsp { > + iommus =3D <&apps_smmu 0x1000 0x80>; > +}; > + > +&remoteproc_cdsp { > + iommus =3D <&apps_smmu 0x0c00 0x0>; > +}; > diff --git a/arch/arm64/boot/dts/qcom/x1-el2.dtso b/arch/arm64/boot/dts/q= com/x1-el2.dtso > index ee006742d6f3b..175679be01eba 100644 > --- a/arch/arm64/boot/dts/qcom/x1-el2.dtso > +++ b/arch/arm64/boot/dts/qcom/x1-el2.dtso > @@ -52,14 +52,6 @@ &pcie_smmu { > status =3D "okay"; > }; > =20 > -&remoteproc_adsp { > - iommus =3D <&apps_smmu 0x1000 0x80>; > -}; > - > -&remoteproc_cdsp { > - iommus =3D <&apps_smmu 0x0c00 0x0>; > -}; > - > /* > * The "SBSA watchdog" is implemented in software in Gunyah > * and can't be used when running in EL2. >=20 > --- > base-commit: 1a1de54f7369cd2b5bac0f265910e60ad3a6b4c3 > change-id: 20260514-x1-el2-unfuck-0c46167538f4 >=20 > Best regards,