From: "yu kuai" <yukuai@fygo.io>
To: "Li Youhong" <dayou5941@163.com>, <song@kernel.org>,
"yu kuai" <yukuai@fygo.io>
Cc: <magiclinan@didiglobal.com>, <xiao@kernel.org>,
<linux-raid@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Li Youhong" <liyouhong@kylinos.cn>,
<syzbot+6a132745caefcf42cb0d@syzkaller.appspotmail.com>
Subject: Re: [PATCH] md/raid5: drain released_stripes before destroying the cache
Date: Sun, 4 Oct 2026 12:17:47 +0800 [thread overview]
Message-ID: <9a9dcf9c-1daf-45ee-9c5b-6b4ea01ea359@fygo.io> (raw)
In-Reply-To: <20260929083916.50620-1-dayou5941@163.com>
在 2026/9/29 16:39, Li Youhong 写道:
> From: Li Youhong<liyouhong@kylinos.cn>
>
> grow_one_stripe() calls raid5_release_stripe() for each new stripe.
> When mddev->thread is already set, that queues the stripe on
> conf->released_stripes and wakes the thread. Only raid5d moves that
> list onto inactive_list.
>
> Takeover calls setup_conf() while mddev->thread still belongs to the
> previous personality, so those stripes stay on released_stripes. If
> setup_conf() then fails, shrink_stripes() only frees inactive_list and
> kmem_cache_destroy() warns that objects remain.
>
> Move stripes still queued on released_stripes onto inactive_list
> before shrink_stripes() frees them.
>
> Fixes: 773ca82fa1ee ("raid5: make release_stripe lockless")
> Reported-by:syzbot+6a132745caefcf42cb0d@syzkaller.appspotmail.com
> Closes:https://lore.kernel.org/linux-raid/6ab6b743.7eec07f4.c25c.0006.GAE@google.com/T/#t
> Signed-off-by: Li Youhong<liyouhong@kylinos.cn>
> ---
> drivers/md/raid5.c | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
Applied to md-7.4
--
Thanks,
Kuai
prev parent reply other threads:[~2026-10-04 4:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 8:39 Li Youhong
2026-10-04 4:17 ` yu kuai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a9dcf9c-1daf-45ee-9c5b-6b4ea01ea359@fygo.io \
--to=yukuai@fygo.io \
--cc=dayou5941@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=liyouhong@kylinos.cn \
--cc=magiclinan@didiglobal.com \
--cc=song@kernel.org \
--cc=syzbot+6a132745caefcf42cb0d@syzkaller.appspotmail.com \
--cc=xiao@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®