From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751708AbdCNNyz (ORCPT ); Tue, 14 Mar 2017 09:54:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57632 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751618AbdCNNyc (ORCPT ); Tue, 14 Mar 2017 09:54:32 -0400 Subject: Re: [PATCH v1] KVM: s390: use defines for execution controls To: Christian Borntraeger , kvm@vger.kernel.org References: <20170313104828.13362-1-david@redhat.com> <5ec9b559-40c5-8f64-c2e8-dc8cabd478d4@de.ibm.com> Cc: Cornelia Huck , linux-kernel@vger.kernel.org From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <9aa04d37-638a-d326-3973-e43439a49216@redhat.com> Date: Tue, 14 Mar 2017 14:54:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <5ec9b559-40c5-8f64-c2e8-dc8cabd478d4@de.ibm.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 14 Mar 2017 13:54:32 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 14.03.2017 um 14:51 schrieb Christian Borntraeger: > On 03/13/2017 11:48 AM, David Hildenbrand wrote: >> Let's replace the bitmasks by defines. Reconstructed from code, comments >> and commit messages. >> >> Tried to keep the defines short and map them to feature names. In case >> they don't completely map to features, keep them in the stye of ICTL >> defines. >> >> This effectively drops all "U" from the existing numbers. I think this >> should be fine (as similarly done for e.g. ICTL defines). > > The patch does change the binary result and this seems to be related to the > U removal. But as far as I can tell this is fine, its just some subtle > undefined behaviour change between unsigned/signed which we do not care > about. > > >> >> I am not 100% sure about the ECA_MVPGI and ECA_PROTEXCI bits as they are >> always used in pairs. > > Just historic baggage, e.g. in 3.10 we set eca to 0xC1002001 and over > time we split those out piece by piece. Those two are just the last men > standing. > > I think I am going to apply this with some minor changes (EC* names). Ok > when I do the changes? > Sure, feel free to modify! Thanks! -- Thanks, David