From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 587D0C2BB86 for ; Tue, 14 Apr 2020 12:09:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 347462075E for ; Tue, 14 Apr 2020 12:09:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fiCLrYaO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439900AbgDNMJC (ORCPT ); Tue, 14 Apr 2020 08:09:02 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:48247 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2439885AbgDNMIr (ORCPT ); Tue, 14 Apr 2020 08:08:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586866127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=74+NBoVwwCLwEv4kMoUPHSjG1LhHKGIGgc4Wi5obL7E=; b=fiCLrYaOPtAL+ZwjRWeAoBFizH7OChoQksKU42NfTiVI6gB9TK9ZEoa0QcU4kwPfH9LBtS arR66xpfRTJlCM0S96GLg+/WdMg0j0URxcAGm60GlYinI7BCaLAVWw0N8qe9Ytcs5CCoE3 TU0my530BdneElZR5acNzkgcfhzCpSw= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-461-Y2yg9mD4OOSFZal4e00_7Q-1; Tue, 14 Apr 2020 08:08:45 -0400 X-MC-Unique: Y2yg9mD4OOSFZal4e00_7Q-1 Received: by mail-wm1-f72.google.com with SMTP id u11so1410534wmc.7 for ; Tue, 14 Apr 2020 05:08:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=74+NBoVwwCLwEv4kMoUPHSjG1LhHKGIGgc4Wi5obL7E=; b=fpntWM/HRzEzdFRnR4J0qyDflnBaYjotZF9H+4FicelitFB3RDVHjrrQnZBfHSRLl4 lVVr6av1XVbvJ+IEaKPcfitrtXr32yoy44znJnpz/zqgnRQLok68gEgvSkXqn+3rpOJU k0bIwJ+QXAVUdxsXK0LBtS1byMF7upo5OOoJ7AOPK5gbQytya0R3E2MmNah75UsaArsY lYk2gLG2yW+D7RkujfIGnKVSTYjy/9gbpDlsoJTBseoqTLGSMRCamCpO2BEtLsZGalkI gS9ZbYeBAc7wDOTx8ZJAHl/MCoThJedHhPuVCxomzBj3eL6nb0YuafGwTcljN5rTmW18 J4wA== X-Gm-Message-State: AGi0PuZG6ozskVWpGl8kgvV16RQeN0GgsVncHuiTW62mIzsR1f/wslzx w+CWCSEzAaksJTO/UjMDK0A1W2kLlcmZsN/tZG4e2YdNB6j7y0skVyojoyjZOmfCMihb2wx4ZOd +kHXq0u07IcXPefwNl7seCqn7 X-Received: by 2002:adf:edcc:: with SMTP id v12mr6902487wro.317.1586866124226; Tue, 14 Apr 2020 05:08:44 -0700 (PDT) X-Google-Smtp-Source: APiQypInYtHPsLVtRyg24LFQXGyoaVYx3cqklTOGEvqf6qsZ9/7yOIVtIBJpnmfTL5QQ8Q+LS63Gtw== X-Received: by 2002:adf:edcc:: with SMTP id v12mr6902444wro.317.1586866123656; Tue, 14 Apr 2020 05:08:43 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c0c-fe00-d2ea-f29d-118b-24dc.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:d2ea:f29d:118b:24dc]) by smtp.gmail.com with ESMTPSA id c18sm18447731wrx.5.2020.04.14.05.08.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Apr 2020 05:08:43 -0700 (PDT) Subject: Re: [PATCH v1 0/6] platform/x86: intel_cht_int33fe: clean up series To: Andy Shevchenko , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, Heikki Krogerus , platform-driver-x86@vger.kernel.org, Darren Hart References: <20200408160905.12101-1-andriy.shevchenko@linux.intel.com> From: Hans de Goede Message-ID: <9aa81292-70c2-c12a-ded1-1164faac0024@redhat.com> Date: Tue, 14 Apr 2020 14:08:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200408160905.12101-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 4/8/20 6:09 PM, Andy Shevchenko wrote: > When I started looking into the intel_cht_int33fe driver for an example of use > software node API, I have noticed that it's hard to get and code a bit messy. > Here is a clean up, main part of which is to introduce node groups and API to > register and unregister them. This and some pre-existing APIs can be used in > the driver. > > So, because of cross-subsystem nature of this series, I may recommend to create > myself the immutable branch which can be pulled to Rafael's and Greg's trees > respectively. I'm also open for other proposals how to proceed. The series looks good to me and I've also tested it on one of the devices using the intel_cht_int33fe driver and everything seems to work fine, so for the whole series: Reviewed-by: Hans de Goede Tested-by: Hans de Goede Regards, Hans > > Andy Shevchenko (6): > device property: export set_secondary_fwnode() to modules > software node: Allow register and unregister software node groups > platform/x86: intel_cht_int33fe: Convert software node array to group > platform/x86: intel_cht_int33fe: Convert to use set_secondary_fwnode() > platform/x86: intel_cht_int33fe: Switch to use > acpi_dev_hid_uid_match() > platform/x86: intel_cht_int33fe: Fix spelling issues > > drivers/base/core.c | 1 + > drivers/base/swnode.c | 48 ++++++++ > .../platform/x86/intel_cht_int33fe_typec.c | 106 +++++++++--------- > include/linux/property.h | 3 + > 4 files changed, 108 insertions(+), 50 deletions(-) >