Re: [PATCH v1] regulator: Add Waveshare panel regulator driver

[Krzysztof Kozlowski <krzk@kernel.org>]

On 11/11/2025 11:43, Sudarshan Shetty wrote:
> This patch adds a regulator driver for Waveshare panels.
> The regulator provides controlled power sequencing and is also used
> to enable or disable the display backlight.
> 
> Features:
>  - I2C interface to control panel-specific regulator registers
>  - GPIO-based enable/disable support
>  - Integration with the Linux regulator framework
> 
> This driver is required for proper initialization of Waveshare
> MIPI-DSI panels supported by the companion DRM panel driver.
> 
> Signed-off-by: Sudarshan Shetty <tessolveupstream@gmail.com>
> ---
>  arch/arm64/configs/defconfig                  |   1 +

That is not regulator subsystem, don't mix.

>  drivers/regulator/Kconfig                     |  11 +
>  drivers/regulator/Makefile                    |   1 +
>  drivers/regulator/waveshare-panel-regulator.c | 294 ++++++++++++++++++
>  4 files changed, 307 insertions(+)
You did not implement feedback from your internal review. Please go back
to that first, so you will not ask maintainers to review obvious issues
which were already pointed out.


Best regards,
Krzysztof