From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72D3B11CBA for ; Sat, 21 Mar 2026 02:30:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774060218; cv=none; b=sX/b/8gX1o2kasBEvlSUaU7NFeXvTGBuzy1c7DpCjn6OOvqZsxiM67E+frP3r6th2/BUQPd6/MCS5DRys7O2h7TgB+KhAh4B0AxTUP8l0GcTjjeZeuyz2T4hlTouIdpPOwPeoXfmI09f7Lg4vXXbMFDHNuC8nS8i3zHN3b9FPrs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774060218; c=relaxed/simple; bh=KwnbyL/yi10Sqk1McQtYmWVP9BQbn1znlaxK6r20sXM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qzWsSjOHJSNiw71/yzSFj3QS5SPIz0AYSvz72/H2tu9UhfoJur38DE0CC4qH0+z17qI5IZQ3SFG1j0PGjDyURwcXYmMLiHFqloRZViiE+H9EMkOMFX2d5F09f8brRVLOqMBvPbJ6+TrSAPY9rIQEY5A9lp7dSJci16zDdy/CxiM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NlcsIfap; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fi23cqUW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NlcsIfap"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fi23cqUW" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62KDh5Zu539450 for ; Sat, 21 Mar 2026 02:30:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UBM4HXyCSzxpXUwFOevSunOj9VR6P5sCTO6jji0QkaI=; b=NlcsIfapGqR5K7fA Imszjq1seiSyhm3yVMl2IcaaKHBt6oTuSontc3+gsiNgMqu2JpMOxSpGcCHG6rEi YxjLNHYi923s38j2aYk2frV7O2tLbK74OwiIqIVnXpHmv1veUPer9GqlMR8D9gs2 YuZw4poJxJgEuC8Q+cZ4gBCKTxe5NxRP/0kWQWRavYjJ1QUz5DdKSqXjNLTvrax3 Ygx7cbQwcAqCvmm40cKqum7CHaAnQGxHKCyYNq9HJKfO9SqmhfkKo0sH9E5UEFqj u+B34MPhr54YCLHk/C0baRXqvO1VKpMg4mQxGchhDyM2YitxTUupvmwPb108GzKo 6hdtUA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d0sm6kkbn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 21 Mar 2026 02:30:16 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2b064884a7cso158238545ad.3 for ; Fri, 20 Mar 2026 19:30:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774060216; x=1774665016; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UBM4HXyCSzxpXUwFOevSunOj9VR6P5sCTO6jji0QkaI=; b=fi23cqUWgRkZOvs3/H0HlRtqbLPflwJQxlGOOreG2R+tcqjF5z37T2gZ56HN/mJW7C l0DFHotCj/cYCpF4sFjHQnlDY+WWgD43ZCUrXdLYwWK1A/5HTfM+xSiOl8mt6FfH4aGL eO2TXTnCMLibgVC73FDEYRRXZd6VJEo926/Tgfd2BF091HPVrFZt55cC0gq4EpyhoSuQ pAz45cJpQBPRcPdJSrMFLKmf94oq1xO1ZZ5BZwN5847KjLbWc6DmOrjemSSXIuukluIP jbOuedEkF+ZllYelLYZqEvZTpChYRwY6gOlhvFn4AYbZ/UJx5RI1uBsxtAYMMWEACgpO dSWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774060216; x=1774665016; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UBM4HXyCSzxpXUwFOevSunOj9VR6P5sCTO6jji0QkaI=; b=dng9nCW5wC/wDaD3hAeyjGnlp4Y8IgisjVv4CyNGMO+8mJmK50Bed42ktMtKjiOYBe 9Y8Nn+U/ft5u+8GDeS92skao9+FrWHeBbagWbWkDYAvCcX1n1/of/MctYRYjUB2T0JLS Gkp22Z6v8F5rjssg2W2u6OiIdQN+J0cDhc01+FBIkHt58+9YG095YL1ip4eDBel92zEr Fv8KYXtu9iSVcJMrArROIIiTvP1GHEWVv12UeBdQkop8bcic7Ry7mQQB6lDfW1HP7agT KG2rY1pbWrm2/kgIUFgcxaOSFqYgN+jbSjEjn7CWQ9CtmGdnKzbxKrScmwMWcvxNYER+ Ydaw== X-Forwarded-Encrypted: i=1; AJvYcCVQROSm5mVYYialZuvletvYNgCoLz0qs+E0bHd3oe6OHm6NqAo9UBgiRlo0PmmbshQfL+D3yKJ+2feLW2M=@vger.kernel.org X-Gm-Message-State: AOJu0YyeuNxfmrEvriFVsucOe41osHVVQi9vP+93SV05gobJBqDVJJpD UERj706A4dDiDrjdcpxFm5tAmc71yn+6bO+ZHtfKrCtie16xA7Gb9gKQ9ikq6dFGzimAw7iKZNN rIcKWQ9zFAf8QsLjz7zlJM1M9wQvXj036nbiB1VFuiUWM4NKM6wFSTY/wPt/B31TFcwY= X-Gm-Gg: ATEYQzwU6c8e0cU3Sydgepd5OMNj4kqxgBb+tUXLFpKktwsauwlk7XEru5BGHGtNsJJ IKsf4N2NIR6Z3lVQm1g4XwLjKJ+gicr2A1hB/7B2ABR1JMsn4rrzIlaz40mYCqj/swZnH/INagr Tm6SUXEn1qwhDTY4fWJ5dWUR0nUUuXTku9W21vtITcDgVSBKtWYn3rLMiEUubnT6QMGdAmHTqkE J7Nk0Nf4ESMQmJf39BN553Oa3ktYnr9xx/qMcrMRFu0xsjI+ctAOw/MpjB8fosFiTJbSClCD8cG Oj3qo3VaWn2KBj8KnACCIN+un26obZ9uUItuC/xSst/PUstvZ469jE8u1le1USBSyEy5vcbIz6W v9Z1HK4befT2JqJZcs97+I0IMNwrBe0pYJSLbJXQzh6uF0ppe3BRvduDd8Q2kpQ1HrjH7yecWMV chsAV2GtsT8VA= X-Received: by 2002:a17:903:283:b0:2ae:6205:2345 with SMTP id d9443c01a7336-2b0827b59e8mr43892465ad.35.1774060216025; Fri, 20 Mar 2026 19:30:16 -0700 (PDT) X-Received: by 2002:a17:903:283:b0:2ae:6205:2345 with SMTP id d9443c01a7336-2b0827b59e8mr43892295ad.35.1774060215500; Fri, 20 Mar 2026 19:30:15 -0700 (PDT) Received: from [10.133.33.199] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b08366c4f1sm36774925ad.59.2026.03.20.19.30.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Mar 2026 19:30:15 -0700 (PDT) Message-ID: <9aafc127-976b-4861-a8b1-3afc0e0bdae5@oss.qualcomm.com> Date: Sat, 21 Mar 2026 10:30:08 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 04/12] scsi: ufs: core: Add support for TX Equalization To: =?UTF-8?B?UGV0ZXIgV2FuZyAo546L5L+h5Y+LKQ==?= , "beanhuo@micron.com" , "mani@kernel.org" , "avri.altman@wdc.com" , "bvanassche@acm.org" , "martin.petersen@oracle.com" Cc: "linux-scsi@vger.kernel.org" , "adrian.hunter@intel.com" , "alim.akhtar@samsung.com" , "James.Bottomley@HansenPartnership.com" , "quic_nguyenb@quicinc.com" , "linux-kernel@vger.kernel.org" References: <20260308151409.3779137-1-can.guo@oss.qualcomm.com> <20260308151409.3779137-5-can.guo@oss.qualcomm.com> <42587e16218f1c51dbcbe6bb1639a843e10bcd80.camel@mediatek.com> <6e2f03ee-6cde-48ea-9f43-6b911117fe4b@oss.qualcomm.com> Content-Language: en-US From: Can Guo In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: NUNLHHblZBYiKsDU_Y5ALV0lRbLCRJCx X-Authority-Analysis: v=2.4 cv=Rv/I7SmK c=1 sm=1 tr=0 ts=69be02b8 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=lZOxv685zBznO1DyOMIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIxMDAxOCBTYWx0ZWRfX+W8S+8ibhaBz fEWcMIJoDhupq2nHs+ctmhgoS4JcL353m61DtWMkGTgUhoN3XpB2eZrHjacOAXSlLR0e9yF02jq sp9xf5kobwb4IEMzh/HVDRvlMkI0avvO22iMELPcS7PUXu84VCGSi28JLxCDbaP5yM0/iaH/r+v 4uGS86gt69811TfRRRTEj9WVj09sDfpX+PY5opylZxtZQxaCzkD6KjGqQjXO+IFgauVqTwIwaBi oevDY9yqaEhItHvCl7macjaj4dDOWQjGJ+QdqzQ+6JCJ2ycfTk8fjmtOTMkwGtFyIdTFVzP1y55 /3VrK5wsfqTWDItFxvjSYOlaOBIFeEbQdVu5mIy/CNYaUl6QdsAtHKVeaWsabpNfecUy3QK6sdC 4U0kBNNWDYUxgkbjrotr4zt/51cHnnR6g5RnjfZUzXnTmRnv9eAr2y1wMCUuwTXgttJKR4RoPeb QbwoptpcT8jGRiElSZg== X-Proofpoint-ORIG-GUID: NUNLHHblZBYiKsDU_Y5ALV0lRbLCRJCx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-21_01,2026-03-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 spamscore=0 phishscore=0 bulkscore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603210018 On 3/19/2026 8:42 PM, Peter Wang (王信友) wrote: > > On Thu, 2026-03-19 at 13:49 +0800, Can Guo wrote: > > Sure, for the lanes too. But I will still keep FOM records as u16, > > because we > > need to initialize it to a default value other than 0x0 to 0xFF such > > that we > > can differentiate a real FOM value (unit 8, read from RX_FOM) from > > the > > default one. > > > > Thanks, > > Can Guo. > > > > Hi Can, > > It seems keeping UINT16 is only for dumping this line. > if (fom == 0xFFFFFFFF) > seq_printf(s, "%8s%s", "-", " "); > > if the default scan covers all supported preshoot and > deemphasis values, should the FOM value always be set based > on the actual hardware reading and thus bypass the initial > value check for FOM? > Furthermore, if use_txeq_presets is true, could you simply > dump only 8 values and bypass the check if FOM is at its > initial value? I figured out a better way to handle this. Please check the next version. Thank you Peter for advising and providing valuable inputs. Thanks, Can Guo. > > Thanks. > Peter > > > ************* MEDIATEK Confidentiality Notice > ******************** > The information contained in this e-mail message (including any > attachments) may be confidential, proprietary, privileged, or otherwise > exempt from disclosure under applicable laws. It is intended to be > conveyed only to the designated recipient(s). Any use, dissemination, > distribution, printing, retaining or copying of this e-mail (including its > attachments) by unintended recipient(s) is strictly prohibited and may > be unlawful. If you are not an intended recipient of this e-mail, or believe > > that you have received this e-mail in error, please notify the sender > immediately (by replying to this e-mail), delete any and all copies of > this e-mail (including any attachments) from your system, and do not > disclose the content of this e-mail to any other person. Thank you!