From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2B7C3264C3 for ; Tue, 9 Jun 2026 16:59:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781024394; cv=none; b=HsQVoCA4dlEwd6EjLORO0DIRoK/DxIiHz6OzXTkhdUk8yXWSGIaSK8UQgxaiLiEw4d7ayF6wptnaK8XNKIunGszoEzl2ThvuGvYJZ/yuP981q3wj2W+MxJlcaGlNu2ce3tlldRPYq6JX4d5Rn6xmaeczLUV7g68TGauSeiOpQ68= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781024394; c=relaxed/simple; bh=MNObcwtk3k62SOnd78c5GiP0KzkCASkkFMdouK8Ue6Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mTS62ayAc6OOA56+Sij+HbLHBvt9lWoTAQuytGvcRJci+WmfHiY/wr2+kEhin7p/fkILcoOOxh7LZo+X7pedYDyZlvdFwv7V2p7edLjT4ioWPe0S2cBHZFJ+OltqTRfC5oEqF50BYIXBXtrOpgwx/pm0V6kgmPnck9qt0JhMfnQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cyWQb/Qd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XAsK9hdU; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cyWQb/Qd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XAsK9hdU" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 659GOXIt2746184 for ; Tue, 9 Jun 2026 16:59:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= e+aXLrz4Rbwm/JvVNnxvQFAPWGYjid4r3eNfZwYnoDg=; b=cyWQb/QdL61a1mtE tuwsSaK2PpYEmlyq/B69ieQamb8jXx/hsdU6HQ/nd9wx1zlF93Wzj8EE2ct2JIRU INDa95oZeSOFI54F4SGCkP/Wp+n+2MSKVVaZJweTqwjxX55YqEDrC3tbY3SKWKHg gmftXMHdpbKC9yTvAPeARuu/2JYxC+6iOr7xLk5MS0s1eU0fR7Srvc4b2w03PFJz nu4SONvk2MdpwN512Hr94pKz0GJ4Bmcrlp4L8RhvD1BOJcIU5LogewsLb+e0pvvw vzM751yCV8JH2+AJo8SIrIsfwnAKiN6SjLhWnXcDDg3JlcyGsinmtvmuCQY33yNF CHDvNw== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epg3wj6wm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Jun 2026 16:59:52 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c85a2bf5388so3140703a12.1 for ; Tue, 09 Jun 2026 09:59:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781024391; x=1781629191; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=e+aXLrz4Rbwm/JvVNnxvQFAPWGYjid4r3eNfZwYnoDg=; b=XAsK9hdUeW10W3Jr6oA7qhA85TIh0+Mh9+Lsnp+lgAW75MAm4ZWuLcnEw5IVXV74h3 E26u38TCqd6npGyRmWsOyZjCt3789vps/X6qrN0s3y44pOkuhjim8o2b7/6Qy8no9gH4 mfxtOLR1SmzmK6Q9iT7h7ShM5i4nzsI19D6+shkW3045Gs3szBHNxwccIhBkkjSHUAWH Bmus3VnMuyKkGHHHuWZbudi74FYasi6XvJxoNdkRrS4QI8qO4kqoP/W/hBqNBEeA5iVp 42kKIpVhoJvyfNzJVckQr2XZZWNyPd4EuUVpGAPcbJLR6iL4mOZbxyATSoizEzOlARc1 Hlpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781024391; x=1781629191; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=e+aXLrz4Rbwm/JvVNnxvQFAPWGYjid4r3eNfZwYnoDg=; b=XOUqQqHQEo2i8TVPB0nfsn0kO+IrY4MTSUFdbL5RAcrnfZCl6lBhQTI9EB0aipbgyJ 2mFJl0h3VzV93SSn5wTM9ducNXnJbWr3SNCdiyqoOfmDbpOF4j9ezL+26DMq0IfcajER 1jVY1uQLRESB9lGoDCljbZW4oHSbJV3fLAZlySrZrEva3t9C01Y0jwZxWxFxTK9uDywi fHf7DEqiJjCjdY9AaEgZE1kVKfRXy11IHRhWvEEg2V5nOROA3DVtEcw8MJS848lYX32X BDaPjVfnuDh5KQOOrUZ2bEtc5lWeSvWawxc5VdR4xsjJhuN/r28mLKaIQyFeVkHRN6/s xVPQ== X-Forwarded-Encrypted: i=1; AFNElJ8jVdQC4BBL+H1pptlmYl93zROy5Nb+ZEIfRwvMU3hjTRZqHPFPp3ydiAhArTPJAGDWHsK3rV02EQ6adA4=@vger.kernel.org X-Gm-Message-State: AOJu0YwBKatCno5Q2jugdWP5zmWcvLEPJBLFDuLbLXtWhHgGlwXi5eTF WwrJktJxY0mOJvbuO+LlnHdQ+ojwMHf1qtP1/6VACUPVCk1v/cPcYivgoVsESPea7QNApm8Xwo5 O1u7qnI3tCMbPvwSok+GqDp6LMj4KM7ttC55JRB3gL476EoUHjHI9QsSMNt/C1Eyyymc= X-Gm-Gg: Acq92OGax6xfgpAHdIXePoCe6455wdIu0PRzOFSYlrblvDFPkBL/rYTJfYnASjvxkj6 WRUOFSHffTc7HHdGDFTgkFtByxuANEQJfzcMg+bDNCKEQv6Cy5JW94owM9iC1uIZA5vBhhZu4/F 1CfdrRYKU9y37TIapV6TVSC1GidXWPlws9rITTcoafk6eZBh1yhxWaG+GHhosEnPvCasEft3Mgq DLFQ5J0Va/YWdZcaqEMhF4+cWhPcrcblBvF+L8LxfxYGd3dUg96conpiE0WLEGoBoEmwNuRDyCc 2Q9jLbu33weMuXIfNjEL0fJY9f/A5ZPMZBgTvpa0qDsykZiZ2gxBuY645BZkIiYwPiMltRDFVYp +nf68yPPU9oV8DuPrNncY/ZZbfVH8F5bXsH4zQkKIKLIbcSsRn/cRL7rg/V+WwPJIsPREuYeoA+ M7 X-Received: by 2002:a05:6a20:d529:b0:3b4:6155:cde8 with SMTP id adf61e73a8af0-3b4ccd858e4mr26753017637.21.1781024391263; Tue, 09 Jun 2026 09:59:51 -0700 (PDT) X-Received: by 2002:a05:6a20:d529:b0:3b4:6155:cde8 with SMTP id adf61e73a8af0-3b4ccd858e4mr26752983637.21.1781024390803; Tue, 09 Jun 2026 09:59:50 -0700 (PDT) Received: from [192.168.1.45] ([122.164.83.29]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c85df0a4e59sm19343348a12.16.2026.06.09.09.59.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2026 09:59:49 -0700 (PDT) Message-ID: <9ab1340d-72bb-48df-8784-a584a37b5c76@oss.qualcomm.com> Date: Tue, 9 Jun 2026 22:29:44 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] arm64: dts: qcom: ipq5018: Correct CMN PLL reference clock rate To: Konrad Dybcio , george.moussalem@outlook.com, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Luo Jie Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260521-ipq5018-cmn-pll-rate-fix-v2-1-04b28a92e0f2@outlook.com> Content-Language: en-US From: Kathiravan Thirumoorthy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA5MDE2MCBTYWx0ZWRfX5mQuerVUH0HI m7aI1vynHZzVqjgE4AloiN+qSpvKKgfLbhoiexnGhrYnTqpE60f76FdHpLOGyblq/B58FTYC+l5 FpDmvkWBbMh22g3o7M2fCfFsoYkyec6T2u4oM92DGWsvh7LIzJWfYfk3vMUH1qLC4TgDpPAJx2B fZwj8GTa07ypyeS/k+wtkGVdwBmDg7aiV24anXeYvogddDFcDdYY/IKPZzuQyLyO+FKMXEO5XLa 0wbGYQjduBBR5CY3bdA7XmopLLZhIWRfq1415IS0J2RGjGDRGYkeE34vfQAfUquPwYztLWPJjwT 6/bSkwEk1aPRL0xVgDNVop2lxR+x4LaEHCk2j3vWYRGqTavnOX2fkGfVnz4LasuSMpTYVAEFZq8 bOwMb4HZZumUu7+7DxUTn320J1KVVHkQ8+WT71Mh63CLKckVhFedcmIvkD382yfT9v2uIH3wFfD oBmihXOZy5EKuH+jzrA== X-Authority-Analysis: v=2.4 cv=csWrVV4i c=1 sm=1 tr=0 ts=6a284688 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=/Dmoft2P+kuiDiPUxd+r9g==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=bC-a23v3AAAA:8 a=UqCG9HQmAAAA:8 a=EUspDBNiAAAA:8 a=ZRiWFtQW1K3ZmbnfVNIA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 a=FO4_E8m0qiDe52t0p3_H:22 X-Proofpoint-GUID: 6to7Q-7Wn8syeoBs6TPzpoPI8xx1CHso X-Proofpoint-ORIG-GUID: 6to7Q-7Wn8syeoBs6TPzpoPI8xx1CHso X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-09_04,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 spamscore=0 adultscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 phishscore=0 suspectscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606090160 On 6/9/2026 8:42 PM, Konrad Dybcio wrote: > On 5/21/26 9:55 AM, George Moussalem via B4 Relay wrote: >> From: George Moussalem >> >> The correct CMN PLL reference clock rate for IPQ5018 is 4.8 GHz. >> >> The CMN PLL driver did not account for the ref clock divider which is 2 >> for IPQ5018. Therefore, the computed rate was twice the actual output. >> >> With the driver now accounting for the CMN PLL reference clock >> divider (commit: 88c543fff756), set the correct reference clock rate. >> >> Fixes: c006b249c544 ("arm64: dts: ipq5018: Add CMN PLL node") >> Signed-off-by: George Moussalem >> --- >> Changes in v2: >> - Removed line break in commit message between Fixes and SOB tags >> - Link to v1: https://patch.msgid.link/20260519-ipq5018-cmn-pll-rate-fix-v1-1-3c83a173c27f@outlook.com >> --- > I have no reference for this, but I trust you.. maybe +Kathiravan > could double-check Thanks Konrad. As per the HW doc and the commit 88c543fff756 ("clk: qcom: cmnpll: Account for reference clock divider"), default ref clock divider is 1 in IPQ5018. @Jie, Can you help here? > > Acked-by: Konrad Dybcio > > Konrad