From: nsaenzju@redhat.com
To: Matthias Brugger <mbrugger@suse.com>,
Charles Mirabile <cmirabil@redhat.com>,
linux-kernel@vger.kernel.org
Cc: Lee Jones <lee.jones@linaro.org>,
Serge Schneider <serge@raspberrypi.org>,
Stefan Wahren <stefan.wahren@i2se.com>,
linux-rpi-kernel@lists.infradead.org,
fedora-rpi@googlegroups.com, Mwesigwa Guma <mguma@redhat.com>,
Joel Savitz <jsavitz@redhat.com>
Subject: Re: [PATCH 1/5] drivers/mfd: sensehat: Raspberry Pi Sense HAT core driver
Date: Wed, 03 Nov 2021 17:53:40 +0100 [thread overview]
Message-ID: <9ab3e853d445ed8f7c2166df620dd67bff95454d.camel@redhat.com> (raw)
In-Reply-To: <d3de34d9-a144-f955-bd41-13384c9a04c8@suse.com>
On Wed, 2021-11-03 at 17:33 +0100, Matthias Brugger wrote:
> > +
> > + sensehat->joystick.pdev = sensehat_client_dev_register(sensehat,
> > + "sensehat-joystick");
>
> Why don't you use devm_mfd_add_devices function together with mfd_cell?
To complete Matthias' comment, why not use simple-mfd-i2c?
--
Nicolás Sáenz
next prev parent reply other threads:[~2021-11-03 16:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 21:55 [PATCH 0/5] Raspberry Pi Sense HAT driver Charles Mirabile
2021-10-29 21:55 ` [PATCH 1/5] drivers/mfd: sensehat: Raspberry Pi Sense HAT core driver Charles Mirabile
2021-10-30 8:02 ` kernel test robot
2021-10-30 17:20 ` Thomas Weißschuh
2021-11-03 16:33 ` Matthias Brugger
2021-11-03 16:53 ` nsaenzju [this message]
2021-10-29 21:55 ` [PATCH 2/5] drivers/input/joystick: sensehat: Raspberry Pi Sense HAT joystick driver Charles Mirabile
2021-10-29 22:03 ` Randy Dunlap
2021-10-30 14:02 ` kernel test robot
2021-10-29 21:55 ` [PATCH 3/5] drivers/auxdisplay: senshat: Raspberry Pi Sense HAT display driver Charles Mirabile
2021-10-30 22:12 ` kernel test robot
2021-11-03 16:47 ` Matthias Brugger
2021-10-29 21:55 ` [PATCH 4/5] Documentation: bindings/mfd: sensehat: Raspberry Pi Sense HAT device tree binding Charles Mirabile
2021-11-02 12:51 ` Rob Herring
2021-10-29 21:55 ` [PATCH 5/5] MAINTAINERS: Add sensehat driver authors to MAINTAINERS Charles Mirabile
2021-10-31 16:38 ` [PATCH 0/5] Raspberry Pi Sense HAT driver Miguel Ojeda
2021-11-01 14:18 ` Joel Savitz
2021-11-20 10:55 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ab3e853d445ed8f7c2166df620dd67bff95454d.camel@redhat.com \
--to=nsaenzju@redhat.com \
--cc=cmirabil@redhat.com \
--cc=fedora-rpi@googlegroups.com \
--cc=jsavitz@redhat.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mbrugger@suse.com \
--cc=mguma@redhat.com \
--cc=serge@raspberrypi.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®