From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD6FA259C80 for ; Wed, 31 Dec 2025 07:52:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767167571; cv=none; b=KDg1m5esJzHE35ux7ipnpDXp+in9urDGfISRIAs1P8rW3PxTUA9/eECAqdjbvXTfT2gBO5sqXZg+vp12kwibOzKrXRS8LVTintTtxfoCst1f4+g45TCvk3DawXseAifeFjJ+J8zwPm27NMcZJ8onIOtnX5W6/kXvLFdxbCrr2EA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767167571; c=relaxed/simple; bh=NKsGp0AmDWuGXpcnGlFd3miFG9eDtO7IMWcUFbegmr8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uNMXM5Ml1LvsAzlqoWNK+vLp7pCW+u2zpz+K9IJm3O+m/481SReRECkdMOS3eGtzd14ieilZFewiQxXwWO+72240Mh2e4zk0YLHdtYcsO9JLrYcnPgm0XP98rOD6NWnRQh90g3I1yGyoBOZMmi8nZasQRdh3FZwvyfEJ6n90+Ek= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YeA6aFLK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hYGj/eiy; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YeA6aFLK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hYGj/eiy" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BV78SnQ2733277 for ; Wed, 31 Dec 2025 07:52:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KyXIjIBC3vcDSkoYHVSATBvwhoF+AaKYl83HspRl0wo=; b=YeA6aFLKUNz7r4NG m6G8CDqCqOX4gyJewWmXHHiqFpXgAHYumzdqx1WZT6ndZT31qEwM0w/p4GPNg9O5 C0v4Kb5utzUDyv8Ej0DIk1LclZNB7SNWWaKvCQfmePaaDJBh9kcAx/OakJr7v8GK BbdIhrIJgA388svVWnQF2vV806QZ/gTb/v1Km4x74HqUdPn2Zt2Xva6SVYYPnX91 DWGP+kk9yQnCvYG8vvtqQC+qvHJKvgUiIEo3LKOldB0lHDm8kGialX1DObHo8fic E3bp3O4JxcQ0kgA4Ir5q+o0pv9O2lhUeXa61Dz1kaOh05Buw3q54epi062kQUHSV yS5TWA== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bcy6ag2p5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 31 Dec 2025 07:52:48 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-34eff656256so8022376a91.2 for ; Tue, 30 Dec 2025 23:52:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767167568; x=1767772368; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KyXIjIBC3vcDSkoYHVSATBvwhoF+AaKYl83HspRl0wo=; b=hYGj/eiyU43kApTaqiBJlGpxZLV6RWyHQQuKbkUNOWOWCf1rIqTDiZcwabNQ6Fj+ty yzbnt7oi0GlXZcXO6EO4fwlGsJV3p3wNtU/L26PUSM001tnyboCiXULPl7krwU9Grveu y8PTxmPqFx6jVhtU3JXofEE9ZXVRxdnawwoSlPgrbLe3TCNVE6Ue75nx02eC9zvDKnN/ /m4Yqb0FTni0WIoNPDbn5mEvxJ+MP+sTZWwPh6d8qVNKHvhTiQT4Cn6FOmuvNVJ4lfxb TZvaqjiSurU/pLrn8IcTv60Dnb8AtvkOC00YODCJuPAi9F3TUP+hl+I+uGtNDnmU664B /67Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767167568; x=1767772368; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KyXIjIBC3vcDSkoYHVSATBvwhoF+AaKYl83HspRl0wo=; b=nPrXuQU+N9ZTvDXBfJjAUSRdZ2FJoYsgkrhx0P73jfxT189GAoQTeObrSnUYQP6Em7 /jqSZfjgWbmkZHZfoaCZV9P9019+zzgvzrylQ80f1ZBpNT6xlLMKQbIk0qAdsiVq2g6X CQSr0bnRlS4OOfMjQ+REPIQUzPEmaZ5Q1CORC25mU/RoAxYDR1vCc0q1uCWJXsNJXdUo yv7tYi1NOdE3Yt3+UZlIV3sue33bhDBw6/iu66F4wTpaeGsUFFZQYw2rs607AEPmkWjM 9GkdneLWlOjKvGc2h47yuagcg5M2p7hDh91uCzhONbwzM1OE53TOoiRfH0hCujuJf4b/ 8pRw== X-Forwarded-Encrypted: i=1; AJvYcCXWeg2qR24GomM73BY0OsF5fXFlMyHX8F+KG2wgLPO5KoKYu1GNpUyyto+pY7PhhNxSCJBTu8Dn5Znea7k=@vger.kernel.org X-Gm-Message-State: AOJu0YxMMr8Ew4XeMfE4jxCR75Gh5QFihRFrHOGhnTzdUJXK+HNvGGlS Kcmijxk9Fd8UUnl9BKz1+zZ1zznlDz33YlJs8aarGUkj5bSDfqtnRSuhx2C6wiGrctNQtjs1G15 2wlgnLVMA0MmDbbvPmgDtqFQmZRoqHm/AEDvmhsLgCRWD+9HaEWckcR2C3YLcQezibgg= X-Gm-Gg: AY/fxX62xkc5p9ju/WExFPNrhCCWbhezU/YKeZv1zzgz61Y7CY9pbMEEBM3b20Vn45S h7qh0i3AiTJdoav2z0CA7c8c9o6k4O9PmPKqJBw4XC596sC2vUc9lJiO02kH1yrvfzQiRp/YVm/ MD/nTs0Tho23/wSDB4y8JxnPXy6LQAIZ6mImWOL0UX9i9L1WmNozAGlRkNaqrGMqlJIR3f+4QOK ogvQdAoYTK3q6tUhmj4dwExl1CDFljSaoRcIUCSZJnxa73c30dY7O8bJJj+GfOP4a/79Ah8Nx+h V6tznBdS1XEcqbbrBJ+kuc/nUcqLdy0Aqnxt9jBZKeIfSAh+0cKRXXk+4cMdjx+1Wt0ozaLdqCg 3UWv8Dr6ziO/flh8JidyXLa0lQNP4ArtNv4BIP0ULmQ== X-Received: by 2002:a17:90b:134f:b0:335:2747:a9b3 with SMTP id 98e67ed59e1d1-34e921f7bf0mr25730140a91.32.1767167567576; Tue, 30 Dec 2025 23:52:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IHeaZOZEeOVTiuQWpMfqrzeGgTnGb5ha7Il4l7bVR7L5mS3TqoZ8+7Xo7nEMfLTl1ktM3yFJw== X-Received: by 2002:a17:90b:134f:b0:335:2747:a9b3 with SMTP id 98e67ed59e1d1-34e921f7bf0mr25730129a91.32.1767167567019; Tue, 30 Dec 2025 23:52:47 -0800 (PST) Received: from [192.168.1.11] ([106.222.232.236]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c1e79a17fdesm29853432a12.8.2025.12.30.23.52.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Dec 2025 23:52:46 -0800 (PST) Message-ID: <9ab77a8e-a5e6-45bc-bc73-12c0d0700fc0@oss.qualcomm.com> Date: Wed, 31 Dec 2025 13:22:40 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/8] dt-bindings: thermal: Add qcom,qmi-cooling yaml bindings To: Dmitry Baryshkov Cc: Krzysztof Kozlowski , andersson@kernel.org, mathieu.poirier@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, rafael@kernel.org, daniel.lezcano@linaro.org, rui.zhang@intel.com, lukasz.luba@arm.com, konradybcio@kernel.org, amitk@kernel.org, mani@kernel.org, casey.connolly@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org References: <20251223123227.1317244-1-gaurav.kohli@oss.qualcomm.com> <20251223123227.1317244-4-gaurav.kohli@oss.qualcomm.com> <3fc177ca-0260-471d-b7a4-bd479f5e5855@oss.qualcomm.com> <60653b06-38c4-4276-a6e5-4a5900ba19d4@kernel.org> <74b33eb5-a75b-479e-92b3-cb6e094e5610@oss.qualcomm.com> Content-Language: en-US From: Gaurav Kohli In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: Ba2nnwaeQDqhFQvPUJyyIQcxjMQlfXKL X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjMxMDA2NyBTYWx0ZWRfX3Y0NxWSWyCTR oQuTSjWspTXowJBGa1aXINs6MxdPor1ZXttEOQzQYtMnIYd5PL9CS/R5PTVa3EmmRcS5BQx6LQ4 aAL50GbfarRFkF02qPaMUzjzDcuxqaZ4exiFMX0s6+O/g5514nSmWdjXEfC4Ntw5ymNE0i5yXYb 5QKBmB+JJoKvtIKgXo71pxF7K5hN+w7+KEmvH6jhtJPhYIuICfE4sajQS86QmD+f8qsquJL0hkA fM9Wbj3mhwuqIBwWRtZmlH9uuR3jE0ZfBc53zaYbJlv987lupoDuRkxe9PBJCvu8TQu2a7ekeCX BZF9tHkLCo/eEvOU5b+X6mdNxEDUzG66se1CLOWZCEkM/owHSyohFeO1C/+0/9DWLl/Icu8wZ8X m6mba2Cg0dAD2L6YpBnnUz8v/jF7wW8edxPo8UlwS8iS4qUzvHuH5s9bt+SK3lRTJVgRoK+tJT2 njVZ1//FSDPlksGT+sg== X-Proofpoint-GUID: Ba2nnwaeQDqhFQvPUJyyIQcxjMQlfXKL X-Authority-Analysis: v=2.4 cv=J9GnLQnS c=1 sm=1 tr=0 ts=6954d650 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=pk+8NuH2X28N4C0eta/h1Q==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=gEfo2CItAAAA:8 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=OIh3AFMXoxoDVeGUFMEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 a=sptkURWiP4Gy88Gu7hUp:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-31_02,2025-12-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 adultscore=0 impostorscore=0 spamscore=0 suspectscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512310067 On 12/31/2025 1:17 PM, Dmitry Baryshkov wrote: > On Wed, Dec 31, 2025 at 12:12:04PM +0530, Gaurav Kohli wrote: >> On 12/24/2025 3:54 PM, Krzysztof Kozlowski wrote: >>> On 24/12/2025 11:08, Gaurav Kohli wrote: >>>> On 12/24/2025 2:27 PM, Krzysztof Kozlowski wrote: >>>>> On 23/12/2025 13:32, Gaurav Kohli wrote: >>>>>> The cooling subnode of a remoteproc represents a client of the Thermal >>>>>> Mitigation Device QMI service running on it. Each subnode of the cooling >>>>>> node represents a single control exposed by the service. >>>>>> >>>>>> Add maintainer name also and update this binding for cdsp substem. >>>>>> >>>>>> Co-developed-by: Casey Connolly >>>>>> Signed-off-by: Gaurav Kohli >>>>>> Signed-off-by: Casey Connolly >>>>>> --- >>>>>> .../bindings/remoteproc/qcom,pas-common.yaml | 6 ++ >>>>>> .../bindings/thermal/qcom,qmi-cooling.yaml | 99 +++++++++++++++++++ >>>>>> 2 files changed, 105 insertions(+) >>>>>> create mode 100644 Documentation/devicetree/bindings/thermal/qcom,qmi-cooling.yaml >>>>>> >>>>>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml >>>>>> index 63a82e7a8bf8..bbc82253f76b 100644 >>>>>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml >>>>>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml >>>>>> @@ -77,6 +77,12 @@ properties: >>>>>> and devices related to the ADSP. >>>>>> unevaluatedProperties: false >>>>>> + cooling: >>>>>> + $ref: /schemas/thermal/qcom,qmi-cooling.yaml# >>>>>> + description: >>>>>> + Cooling subnode which represents the cooling devices exposed by the Modem. >>>>>> + unevaluatedProperties: false >>>>>> + >>>>>> required: >>>>>> - clocks >>>>>> - clock-names >>>>>> diff --git a/Documentation/devicetree/bindings/thermal/qcom,qmi-cooling.yaml b/Documentation/devicetree/bindings/thermal/qcom,qmi-cooling.yaml >>>>>> new file mode 100644 >>>>>> index 000000000000..90b46712d241 >>>>>> --- /dev/null >>>>>> +++ b/Documentation/devicetree/bindings/thermal/qcom,qmi-cooling.yaml >>>>>> @@ -0,0 +1,99 @@ >>>>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>>>>> +# Copyright 2023 (c), Linaro Limited >>>>>> + >>>>>> +%YAML 1.2 >>>>>> +--- >>>>>> +$id: http://devicetree.org/schemas/thermal/qcom,qmi-cooling.yaml# >>>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>>>> + >>>>>> +title: Qualcomm QMI based thermal mitigation (TMD) cooling devices. >>>>>> + >>>>>> +maintainers: >>>>>> + - Caleb Connolly >>>>>> + - Gaurav Kohli >>>>>> + >>>>>> +description: >>>>>> + Qualcomm QMI-based TMD cooling devices are used to mitigate thermal conditions >>>>>> + across multiple remote subsystems. These devices operate based on junction temperature >>>>>> + sensors (TSENS) associated with thermal zones for each subsystem. >>>>>> + >>>>>> + Each subnode corresponds to a control interface for a single instance of the TMD >>>>>> + service running on a remote subsystem. >>>>>> + >>>>>> +definitions: >>>>> defs, look at other code >>>>> >>>>> >>>>>> + tmd: >>>>>> + type: object >>>>>> + description: | >>>>>> + A single Thermal Mitigation Device exposed by a remote subsystem. >>>>> Missing proper formatting. Please do not send us code written by LLM. >>>> This patch is based on older series >>>> >>>> https://lore.kernel.org/linux-devicetree/20230905-caleb-qmi_cooling-v1-0-5aa39d4164a7@linaro.org/, did some manual changes to remove unusable code. >>> How? This is v1, not v2. How did you address other comments? Where did >>> you provide proper changelog? Why this is not correctly versioned/ >>> >>>> let me fix the formatting. This is not generated code. >>> I do not believe, because this: >>> >>> >>>>>> + phandle: true >> >> As i have mentioned in earlier reply, we are including below series: >> >> https://lore.kernel.org/linux-devicetree/20230905-caleb-qmi_cooling-v1-0-5aa39d4164a7@linaro.org/,) >> as this is client for remote proc cooling. >> I was seeing this error while using older yam files. >> >> ('cdsp_sw' was unexpected) >> >> from schema qcom,qmi-cooling.yaml >> >> So to avoid that, i have added phandle to avoid this error. will fix this in >> proper way >> by including another yaml file which will define the cdsp_sw, >> >> Below is the dt node: >> cooling { >> +                compatible = "qcom,qmi-cooling-cdsp"; >> +                    cdsp_sw: cdsp_sw { > You can't have a node called cdsp_sw. Underscores are not allowed in > node names. Will change to cdsp-sw. thanks Gaurav >> +                        label = "cdsp_sw"; >> +                        #cooling-cells = <2>; >> +                    }; >> +            }; >> >> >>> Does not exist. You cannot come with something like that, there is no >>> such code. >>> >>> Only LLM when parsing DTB could invent something like this. Otherwise >>> explain me please the process leading to coming to such change. >>> >>> Best regards, >>> Krzysztof