From: Michael Straube <straube.linux@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/7] staging: rtl8188eu: remove unused rtw_handle_tkip_mic_err()
Date: Mon, 30 Jul 2018 11:27:43 +0200 [thread overview]
Message-ID: <9ab9ce0f-4b2b-912b-04af-736ee9f23d4e@gmail.com> (raw)
In-Reply-To: <20180730090216.GA19163@kroah.com>
On 07/30/18 11:02, Greg KH wrote:
> On Sun, Jul 29, 2018 at 08:54:43PM +0200, Michael Straube wrote:
>> The function rtw_handle_tkip_mic_err() is never used, so remove it.
>> Discovered by cppcheck.
>
> That's a bad tool then, as this is used, and the build breaks when this
> patch is applied :(
>
> I've dropped it now.
>
> thanks,
>
> greg k-h
>
Hm, that's weired, I also checked with:
git grep -n rtw_handle_tkip_mic_err drivers/staging/rtl8188eu/
There were/are no uses and the driver builds and works fine here.
I don't see what I may have missed here. :(
Regards,
Michael
next prev parent reply other threads:[~2018-07-30 9:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-29 18:54 [PATCH v2 1/7] staging: rtl8188eu: remove unused dump_txrpt_ccx_88e() Michael Straube
2018-07-29 18:54 ` [PATCH v2 2/7] staging: rtl8188eu: remove unused should_forbid_n_rate() Michael Straube
2018-07-29 18:54 ` [PATCH v2 3/7] staging: rtl8188eu: remove unused rtw_handle_tkip_mic_err() Michael Straube
2018-07-30 9:02 ` Greg KH
2018-07-30 9:27 ` Michael Straube [this message]
2018-07-30 10:09 ` Michael Straube
2018-07-30 11:36 ` Greg KH
2018-07-29 18:54 ` [PATCH v2 4/7] staging: rtl8188eu: remove redundant includes Michael Straube
2018-07-29 18:54 ` [PATCH v2 5/7] staging: rtl8188eu: replace tabs with spaces Michael Straube
2018-07-29 18:54 ` [PATCH v2 6/7] staging: rtl8188eu: fix comparsion to true Michael Straube
2018-07-29 18:54 ` [PATCH v2 7/7] staging: rtl8188eu: remove unnecessary parentheses Michael Straube
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ab9ce0f-4b2b-912b-04af-736ee9f23d4e@gmail.com \
--to=straube.linux@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome