From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EADAA15C15E; Sun, 24 Nov 2024 19:41:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732477298; cv=none; b=hYVrlmx1bFab1mbjWClEU9f3E417v9n0H6CsR2fLxflfrevnFfFEDF6DakVbgfWLPZovUKxIWCoUABZ/WSTP0rSQhviDqULHfL4/Eg85x7nOsUstbc4Lh/SfL6Jacgq9UZBuUfxQO6AOKjAhZ5aF4rMmqxHHYy/YvPPTE3vdLLc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732477298; c=relaxed/simple; bh=QrYMgzJLpxKeviaNXRthlaJUQ1IM1jjxvRYFRshggDc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fZ4gy6K4buuKwYp7jzsuVTFg93TLPf9kCNgsqdCsTe9giTLUq8NUkdhuB0oirkoIufM4H0ye53489cwObGvkLBIwxksgF66qwLCESHukQaFTF+66qLMDOfEASUToLY/nG+svSJXPL3fjF7zbLX08/SJV5dfzxnYi1tYdRy6HadE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=WsgF/ZrB; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="WsgF/ZrB" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=+GykA3KcCgiZFrIubEllhonhwTqAWArBryLo6OL2K7A=; b=WsgF/ZrBh40RGoTDGIj8izylFB NPbyHzySRoNccf9RLlCl2XoPoDVvbXBoebGwykMuVwg9ueGS2YkG8g82X51zwJaL/D2+7LhLWcyGs nR2h1WCN9quegZbNlrYg7eYVo7OEBTeYR2dRZ70erM5Vf3JDpX2JU3z4XMYUc0zGdeXo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1tFIU1-00EJYp-SE; Sun, 24 Nov 2024 20:41:25 +0100 Date: Sun, 24 Nov 2024 20:41:25 +0100 From: Andrew Lunn To: Andrea della Porta Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof Wilczynski , Manivannan Sadhasivam , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Stefan Wahren , Herve Codina , Luca Ceresoli , Thomas Petazzoni Subject: Re: [PATCH v4 09/10] arm64: dts: bcm2712: Add external clock for RP1 chipset on Rpi5 Message-ID: <9abb376c-3399-4c2c-8e7c-cea1184ea370@lunn.ch> References: <8deccbd7ab8915957342a097410473445987b044.1732444746.git.andrea.porta@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8deccbd7ab8915957342a097410473445987b044.1732444746.git.andrea.porta@suse.com> On Sun, Nov 24, 2024 at 11:51:46AM +0100, Andrea della Porta wrote: > The RP1 found on Raspberry Pi 5 board needs an external crystal at 50MHz. > Add clk_rp1_xosc node to provide that. I'm wondering if this is the correct place for this clock. From your description, the bcm2712 itself does not provide the clock. There is a crystal on the board. So the board provides the clock. What happens when the RP1 is used on other boards? Also, does the RP1 need an actual crystal, or can you feed it a clock? Often such inputs are flexible, you can connect a crystal across two pins, or you can feed a clock into one pin. If a crystal is the only choice, i would probably have it part of the RP1 overlay. If a clock can be used, i would make it a board property. Andrew