mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jijie Shao <shaojijie@huawei.com>
To: Simon Horman <horms@kernel.org>
Cc: <shaojijie@huawei.com>, <yisen.zhuang@huawei.com>,
	<salil.mehta@huawei.com>, <davem@davemloft.net>,
	<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
	<shenjian15@huawei.com>, <wangjie125@huawei.com>,
	<liuyonglong@huawei.com>, <lanhao@huawei.com>,
	<wangpeiyang1@huawei.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 net-next 2/3] net: hns3: dump more reg info based on ras mod
Date: Sat, 16 Dec 2023 09:37:04 +0800	[thread overview]
Message-ID: <9ac4a3aa-602a-4bc9-aa73-c6896effefe3@huawei.com> (raw)
In-Reply-To: <20231215080104.GV5817@kernel.org>


on 2023/12/15 16:01, Simon Horman wrote:
> On Thu, Dec 14, 2023 at 10:11:34PM +0800, Jijie Shao wrote:
>>   #include "hclge_main.h"
>> +#include "hclge_debugfs.h"
> Hi Jijie Shao and Peiyang Wang,
>
> hclge_debugfs.h defines a number of constants, such as hclge_dbg_tqp_reg.
>
> With the above include added, these constants are now also defined
> in files that include hclge_err.h. Which leads to them
> being defined but unused in hclge_main.c.
>
> At a glance, it seems that these constants are only used in hclge_debugfs.c.
> Perhaps they could simply be moved there?
>
Yeah, I also plan to move them to hclge_debugfs.c.
So I'm going to add a patch to the v3 patchset to move them

Thanks,
Jijie


  reply	other threads:[~2023-12-16  1:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-14 14:11 [PATCH V2 net-next 0/3] There are some features for the HNS3 ethernet driver Jijie Shao
2023-12-14 14:11 ` [PATCH V2 net-next 1/3] net: hns3: add command queue trace for hns3 Jijie Shao
2023-12-14 21:04   ` Simon Horman
2023-12-16  1:42     ` Jijie Shao
2023-12-14 14:11 ` [PATCH V2 net-next 2/3] net: hns3: dump more reg info based on ras mod Jijie Shao
2023-12-15  8:01   ` Simon Horman
2023-12-16  1:37     ` Jijie Shao [this message]
2023-12-14 14:11 ` [PATCH V2 net-next 3/3] net: hns3: support dump pfc frame statistics in tx timeout log Jijie Shao
2023-12-15  8:03   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ac4a3aa-602a-4bc9-aa73-c6896effefe3@huawei.com \
    --to=shaojijie@huawei.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=lanhao@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liuyonglong@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=salil.mehta@huawei.com \
    --cc=shenjian15@huawei.com \
    --cc=wangjie125@huawei.com \
    --cc=wangpeiyang1@huawei.com \
    --cc=yisen.zhuang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®