From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DB04C433E0 for ; Fri, 19 Jun 2020 16:07:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E0B7521532 for ; Fri, 19 Jun 2020 16:07:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="h22kqdSU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391762AbgFSPIl (ORCPT ); Fri, 19 Jun 2020 11:08:41 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:38545 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2391739AbgFSPIa (ORCPT ); Fri, 19 Jun 2020 11:08:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592579309; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ekfNBp4LhaeldweXzxt1Y3e5nQyJLwRxW69/ByaQ7Fw=; b=h22kqdSUcUgVDxPkw3NOD25KCmLE4I+WKjJFqoYxmW/70GHZvtKaLIPxu7XNYSn5AhmLqf lW8UjjmzOYjhAmJwZ7iExpJdmo28FyDVLwSVrqW0tpH2Cq/lJqUOzNFAsps8j/Qve4DSkf 5rnTdG+4HAc0iD/8Cm9l5/rsylfMIM4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-472-GAiLBo89OQ-_9mut8R-4Ow-1; Fri, 19 Jun 2020 11:08:27 -0400 X-MC-Unique: GAiLBo89OQ-_9mut8R-4Ow-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E8E488018D9; Fri, 19 Jun 2020 15:08:25 +0000 (UTC) Received: from llong.remote.csb (ovpn-117-31.rdu2.redhat.com [10.10.117.31]) by smtp.corp.redhat.com (Postfix) with ESMTP id D56755D9E8; Fri, 19 Jun 2020 15:08:17 +0000 (UTC) Subject: Re: [PATCH v2 2/2] xfs: Fix false positive lockdep warning with sb_internal & fs_reclaim To: Christoph Hellwig Cc: "Darrick J. Wong" , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, Dave Chinner , Qian Cai , Eric Sandeen , Andrew Morton References: <20200617175310.20912-1-longman@redhat.com> <20200617175310.20912-3-longman@redhat.com> <20200619132155.GA27677@infradead.org> From: Waiman Long Organization: Red Hat Message-ID: <9ac58106-d7f5-fda2-2695-c68b5072f696@redhat.com> Date: Fri, 19 Jun 2020 11:08:17 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200619132155.GA27677@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/19/20 9:21 AM, Christoph Hellwig wrote: > I find it really confusing that we record this in current->flags. > per-thread state makes total sense for not dipping into fs reclaim. > But for annotating something related to memory allocation passing flags > seems a lot more descriptive to me, as it is about particular locks. > I am dropping this patchset as just using PF_MEMALLOC_NOFS is good enough. Cheers, Longman