From: Bean Huo <huobean@gmail.com>
To: Avri Altman <Avri.Altman@wdc.com>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jakob.rossler@nokia.com" <jakob.rossler@nokia.com>,
"sperson@micron.com" <sperson@micron.com>,
Bean Huo <beanhuo@micron.com>
Subject: Re: [PATCH v1] mmc-utils: Add General command CMD56 read support
Date: Mon, 11 Apr 2022 10:52:27 +0200 [thread overview]
Message-ID: <9ac83fe9bc33cce4b8691d49bdd155587196a62a.camel@gmail.com> (raw)
In-Reply-To: <DM6PR04MB6575816F943FB2F0D4099CDFFCE89@DM6PR04MB6575.namprd04.prod.outlook.com>
On Sat, 2022-04-09 at 09:03 +0000, Avri Altman wrote:
> > + memset(&idata, 0, sizeof(idata));
> > + idata.write_flag = 0;
> > + idata.opcode = MMC_GEN_CMD;
> > + idata.arg = arg;
> Practically arg is not needed, because bits[1..31] are meaningless.
> Maybe just set: idata.arg = 1;
>
> Thanks,
> Avri
Thanks for your review.
you are right arg is not needed according to eMMC spec. But as I
mentioned in the commit message, for the universal use. we need it for
the vendor-specific arg. I will change it that its arg will be 1 by
default if the user doesn't specific arg.
Kind regards,
Bean
next prev parent reply other threads:[~2022-04-11 8:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 17:48 Bean Huo
2022-04-09 9:03 ` Avri Altman
2022-04-11 8:52 ` Bean Huo [this message]
2022-04-11 10:04 ` Avri Altman
2022-04-14 10:38 ` Rossler, Jakob (Nokia - DE/Ulm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ac83fe9bc33cce4b8691d49bdd155587196a62a.camel@gmail.com \
--to=huobean@gmail.com \
--cc=Avri.Altman@wdc.com \
--cc=adrian.hunter@intel.com \
--cc=beanhuo@micron.com \
--cc=jakob.rossler@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=sperson@micron.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®