Re: [PATCH] ASoC: dt-bindings: wm8510: Convert to dtschema

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 02/04/2023 22:57, Saalim Quadri wrote:
> Convert the WM8510 audio CODEC bindings to DT schema
> 
> Signed-off-by: Saalim Quadri <danascape@gmail.com>
> ---
>  .../devicetree/bindings/sound/wlf,wm8510.yaml | 39 +++++++++++++++++++
>  .../devicetree/bindings/sound/wm8510.txt      | 18 ---------
>  2 files changed, 39 insertions(+), 18 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8510.yaml
>  delete mode 100644 Documentation/devicetree/bindings/sound/wm8510.txt
> 
> diff --git a/Documentation/devicetree/bindings/sound/wlf,wm8510.yaml b/Documentation/devicetree/bindings/sound/wlf,wm8510.yaml
> new file mode 100644
> index 000000000000..f45dad0fbef3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/wlf,wm8510.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/wlf,wm8510.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: WM8510 audio CODEC
> +
> +description: |
> +  These devices support both I2C and SPI (configured with pin strapping
> +  on the board).
> +
> +maintainers:
> +  - Mark Brown <broonie@kernel.org>

This should be rather someone from Cirrus or their regular contact -
patches@opensource.cirrus.com.

Also missing $ref to dai-common.yaml

> +
> +properties:
> +  compatible:
> +    const: wlf,wm8510
> +
> +  reg:
> +    description:
> +      The I2C address of the device for I2C, the chip select number for SPI

Drop description, it is obvious.

> +    maxItems: 1

sound-dai-cells with const:0

> +
> +additionalProperties: false

This goes after required. Look at example-schema. Anyway this should be
unevaluatedProperties: false, after adding the $ref.

> +
> +required:

Missing compatible.

> +  - reg
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        codec@1a {
> +            compatible = "wlf,wm8510";
> +            reg = <0x1a>;
> +        };
> +    };
> diff --git a/Documentation/devicetree/bindings/sound/wm8510.txt b/Documentation/devicetree/bindings/sound/wm8510.txt
> deleted file mode 100644
> index e6b6cc041f89..000000000000
> --- a/Documentation/devicetree/bindings/sound/wm8510.txt
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -WM8510 audio CODEC
> -
> -This device supports both I2C and SPI (configured with pin strapping
> -on the board).
> -
> -Required properties:
> -
> -  - compatible : "wlf,wm8510"
> -
> -  - reg : the I2C address of the device for I2C, the chip select
> -          number for SPI.
> -
> -Example:
> -
> -wm8510: codec@1a {
> -	compatible = "wlf,wm8510";
> -	reg = <0x1a>;
> -};

Best regards,
Krzysztof