mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yang Yingliang <yangyingliang@huawei.com>
To: <lee@kernel.org>, <krzysztof.kozlowski@canonical.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: core: fix UAF while using device of node
Date: Thu, 8 Dec 2022 21:53:20 +0800	[thread overview]
Message-ID: <9ad01578-9982-fd55-14a3-a74bf0906165@huawei.com> (raw)
In-Reply-To: <20221116074116.1022139-1-yangyingliang@huawei.com>

Hi,

On 2022/11/16 15:41, Yang Yingliang wrote:
> I got the following UAF report:
>
>    refcount_t: underflow; use-after-free.
>    WARNING: CPU: 1 PID: 270 at lib/refcount.c:29 refcount_warn_saturate+0x121/0x180
>    ...
>    OF: ERROR: memory leak, expected refcount 1 instead of -1073741824,
>    of_node_get()/of_node_put() unbalanced - destroy cset entry:
>    attach overlay node /i2c/pmic@62/powerkey
>
> The of_node of device assigned in mfd_match_of_node_to_dev() need be
> get, and it will be put in platform_device_release().
>
> Fixes: 002be8114007 ("mfd: core: Add missing of_node_put for loop iteration")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Is this patch good or do you have any suggestion ?

Thanks,
Yang
> ---
>   drivers/mfd/mfd-core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
> index 16d1861e9682..8e57f67719cf 100644
> --- a/drivers/mfd/mfd-core.c
> +++ b/drivers/mfd/mfd-core.c
> @@ -161,7 +161,7 @@ static int mfd_match_of_node_to_dev(struct platform_device *pdev,
>   	of_entry->np = np;
>   	list_add_tail(&of_entry->list, &mfd_of_node_list);
>   
> -	pdev->dev.of_node = np;
> +	pdev->dev.of_node = of_node_get(np);
>   	pdev->dev.fwnode = &np->fwnode;
>   #endif
>   	return 0;

  reply	other threads:[~2022-12-08 13:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-16  7:41 Yang Yingliang
2022-12-08 13:53 ` Yang Yingliang [this message]
2022-12-08 15:06   ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ad01578-9982-fd55-14a3-a74bf0906165@huawei.com \
    --to=yangyingliang@huawei.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®