From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCAC63F23C0 for ; Tue, 2 Jun 2026 16:01:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780416106; cv=none; b=jiMlh+B1+8/UsO+souqgsOJVVEOijMvdE63JBuOa6LgAaCbJTubRXQa9ESKnFXergXQcTD/o7wz2J7dpVZeMPeMbg7m7uKUs08eB5yrWV0bWS4C1GLX5AbseA13XzcVAA4pGrenSiv8IRCcDsf5Z4pvKXYgzv1m6yFdgexvBXCg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780416106; c=relaxed/simple; bh=U8u87X4cEVl7xeiYNxJ9zFvPFZ++Mg3bP33Z2AuGVtY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EUsyg4R0kWQ1554yOzfuE8yvnRRcmqAkPfqcqTZtwCJrG1BxjBFsjPLk91ZLDq+Pyn646amCyqHhmS+i6UwO+T/fSjcaWUWjZMMagudRDyhj0G+2ORcnC6mBOkJuO4Ng2kb4lYU3gtSkg/0oWRjHkUUk7oZQJP3RLbkbtgcVbsk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ecnlHgn9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GMoUPepq; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ecnlHgn9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GMoUPepq" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 652EVY3o1638282 for ; Tue, 2 Jun 2026 16:01:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9cHo+HdLfWszrxz8FIlQUKjxLUJPM3VQU+KKIaZgzs8=; b=ecnlHgn9Mot6/zjN P/Lx9gAlO0F9M5Kvyys6oergtAHmwf0hlMC/HPcSzcdCKheQFuMK71KnDqiEfI6d 5DuV7b0zGAXkDtD0/6wRkIGlOG8vdpY1uGDoEFEJvHDgGS+ngjGxhXHUgNGDWR6P Kf6+Dd9zji1rcznj+z9+EsUrpcQjEOQCG6S1KCXE4dAVYno1cVJaVyS50SCiAfsZ N+MnBRBijUy66CdEy25rXcteN97sWzBHdf4Vfy0sJM8USRWa87SQh8KkM1oUao5f N20FQe41eDuQq2kAxYpSFuIFIdeycxrJsFbAwIysRq/6PKFwZRZrLr5Q/BKl/f69 oKE2Hw== Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ehu1cj1a2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 02 Jun 2026 16:01:43 +0000 (GMT) Received: by mail-ua1-f70.google.com with SMTP id a1e0cc1a2514c-963954cf84dso5193394241.3 for ; Tue, 02 Jun 2026 09:01:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780416103; x=1781020903; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9cHo+HdLfWszrxz8FIlQUKjxLUJPM3VQU+KKIaZgzs8=; b=GMoUPepqf6N76FOYLuIr5xGGCATz4xc+1z19v8w4VDgkITohvCo7T/y+WXNZjh/v0a YNj7m9XtF9ZGJjhRpX7JQ8+RyOOWH2rlK0MWQbXfEaAqhLpTrFmUdS3J0jaNuItBGg43 AaIow70qcjem/a4VFMQOsDIn5LOrcBwZ62BuQkknojgnnSf0O2gF59xrLSj8wJjLDya7 Ew328Jjv1Dcx5sF2JAVCpvyQcFh0PsMgkT5SrzNZMIZG0ozicy1PfzAI4y7jbTsun2dx 4pHVDYVkfT7XlWAhKq4lgF02ZUfOkgEJQot4k6XRKMWh+h2YOZeKVkOTYYzFhE4TsJWE KPlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780416103; x=1781020903; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9cHo+HdLfWszrxz8FIlQUKjxLUJPM3VQU+KKIaZgzs8=; b=LQLANGITwXviq48OdaOUwK7HbpWpdFbgzWbISVd/YGIrdAUAwV/gz1fGA6EsV4ea2x ABCPI9gahxYiEpH6wy3KIe7CQEIF8GYL6McJjPBquXNo2Ul/0kL2GvR9wxhuHbD2Wb0g aQ/29/GNOVq4JvJmyJ3LDx7Yd38SqJna48m/XbFfp2p+TyidqmSWkj8WSGAFDXe6xvLj U+Yvv64ryHaw1ETbxoehcJDfZZ1BrgozWwor3PO9tFsQY4HTsj3i5drP9uqiPSqNETgp P52VAKRO1KoUmCVJxGORmQg6mLu2iLrWfhPn2p3XkDvA2IwKb22FMmvzgVUSYCKkspzI cdxg== X-Forwarded-Encrypted: i=1; AFNElJ/klKayIbno4BL1oJ6Qt+Yi9K51Sxw8bgTihBUyMUr4Tp+06RAKz55GJeKuGIIWXvJH+92xCGFtdtPuj2c=@vger.kernel.org X-Gm-Message-State: AOJu0YyQxzGF8KbBPbt586N5XqeMvXPg4BXXIMqA1wu9+HdPd8PCjCGK sEpcAF50xRdw87bhz8WNi4MHbUHhdn8QHmYni2PxCcnPYgYb29HhNVRERCRIVbn+ArlMdc1E100 idmjwmyarVdCb3a4v/ZiUYLVgtHD+VeWyOfenslU+q5NQI+sbT8MmGLbtq0mYsdl1itI= X-Gm-Gg: Acq92OEWq+HFj2tv3CShSsrAkFDq24yTB6EkjBHHXHyAQkkOY0lD7aozUhhsCWpluZy 2SJKsp07OsT10hOF0om4PMCBLJ6BdeDTlykmYJAU3jQUCEpEaKRjtGTXnFSEV0ADGd2Nnes/QJ3 /Osmlds13tG9F0sAVdeIUjDZfW8ItU6ne+0PSRbflr4AeHxtzo3ZtBzoHoMogWQ9GChl/Ygavfj oca+Nlory/Op6qSeJ2olb27SIP/LgqCy8fI3vIqC2b6zci4Zc0iutyfmwibK+CtVrRW2AjbPvKZ Tl26OUw8CnBqaVsx7p7xzNMO1cinx8ues9jQnySfHdXBoQRFBqtHSgPFCKnPylR6SAy4wQMwdUp q4NeR278nGiwhtByGKMR4eNkr0Itux/t2sR0IhGN2IwKP1gx9xyh6b0uFMEN0f6qHUTUMzaCj32 Hc X-Received: by 2002:a05:6102:a49:b0:639:4bb7:c916 with SMTP id ada2fe7eead31-6ea1cc674f6mr506764137.3.1780416088603; Tue, 02 Jun 2026 09:01:28 -0700 (PDT) X-Received: by 2002:a05:6102:a49:b0:639:4bb7:c916 with SMTP id ada2fe7eead31-6ea1cc674f6mr505747137.3.1780416079609; Tue, 02 Jun 2026 09:01:19 -0700 (PDT) Received: from [192.168.2.1] (146725694.box.freepro.com. [130.180.211.218]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f351d40sm199325f8f.26.2026.06.02.09.01.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jun 2026 09:01:18 -0700 (PDT) Message-ID: <9adbe3cb-d42e-4b89-b6d7-62dd58b98e15@oss.qualcomm.com> Date: Tue, 2 Jun 2026 18:01:13 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] thermal: amlogic: add missing dependency on MESON_SM To: linux-kernel-dev@aliel.fr, Neil Armstrong , Daniel Lezcano , Zhang Rui , "Rafael J. Wysocki" , Lukasz Luba Cc: Guillaume La Roque , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Mark Brown , kernel test robot References: <20260602-fix-missing-meson_sm-symbol-v3-1-6f7f69cd7d6c@aliel.fr> Content-Language: en-US From: Daniel Lezcano In-Reply-To: <20260602-fix-missing-meson_sm-symbol-v3-1-6f7f69cd7d6c@aliel.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: gWMwtyfHaULW1Ul3KPIoB9gX8-qEfdiN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAyMDE1NSBTYWx0ZWRfX+aQdppvsVd/P 0wIEkSperF28Q5AsygIRqOisuajJy00UhCixqyfnipkFiBdGYn+YvD6tY+hdK7sfXry47NTVor5 Rbyv/j9x4Jc0SNCgIItWLdykBwMD1rY5jTnjnDT0YtWgt/yWv0vXLb5V9rG8IbSvrvbVk5At2p/ 3CVT82nBqMDpIUt5yowiedzq6Zv4G1sy/DIKaxxliUytmJsfJcgYbB7k/fhwWOWiX3N9zXwygi9 /A3A4eqSJ4L8PWCa+fL5gIaPS1lBMzrBA5SqtYcK0gE5OLeJrH/ifCajOtdZCmRfyLjnYu/yvna VxRsOijxlBgnJJc4pwFHBTOsl2VGVo+2oa4z7eK5WXbJYxiDKHHB9ELEUFV3RVZyAXxEme2N7nx lVOfeC2V0GLgfThdZslpK+PuQa+XZ/uyNqrGegtEvF3Is+Xv+pGLCcYDvFzbpNoyoV4NFhww5W4 wlNsyN14heXea+3ElRg== X-Proofpoint-GUID: gWMwtyfHaULW1Ul3KPIoB9gX8-qEfdiN X-Authority-Analysis: v=2.4 cv=O6IJeh9W c=1 sm=1 tr=0 ts=6a1efe67 cx=c_pps a=R6oCqFB+Yf/t2GF8e0/dFg==:117 a=uw/3876vWhRnNVL35W6mqQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=QyXUC8HyAAAA:8 a=tv4TSO8pNUtKKAd5OgUA:9 a=QEXdDO2ut3YA:10 a=TD8TdBvy0hsOASGTdmB-:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-02_02,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 adultscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606020155 On 6/2/26 16:19, Ronald Claveau via B4 Relay wrote: > From: Ronald Claveau > > The amlogic thermal driver calls meson_sm_get() and > meson_sm_get_thermal_calib() which are exported by the meson_sm > driver. Without CONFIG_MESON_SM enabled, the build fails with > undefined references to these symbols. > > Add a proper Kconfig dependency on MESON_SM instead of relying on > stub functions, which makes the dependency explicit and prevents > invalid configurations. > > Closes: https://lore.kernel.org/oe-kbuild-all/202605291530.en7aGn7w-lkp@intel.com/ > Reported-by: Mark Brown > Reported-by: kernel test robot > Signed-off-by: Ronald Claveau > --- > Changes in v3: > - Add a dependency on MESON_SM instead of stub functions. > - Link to v2: https://lore.kernel.org/r/20260531-fix-missing-meson_sm-symbol-v2-1-1def8c3c169f@aliel.fr > > Changes in v2: > - Replace #ifdef CONFIG_MESON_SM by #if IS_ENABLED(CONFIG_MESON_SM) > to cover builtin and module in config. > - Add missing trailers for kernel test robot. > - Link to v1: https://lore.kernel.org/r/20260530-fix-missing-meson_sm-symbol-v1-1-3fb672b989d4@aliel.fr > --- > drivers/thermal/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 1c4a5cd5a23ee..810eeccedfbab 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -436,6 +436,7 @@ config AMLOGIC_THERMAL > tristate "Amlogic Thermal Support" > default ARCH_MESON > depends on OF && ARCH_MESON > + depends on MESON_SM > help > If you say yes here you get support for Amlogic Thermal > for G12 SoC Family. Did you forget to remove the stubs ?