From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13FF9E7AD5E for ; Tue, 3 Oct 2023 14:31:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240132AbjJCObe (ORCPT ); Tue, 3 Oct 2023 10:31:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240092AbjJCOb2 (ORCPT ); Tue, 3 Oct 2023 10:31:28 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30E9B9E; Tue, 3 Oct 2023 07:31:25 -0700 (PDT) Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 393E2Fux010357; Tue, 3 Oct 2023 14:31:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=c2Cp9OddIEL1kWONxLBIDhUo5rcQSS3r5qyCIgC8rKg=; b=Hm5neSyzLcG86uBS5KlELSXNOpwinWo4Q3ku88MHWxF0NVQKVfrE52L0Vu/Pswa5wA8T XJHrt9utbnYV6+JCx0GpRhsa/jBdU2AJxrjPllQRf9CtGmLWEOh918z6UPaLFwO9kK5a 3dZqCHIE25qaqqqsG5rif47mVpzcV7aUF9KbnzE3zxoECVl2Rk6Y0M/meNWDb6fZ3Qv+ /8DILrKue6JbKPwh1hF2hNg+7jh/qcE6Wh6ODOoHPNJRCw71AC+D4Z44wr3nzX1CfR18 7CB0goxhuLibmKSmv314+lO+XHWnhdOsJB5pXp3QmxPS8O1c7qnMTfrZ2HFoGgj+rtw7 3w== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3tg77esj54-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 03 Oct 2023 14:31:02 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 393EV0jw024246 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 3 Oct 2023 14:31:00 GMT Received: from [10.216.32.208] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Tue, 3 Oct 2023 07:30:50 -0700 Message-ID: <9addc1e2-0101-4068-9e0f-857a5a88ef90@quicinc.com> Date: Tue, 3 Oct 2023 20:00:45 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/8] dt-bindings: usb: dwc3: Add clocks on Qualcomm IPQ5332 Content-Language: en-US To: Dmitry Baryshkov , , , , , , , , , , , , , , , , , , , , , , , , , , CC: , , References: <20230929084209.3033093-1-quic_ipkumar@quicinc.com> <20230929084209.3033093-5-quic_ipkumar@quicinc.com> From: Praveenkumar I In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: zyLHtK8CyW2RL-zvwKDi8PzaBwsna2VW X-Proofpoint-GUID: zyLHtK8CyW2RL-zvwKDi8PzaBwsna2VW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-03_11,2023-10-02_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 mlxscore=0 bulkscore=0 clxscore=1015 malwarescore=0 suspectscore=0 spamscore=0 priorityscore=1501 mlxlogscore=822 phishscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310030106 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/30/2023 10:53 PM, Dmitry Baryshkov wrote: > On 29/09/2023 11:42, Praveenkumar I wrote: >> Add aux and lfps clocks in Qualcomm IPQ5332. These clocks are required >> for USB Super-Speed support. >> >> Signed-off-by: Praveenkumar I >> --- >>   .../devicetree/bindings/usb/qcom,dwc3.yaml    | 20 ++++++++++++++++++- >>   1 file changed, 19 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml >> b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml >> index 67591057f234..18af2887b984 100644 >> --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml >> +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml >> @@ -149,6 +149,25 @@ allOf: >>               - const: sleep >>               - const: mock_utmi >>   +  - if: >> +      properties: >> +        compatible: >> +          contains: >> +            enum: >> +              - qcom,ipq5332-dwc3 >> +    then: >> +      properties: >> +        clocks: >> +          maxItems: 6 >> +        clock-names: >> +          items: >> +            - const: core >> +            - const: iface >> +            - const: sleep >> +            - const: mock_utmi >> +            - const: aux >> +            - const: lfps > > Could you please also describe the lfps clock in the top-level clocks > entry? Sure, will add. > >> + >>     - if: >>         properties: >>           compatible: >> @@ -238,7 +257,6 @@ allOf: >>           compatible: >>             contains: >>               enum: >> -              - qcom,ipq5332-dwc3 >>                 - qcom,msm8994-dwc3 >>                 - qcom,qcs404-dwc3 >>       then: > -- Thanks, Praveenkumar