mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: ew kim <ew.kim@samsung.com>,
	broonie@kernel.org, s.nawrocki@samsung.com, robh@kernel.org,
	krzk+dt@kernel.org
Cc: lgirdwood@gmail.com, tiwai@suse.com, perex@perex.cz,
	conor+dt@kernel.org, alim.akhtar@samsung.com,
	linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/9] arm64: dts: exynosautov920: Add ABOX IPC Generic device node
Date: Mon, 21 Jul 2025 08:45:59 +0200	[thread overview]
Message-ID: <9ae13771-e577-4005-84cd-230aba048085@kernel.org> (raw)
In-Reply-To: <20250721023052.3586000-6-ew.kim@samsung.com>

On 21/07/2025 04:30, ew kim wrote:
> This patch adds a new child node `abox_ipc_generic` under the

Please read kernel submitting patches and DT bindings submitting patches.

> `abox_generic` node for ExynosAuto v920. The ABOX IPC Generic
> driver handles inter-processor communication (IPC) between
> the ABOX DSP and host SoC using IRQs.
> 
> The node includes configuration for the number of IRQ channels
> used for IPC routing. This allows SoC-specific subsystems to
> send and receive messages through the ABOX generic audio stack.
> 
> Signed-off-by: ew kim <ew.kim@samsung.com>
> ---
>  arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts |  6 +++++-
>  arch/arm64/boot/dts/exynos/exynosautov920.dtsi     | 10 ++++++++--
>  2 files changed, 13 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> index a870c0b6847f..2f4cf112675a 100644
> --- a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> +++ b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> @@ -89,4 +89,8 @@ &xtcxo {
>  
>  &abox_generic {
>  	status = "okay";
> -};
> \ No newline at end of file
> +};
> +
> +&abox_ipc_generic {
> +	status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> index 4f086a7a79c8..21bcbcf7e2b6 100644
> --- a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> @@ -1133,8 +1133,14 @@ abox_generic: abox_generic {
>  		samsung,num-pcm-capture = <32>;
>  		samsung,num-i2s-dummy-backend = <5>;
>  		status = "disabled";
> -		#address-cells = <2>;
> -		#size-cells = <1>;
> +		/* #address-cells = <2>; */
> +		/* #size-cells = <1>; */
> +
> +		abox_ipc_generic: abox_ipc_generic {
> +			compatible = "samsung,abox_ipc_generic";

No bindings. Are you sure you follow standard patchset order?

Best regards,
Krzysztof

  reply	other threads:[~2025-07-21  6:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20250721024611epcas2p43099e043aaa6f48c05eb0237065d31c7@epcas2p4.samsung.com>
2025-07-21  2:30 ` Add ExynosAuto ABOX generic platform and PCM support ew kim
     [not found]   ` <CGME20250721024611epcas2p45ddc52c1644f5779c7da822573f03246@epcas2p4.samsung.com>
2025-07-21  2:30     ` [PATCH 1/9] ASoC: samsung: Add generic ABOX management driver ew kim
2025-07-30 12:04       ` Mark Brown
     [not found]   ` <CGME20250721024611epcas2p37ecbc204ea695d97f6477c04712a9974@epcas2p3.samsung.com>
2025-07-21  2:30     ` [PATCH 2/9] arm64: dts: exynosautov920: add abox_generic dt node ew kim
2025-07-21  6:41       ` Krzysztof Kozlowski
     [not found]   ` <CGME20250721024611epcas2p47ebaf8cb494fc2bf71a83b00ba47f2b3@epcas2p4.samsung.com>
2025-07-21  2:30     ` [PATCH 3/9] ASoC: dt-bindings: sound: Add Samsung ExynosAuto ABOX binding ew kim
2025-07-21  6:44       ` Krzysztof Kozlowski
     [not found]   ` <CGME20250721024611epcas2p4baca500b3b1f185dcdc35552b2abe8d9@epcas2p4.samsung.com>
2025-07-21  2:30     ` [PATCH 4/9] ASoC: samsung: abox: Add IPC generic support for message forwarding ew kim
2025-07-30 12:06       ` Mark Brown
     [not found]   ` <CGME20250721024611epcas2p375cd5e4b53fcff3b69a39ef19c0825a4@epcas2p3.samsung.com>
2025-07-21  2:30     ` [PATCH 5/9] arm64: dts: exynosautov920: Add ABOX IPC Generic device node ew kim
2025-07-21  6:45       ` Krzysztof Kozlowski [this message]
     [not found]   ` <CGME20250721024611epcas2p382f3decd51152a5c89c673f222e22da1@epcas2p3.samsung.com>
2025-07-21  2:30     ` [PATCH 6/9] ASoC : dt-bindings: sound: Add binding for ABOX IPC Generic ew kim
2025-07-21  6:46       ` Krzysztof Kozlowski
     [not found]   ` <CGME20250721024611epcas2p423f2e6084264b08f43c6f86ce1ad0892@epcas2p4.samsung.com>
2025-07-21  2:30     ` [PATCH 7/9] ASoC: samsung: Add PCM driver with solution support ew kim
     [not found]   ` <CGME20250721024611epcas2p3da8e99d27a57cf7ad4ed46729e86602f@epcas2p3.samsung.com>
2025-07-21  2:30     ` [PATCH 8/9] arm64: dts: exynosautov920: add PCM playback/capture ew kim
     [not found]   ` <CGME20250721024612epcas2p122d627cfb90eac508b6ed3667acd9b9b@epcas2p1.samsung.com>
2025-07-21  2:30     ` [PATCH 9/9] ASoC: dt-bindings: sound: exynosauto: add PCM frontend nodes for ABOX generic ew kim
2025-07-21  6:47       ` Krzysztof Kozlowski
2025-07-30 12:46   ` Add ExynosAuto ABOX generic platform and PCM support Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ae13771-e577-4005-84cd-230aba048085@kernel.org \
    --to=krzk@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=ew.kim@samsung.com \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=robh@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®